staging: media: atomisp: make hive_int8 explictly signed
Commit Message
The current definition of hive_int8 is a naked char, without any sign
specifier. This is incorrect on platforms such as arm, where char is
unsigned. Fortunately nothing in the kernel actually uses a hive_int8
type, but in case it gets used later rather than removed, this makes it
explicitly signed.
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
Greg - if you're going to take this for 6.1, that's fine with me.
Otherwise, if it's for 6.2, I'll take this in my unsigned-char tree to
keep all of these fixups together. -Jason
drivers/staging/media/atomisp/pci/hive_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, Nov 03, 2022 at 01:19:14AM +0100, Jason A. Donenfeld wrote:
> The current definition of hive_int8 is a naked char, without any sign
> specifier. This is incorrect on platforms such as arm, where char is
> unsigned. Fortunately nothing in the kernel actually uses a hive_int8
> type, but in case it gets used later rather than removed, this makes it
> explicitly signed.
>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
> Greg - if you're going to take this for 6.1, that's fine with me.
> Otherwise, if it's for 6.2, I'll take this in my unsigned-char tree to
> keep all of these fixups together. -Jason
I don't take drivers/staging/media/* patches, they go through Mauro's
tree, so I'll let him and you fight it out here :)
thanks,
greg k-h
@@ -42,7 +42,7 @@ typedef unsigned int hive_bool;
#define hive_false 0
#define hive_true 1
-typedef char hive_int8;
+typedef signed char hive_int8;
typedef short hive_int16;
typedef int hive_int32;
typedef long long hive_int64;