diff mbox series

pci/cx18: Use 'unsigned int' instead of just 'unsigned'.

Message ID 20220824133149.65002-1-yuanjilin@cdjrlc.com (mailing list archive)
State Rejected
Headers
Series pci/cx18: Use 'unsigned int' instead of just 'unsigned'. |

Commit Message

Jilin Yuan Aug. 24, 2022, 1:31 p.m. UTC 
  Prefer 'unsigned int' to bare use of 'unsigned'.

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 drivers/media/pci/cx18/cx18-firmware.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Hans Verkuil Aug. 24, 2022, 2:56 p.m. UTC | #1 
There are loads of old drivers that do this, it's not worth the effort
to change this.

Sorry.

I'll reject such patches.

Regards,

	Hans

On 24/08/2022 15:31, Jilin Yuan wrote:
> Prefer 'unsigned int' to bare use of 'unsigned'.
> 
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> ---
>  drivers/media/pci/cx18/cx18-firmware.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/pci/cx18/cx18-firmware.c b/drivers/media/pci/cx18/cx18-firmware.c
> index 1b038b2802bf..b72bcbc1fed6 100644
> --- a/drivers/media/pci/cx18/cx18-firmware.c
> +++ b/drivers/media/pci/cx18/cx18-firmware.c
> @@ -88,7 +88,7 @@ static int load_cpu_fw_direct(const char *fn, u8 __iomem *mem, struct cx18 *cx)
>  {
>  	const struct firmware *fw = NULL;
>  	int i, j;
> -	unsigned size;
> +	unsigned int size;
>  	u32 __iomem *dst = (u32 __iomem *)mem;
>  	const u32 *src;
>  
> @@ -128,7 +128,7 @@ static int load_apu_fw_direct(const char *fn, u8 __iomem *dst, struct cx18 *cx,
>  {
>  	const struct firmware *fw = NULL;
>  	int i, j;
> -	unsigned size;
> +	unsigned int size;
>  	const u32 *src;
>  	struct cx18_apu_rom_seghdr seghdr;
>  	const u8 *vers;
diff mbox series

Patch

diff --git a/drivers/media/pci/cx18/cx18-firmware.c b/drivers/media/pci/cx18/cx18-firmware.c
index 1b038b2802bf..b72bcbc1fed6 100644
--- a/drivers/media/pci/cx18/cx18-firmware.c
+++ b/drivers/media/pci/cx18/cx18-firmware.c
@@ -88,7 +88,7 @@  static int load_cpu_fw_direct(const char *fn, u8 __iomem *mem, struct cx18 *cx)
 {
 	const struct firmware *fw = NULL;
 	int i, j;
-	unsigned size;
+	unsigned int size;
 	u32 __iomem *dst = (u32 __iomem *)mem;
 	const u32 *src;
 
@@ -128,7 +128,7 @@  static int load_apu_fw_direct(const char *fn, u8 __iomem *dst, struct cx18 *cx,
 {
 	const struct firmware *fw = NULL;
 	int i, j;
-	unsigned size;
+	unsigned int size;
 	const u32 *src;
 	struct cx18_apu_rom_seghdr seghdr;
 	const u8 *vers;