[7/7] venus : Allow MIN/MAX settings for the v4l2 encoder controls defined range .
Commit Message
From: Vikash Garodia <quic_vgarodia@quicinc.com>
Control MIN/MAX range defined as 0 to 1 ,as MIN value setting enabled
for V4L2_CID_MPEG_VIDEO_H264_8X8_TRANSFORM .
error details: fail: v4l2-test-controls.cpp(516): invalid maximum range check
Change-Id: I8db2585d35a72bf238cec4cd8f49661170e98a85
Signed-off-by: Viswanath Boma <quic_vboma@quicinc.com>
---
drivers/media/platform/qcom/venus/venc_ctrls.c | 13 -------------
1 file changed, 13 deletions(-)
Comments
On 7/12/22 15:23, Viswanath Boma wrote:
> From: Vikash Garodia <quic_vgarodia@quicinc.com>
>
> Control MIN/MAX range defined as 0 to 1 ,as MIN value setting enabled
> for V4L2_CID_MPEG_VIDEO_H264_8X8_TRANSFORM .
>
> error details: fail: v4l2-test-controls.cpp(516): invalid maximum range check
>
> Change-Id: I8db2585d35a72bf238cec4cd8f49661170e98a85
> Signed-off-by: Viswanath Boma <quic_vboma@quicinc.com>
> ---
> drivers/media/platform/qcom/venus/venc_ctrls.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/venc_ctrls.c b/drivers/media/platform/qcom/venus/venc_ctrls.c
> index 95fdad160732b..6dcbd3baa9c86 100644
> --- a/drivers/media/platform/qcom/venus/venc_ctrls.c
> +++ b/drivers/media/platform/qcom/venus/venc_ctrls.c
> @@ -323,19 +323,6 @@ static int venc_op_s_ctrl(struct v4l2_ctrl *ctrl)
> if (ctr->profile.h264 != V4L2_MPEG_VIDEO_H264_PROFILE_HIGH &&
> ctr->profile.h264 != V4L2_MPEG_VIDEO_H264_PROFILE_CONSTRAINED_HIGH)
> return -EINVAL;
> -
> - /*
> - * In video firmware, 8x8 transform is supported only for
> - * high profile(HP) and constrained high profile(CHP).
> - * If client wants to disable 8x8 transform for HP/CHP,
> - * it is better to set profile as main profile(MP).
> - * Because there is no difference between HP and MP
> - * if we disable 8x8 transform for HP.
> - */
> -
Please keep the comment.
> - if (ctrl->val == 0)
> - return -EINVAL;
> -
> ctr->h264_8x8_transform = ctrl->val;
> break;
> default:
@@ -323,19 +323,6 @@ static int venc_op_s_ctrl(struct v4l2_ctrl *ctrl)
if (ctr->profile.h264 != V4L2_MPEG_VIDEO_H264_PROFILE_HIGH &&
ctr->profile.h264 != V4L2_MPEG_VIDEO_H264_PROFILE_CONSTRAINED_HIGH)
return -EINVAL;
-
- /*
- * In video firmware, 8x8 transform is supported only for
- * high profile(HP) and constrained high profile(CHP).
- * If client wants to disable 8x8 transform for HP/CHP,
- * it is better to set profile as main profile(MP).
- * Because there is no difference between HP and MP
- * if we disable 8x8 transform for HP.
- */
-
- if (ctrl->val == 0)
- return -EINVAL;
-
ctr->h264_8x8_transform = ctrl->val;
break;
default: