[31/40] media: atomisp: drop HMM_BO_SHARE type

Message ID 20220613195137.8117-32-hdegoede@redhat.com (mailing list archive)
State Superseded
Headers
Series media: atomisp: Various hmm and other cleanups |

Commit Message

Hans de Goede June 13, 2022, 7:51 p.m. UTC
  HMM_BO_SHARE is not supported by the hmm_bo code at all, drop it.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/staging/media/atomisp/include/hmm/hmm_bo.h | 1 -
 drivers/staging/media/atomisp/pci/hmm/hmm_bo.c     | 5 +----
 2 files changed, 1 insertion(+), 5 deletions(-)
  

Comments

Andy Shevchenko June 14, 2022, 1:12 p.m. UTC | #1
On Mon, Jun 13, 2022 at 09:51:28PM +0200, Hans de Goede wrote:
> HMM_BO_SHARE is not supported by the hmm_bo code at all, drop it.

...

> - * of memory: HMM_BO_PRIVATE, HMM_BO_USER, HMM_BO_SHARE.
> + * of memory: HMM_BO_PRIVATE, HMM_BO_USER..

Single period is enough?
  

Patch

diff --git a/drivers/staging/media/atomisp/include/hmm/hmm_bo.h b/drivers/staging/media/atomisp/include/hmm/hmm_bo.h
index dd96b5763dd2..7110a040f50a 100644
--- a/drivers/staging/media/atomisp/include/hmm/hmm_bo.h
+++ b/drivers/staging/media/atomisp/include/hmm/hmm_bo.h
@@ -76,7 +76,6 @@ 
 
 enum hmm_bo_type {
 	HMM_BO_PRIVATE,
-	HMM_BO_SHARE,
 	HMM_BO_USER,
 	HMM_BO_LAST,
 };
diff --git a/drivers/staging/media/atomisp/pci/hmm/hmm_bo.c b/drivers/staging/media/atomisp/pci/hmm/hmm_bo.c
index a6b7f2b6247f..bcd96aa00529 100644
--- a/drivers/staging/media/atomisp/pci/hmm/hmm_bo.c
+++ b/drivers/staging/media/atomisp/pci/hmm/hmm_bo.c
@@ -875,13 +875,10 @@  static int alloc_user_pages(struct hmm_buffer_object *bo,
  * allocate/free physical pages for the bo.
  *
  * type indicate where are the pages from. currently we have 3 types
- * of memory: HMM_BO_PRIVATE, HMM_BO_USER, HMM_BO_SHARE.
+ * of memory: HMM_BO_PRIVATE, HMM_BO_USER..
  *
  * userptr is only valid when type is HMM_BO_USER, it indicates
  * the start address from user space task.
- *
- * from_highmem and userptr will both be ignored when type is
- * HMM_BO_SHARE.
  */
 int hmm_bo_alloc_pages(struct hmm_buffer_object *bo,
 		       enum hmm_bo_type type,