diff mbox series

[3/7] videobuf2-dma-sg.c: kvmalloc_array -> kvcalloc

Message ID	20220509091553.2637089-4-hverkuil-cisco@xs4all.nl (mailing list archive)
State	Accepted
Delegated to:	Hans Verkuil
Headers	From: Hans Verkuil <hverkuil-cisco@xs4all.nl> To: linux-media@vger.kernel.org Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Sakari Ailus <sakari.ailus@iki.fi>, Hans Verkuil <hverkuil-cisco@xs4all.nl> Subject: [PATCH 3/7] videobuf2-dma-sg.c: kvmalloc_array -> kvcalloc Date: Mon, 9 May 2022 11:15:49 +0200 Message-Id: <20220509091553.2637089-4-hverkuil-cisco@xs4all.nl> In-Reply-To: <20220509091553.2637089-1-hverkuil-cisco@xs4all.nl> References: <20220509091553.2637089-1-hverkuil-cisco@xs4all.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Various smatch fixes \| [0/7] Various smatch fixes [1/7] v4l2-subdev.c: kvmalloc_array -> kvcalloc [2/7] v4l2-ctls-core.c: kvmalloc_array -> kvcalloc [3/7] videobuf2-dma-sg.c: kvmalloc_array -> kvcalloc [4/7] cx25821: request_irq -> devm_request_irq [5/7] ccs-core.c: fix failure to call clk_disable_unprepare [6/7] s5k6a3: add missing clk_disable_unprepare [7/7] uvc_v4l2.c: avoid using iterator used outside loop

Commit Message

Hans Verkuil May 9, 2022, 9:15 a.m. UTC

  Fixes smatch warning:

drivers/media/common/videobuf2/videobuf2-dma-sg.c:129 vb2_dma_sg_alloc() warn: Please consider using kvcalloc instead

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
 drivers/media/common/videobuf2/videobuf2-dma-sg.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Laurent Pinchart May 9, 2022, 10:29 a.m. UTC | #1

Hi Hans,

Thank you for the patch.

On Mon, May 09, 2022 at 11:15:49AM +0200, Hans Verkuil wrote:
> Fixes smatch warning:
> 
> drivers/media/common/videobuf2/videobuf2-dma-sg.c:129 vb2_dma_sg_alloc() warn: Please consider using kvcalloc instead
> 
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/common/videobuf2/videobuf2-dma-sg.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/common/videobuf2/videobuf2-dma-sg.c b/drivers/media/common/videobuf2/videobuf2-dma-sg.c
> index f8a21c560ad2..fa69158a65b1 100644
> --- a/drivers/media/common/videobuf2/videobuf2-dma-sg.c
> +++ b/drivers/media/common/videobuf2/videobuf2-dma-sg.c
> @@ -126,8 +126,7 @@ static void *vb2_dma_sg_alloc(struct vb2_buffer *vb, struct device *dev,
>  	 * there is no memory consistency guarantee, hence dma-sg ignores DMA
>  	 * attributes passed from the upper layer.
>  	 */
> -	buf->pages = kvmalloc_array(buf->num_pages, sizeof(struct page *),
> -				    GFP_KERNEL | __GFP_ZERO);
> +	buf->pages = kvcalloc(buf->num_pages, sizeof(struct page *), GFP_KERNEL);
>  	if (!buf->pages)
>  		goto fail_pages_array_alloc;
>

diff mbox series

Patch

diff --git a/drivers/media/common/videobuf2/videobuf2-dma-sg.c b/drivers/media/common/videobuf2/videobuf2-dma-sg.c
index f8a21c560ad2..fa69158a65b1 100644
--- a/drivers/media/common/videobuf2/videobuf2-dma-sg.c
+++ b/drivers/media/common/videobuf2/videobuf2-dma-sg.c
@@ -126,8 +126,7 @@  static void *vb2_dma_sg_alloc(struct vb2_buffer *vb, struct device *dev,
 	 * there is no memory consistency guarantee, hence dma-sg ignores DMA
 	 * attributes passed from the upper layer.
 	 */
-	buf->pages = kvmalloc_array(buf->num_pages, sizeof(struct page *),
-				    GFP_KERNEL | __GFP_ZERO);
+	buf->pages = kvcalloc(buf->num_pages, sizeof(struct page *), GFP_KERNEL);
 	if (!buf->pages)
 		goto fail_pages_array_alloc;