diff mbox series

[3/3] media: vsp1: Use vb2_queue_is_busy()

Message ID 20220318211446.11543-4-laurent.pinchart+renesas@ideasonboard.com (mailing list archive)
State Accepted
Headers
Series media: videobuf2: Expose vb2_queue_is_busy() to drivers |

Commit Message

Laurent Pinchart March 18, 2022, 9:14 p.m. UTC 
  Use the new vb2_queue_is_busy() helper to replace the open-coded
version.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/media/platform/renesas/vsp1/vsp1_video.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kieran Bingham March 18, 2022, 9:40 p.m. UTC | #1 
Quoting Laurent Pinchart (2022-03-18 21:14:46)
> Use the new vb2_queue_is_busy() helper to replace the open-coded
> version.
> 

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  drivers/media/platform/renesas/vsp1/vsp1_video.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_video.c b/drivers/media/platform/renesas/vsp1/vsp1_video.c
> index 8f53abc71db2..4da70b2b0869 100644
> --- a/drivers/media/platform/renesas/vsp1/vsp1_video.c
> +++ b/drivers/media/platform/renesas/vsp1/vsp1_video.c
> @@ -1032,7 +1032,7 @@ vsp1_video_streamon(struct file *file, void *fh, enum v4l2_buf_type type)
>         struct vsp1_pipeline *pipe;
>         int ret;
>  
> -       if (video->queue.owner && video->queue.owner != file->private_data)
> +       if (vb2_queue_is_busy(&video->queue, file))
>                 return -EBUSY;
>  
>         /*
> -- 
> Regards,
> 
> Laurent Pinchart
>
Tomasz Figa July 6, 2022, 5:34 a.m. UTC | #2 
Hi Laurent,

On Fri, Mar 18, 2022 at 11:14:46PM +0200, Laurent Pinchart wrote:
> Use the new vb2_queue_is_busy() helper to replace the open-coded
> version.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  drivers/media/platform/renesas/vsp1/vsp1_video.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_video.c b/drivers/media/platform/renesas/vsp1/vsp1_video.c
> index 8f53abc71db2..4da70b2b0869 100644
> --- a/drivers/media/platform/renesas/vsp1/vsp1_video.c
> +++ b/drivers/media/platform/renesas/vsp1/vsp1_video.c
> @@ -1032,7 +1032,7 @@ vsp1_video_streamon(struct file *file, void *fh, enum v4l2_buf_type type)
>  	struct vsp1_pipeline *pipe;
>  	int ret;
>  
> -	if (video->queue.owner && video->queue.owner != file->private_data)
> +	if (vb2_queue_is_busy(&video->queue, file))
>  		return -EBUSY;
>  
>  	/*

Thanks for the patch and really sorry for the long delay. Finally
catching up with my backlog.

An alternative would be to have all the stream start code placed under
the vb2 start_streaming callback, symmetrically to
what the driver already does with streamoff/stop_streaming. That would
eliminate the need to export the symbol from the vb2 framework.

Have you considered that option?

Best regards,
Tomasz
diff mbox series

Patch

diff --git a/drivers/media/platform/renesas/vsp1/vsp1_video.c b/drivers/media/platform/renesas/vsp1/vsp1_video.c
index 8f53abc71db2..4da70b2b0869 100644
--- a/drivers/media/platform/renesas/vsp1/vsp1_video.c
+++ b/drivers/media/platform/renesas/vsp1/vsp1_video.c
@@ -1032,7 +1032,7 @@  vsp1_video_streamon(struct file *file, void *fh, enum v4l2_buf_type type)
 	struct vsp1_pipeline *pipe;
 	int ret;
 
-	if (video->queue.owner && video->queue.owner != file->private_data)
+	if (vb2_queue_is_busy(&video->queue, file))
 		return -EBUSY;
 
 	/*