Message ID | 20211129120659.1815-3-christian.koenig@amd.com (mailing list archive) |
---|---|
State | Not Applicable, archived |
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1mrgfA-00GR75-8w; Mon, 29 Nov 2021 13:25:44 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377692AbhK2N27 (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 29 Nov 2021 08:28:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377814AbhK2N06 (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 29 Nov 2021 08:26:58 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DB4DC02B677 for <linux-media@vger.kernel.org>; Mon, 29 Nov 2021 04:07:06 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id o29so14380826wms.2 for <linux-media@vger.kernel.org>; Mon, 29 Nov 2021 04:07:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OOCzCCGRhx0Yd+XBoLOb3ENe6v2ley+rjFyWG7N2LJU=; b=Q6X8MelaozaQwJKcGk9PhwHDUcDD0804yBPKlQUpU1WahVImfNpIKG/OejgeytkrVR A3wNCR3VBtNfSkPSL8va2GAnQvspMA6Veaw52bQrGuFdVnEJxM3Mg//xlVyVog2LNH6N u3PuAcHbhNX4JVUslAoJDcdMWtA7GeefmOIWvi0al+OncC5jRO0s2lR331gCBS2BpUaO 7QA/1eafmE1MIbH5CacqhElctbQZD4c+EoiPi/xvpWyC8rGSlA5xIaFqjlNz5k7BoY7L SNDc+sadmIsANRckOh362ojch30ULQgLgSzba+Pmp3jkOdz90y6AOUNnKBRFSa51v0ZC ksVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OOCzCCGRhx0Yd+XBoLOb3ENe6v2ley+rjFyWG7N2LJU=; b=TWOtXf9QLISYxpnS+GnUPmco572Hvs4/YYHTmYQ3KBbk/LC1yX/TXLGNk2MWjXos0c P9AGmDkYXgf26C0aV/mw2I6KUpRfe4OLk+0v3MJ2ze+a8wfljsVx7dOJg5nXsYMUYjK4 dO3x0Yg4Rr+fdOjQNX2jtuzgsuw2TBO7SrM/brFQ7OJD+oH3D1skOrfkNbqtujiKLkId SxAtrRsOmZxiz6AqmSU32LmKfDuJJRt0Yl6Xrxd07xpucw+x6kUbTuJ1PpdQOhU26oFL vO7qtesYWDduad1WbtucFT0v6EiZDIERWdv1f9cKJJ1goXLuS6A1x0aEM3vi0JcqfS5C f8nQ== X-Gm-Message-State: AOAM531MP02HMbJabOGQHVgOo1aAlkSz/XHXtT+bqzGTx8ao9iFkahHD BGTi0P38ILYZa8iCg80KeJI= X-Google-Smtp-Source: ABdhPJwP9DcyaVQ4UYDvEecjYzTaOmhgzoezNR1SawExuKjdgJBNc8PjMSFTpKkeIGvBtMZEVrk4eQ== X-Received: by 2002:a05:600c:3494:: with SMTP id a20mr36318388wmq.195.1638187624754; Mon, 29 Nov 2021 04:07:04 -0800 (PST) Received: from abel.fritz.box (p57b0b77b.dip0.t-ipconnect.de. [87.176.183.123]) by smtp.gmail.com with ESMTPSA id b6sm20415234wmq.45.2021.11.29.04.07.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 04:07:04 -0800 (PST) From: " =?utf-8?q?Christian_K=C3=B6nig?= " <ckoenig.leichtzumerken@gmail.com> X-Google-Original-From: =?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com> To: daniel@ffwll.ch Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH 02/28] drm/ttm: stop pruning fences after wait Date: Mon, 29 Nov 2021 13:06:33 +0100 Message-Id: <20211129120659.1815-3-christian.koenig@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211129120659.1815-1-christian.koenig@amd.com> References: <20211129120659.1815-1-christian.koenig@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no |
Series |
[01/28] drm/i915: Remove dma_resv_prune
|
|
Commit Message
Christian König
Nov. 29, 2021, 12:06 p.m. UTC
This is just abusing internals of the dma_resv object.
Signed-off-by: Christian König <christian.koenig@amd.com>
---
drivers/gpu/drm/ttm/ttm_bo.c | 1 -
1 file changed, 1 deletion(-)
Comments
On Mon, Nov 29, 2021 at 01:06:33PM +0100, Christian König wrote: > This is just abusing internals of the dma_resv object. > > Signed-off-by: Christian König <christian.koenig@amd.com> Yeah I think if we want this back we could do a _locked version of the wait, which prunes internally. Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Btw I wonder, should we put the ttm_bo_wait wrapper on the chopping block in gpu/todo.rst? It's really just complications I think in most cases. And it would be nice if ttm has the same errno semantics for these as everyone else, I always get very confused about this stuff ... Cheers, Daniel > --- > drivers/gpu/drm/ttm/ttm_bo.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c > index e4a20a3a5d16..fc124457ba2f 100644 > --- a/drivers/gpu/drm/ttm/ttm_bo.c > +++ b/drivers/gpu/drm/ttm/ttm_bo.c > @@ -1086,7 +1086,6 @@ int ttm_bo_wait(struct ttm_buffer_object *bo, > if (timeout == 0) > return -EBUSY; > > - dma_resv_add_excl_fence(bo->base.resv, NULL); > return 0; > } > EXPORT_SYMBOL(ttm_bo_wait); > -- > 2.25.1 >
Am 30.11.21 um 10:02 schrieb Daniel Vetter: > On Mon, Nov 29, 2021 at 01:06:33PM +0100, Christian König wrote: >> This is just abusing internals of the dma_resv object. >> >> Signed-off-by: Christian König <christian.koenig@amd.com> > Yeah I think if we want this back we could do a _locked version of the > wait, which prunes internally. > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > Btw I wonder, should we put the ttm_bo_wait wrapper on the chopping block > in gpu/todo.rst? It's really just complications I think in most cases. And > it would be nice if ttm has the same errno semantics for these as everyone > else, I always get very confused about this stuff ... I've already done that quite a bit, e.g. removed most of the users. What's left are the cases where we wait or test signaling inside of TTM and I think I can get rid of that with the LRU rework. So yeah, already in the pipeline. Regards, Christian. > > Cheers, Daniel > >> --- >> drivers/gpu/drm/ttm/ttm_bo.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c >> index e4a20a3a5d16..fc124457ba2f 100644 >> --- a/drivers/gpu/drm/ttm/ttm_bo.c >> +++ b/drivers/gpu/drm/ttm/ttm_bo.c >> @@ -1086,7 +1086,6 @@ int ttm_bo_wait(struct ttm_buffer_object *bo, >> if (timeout == 0) >> return -EBUSY; >> >> - dma_resv_add_excl_fence(bo->base.resv, NULL); >> return 0; >> } >> EXPORT_SYMBOL(ttm_bo_wait); >> -- >> 2.25.1 >>
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index e4a20a3a5d16..fc124457ba2f 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -1086,7 +1086,6 @@ int ttm_bo_wait(struct ttm_buffer_object *bo, if (timeout == 0) return -EBUSY; - dma_resv_add_excl_fence(bo->base.resv, NULL); return 0; } EXPORT_SYMBOL(ttm_bo_wait);