| Message ID | 20211101132502.700505-1-sakari.ailus@linux.intel.com (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Delegated to: | Sakari Ailus |
| Headers |
Received: from vger.kernel.org ([23.128.96.18])
by www.linuxtv.org with esmtp (Exim 4.92)
(envelope-from <linux-media-owner@vger.kernel.org>)
id 1mhXRu-00AoIV-Sm; Mon, 01 Nov 2021 13:34:07 +0000
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231847AbhKANgh (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other);
Mon, 1 Nov 2021 09:36:37 -0400
Received: from retiisi.eu ([95.216.213.190]:34054 "EHLO
hillosipuli.retiisi.eu"
rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
id S231741AbhKANgh (ORCPT <rfc822;linux-media@vger.kernel.org>);
Mon, 1 Nov 2021 09:36:37 -0400
X-Greylist: delayed 518 seconds by postgrey-1.27 at vger.kernel.org;
Mon, 01 Nov 2021 09:36:36 EDT
Received: from lanttu.localdomain (unknown [192.168.2.193])
by hillosipuli.retiisi.eu (Postfix) with ESMTP id 11197634C90;
Mon, 1 Nov 2021 15:25:18 +0200 (EET)
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: =?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund+renesas@ragnatech.se>
Subject: [PATCH 1/1] max96712: Select VIDEO_V4L2
Date: Mon, 1 Nov 2021 15:25:02 +0200
Message-Id: <20211101132502.700505-1-sakari.ailus@linux.intel.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk
List-ID: <linux-media.vger.kernel.org>
X-Mailing-List: linux-media@vger.kernel.org
X-LSpam-Score: -2.4 (--)
X-LSpam-Report: No,
score=-2.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_NONE=-0.0001
autolearn=ham autolearn_force=no
|
| Series |
[1/1] max96712: Select VIDEO_V4L2
|
|
Commit Message
Sakari Ailus
Nov. 1, 2021, 1:25 p.m. UTC
Select VIDEO_V4L2 for the driver actually depends on it, failing to
compile otherwise.
Fixes: 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/staging/media/max96712/Kconfig | 1 +
1 file changed, 1 insertion(+)
Comments
Hi Sakari, Thanks for your patch. On 2021-11-01 15:25:02 +0200, Sakari Ailus wrote: > Select VIDEO_V4L2 for the driver actually depends on it, failing to > compile otherwise. > > Fixes: 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/staging/media/max96712/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/media/max96712/Kconfig b/drivers/staging/media/max96712/Kconfig > index 258d47644cbd..492a7ff70dd8 100644 > --- a/drivers/staging/media/max96712/Kconfig > +++ b/drivers/staging/media/max96712/Kconfig > @@ -6,6 +6,7 @@ config VIDEO_MAX96712 > select V4L2_FWNODE > select VIDEO_V4L2_SUBDEV_API > select MEDIA_CONTROLLER > + select VIDEO_V4L2 > help > This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer. > > -- > 2.30.2 >
Hi Sakari, Quoting Sakari Ailus (2021-11-01 13:25:02) > Select VIDEO_V4L2 for the driver actually depends on it, failing to > compile otherwise. > > Fixes: 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer") I guess this is a local commit in your tree so far, I can't identify it. > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > drivers/staging/media/max96712/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/media/max96712/Kconfig b/drivers/staging/media/max96712/Kconfig > index 258d47644cbd..492a7ff70dd8 100644 > --- a/drivers/staging/media/max96712/Kconfig > +++ b/drivers/staging/media/max96712/Kconfig > @@ -6,6 +6,7 @@ config VIDEO_MAX96712 > select V4L2_FWNODE > select VIDEO_V4L2_SUBDEV_API > select MEDIA_CONTROLLER > + select VIDEO_V4L2 I don't see any other driver 'select' VIDEO_V4L2... Most 'depend' on VIDEO_V4L2 instead. And curiously, I already see - Add 'depends on VIDEO_V4L2' in Niklas' v4. Is this one a special case that 'needs' to select it? -- Kieran > help > This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer. > > -- > 2.30.2 >
Hi Kieran, On 2021-11-01 16:30:09 +0000, Kieran Bingham wrote: > Hi Sakari, > > Quoting Sakari Ailus (2021-11-01 13:25:02) > > Select VIDEO_V4L2 for the driver actually depends on it, failing to > > compile otherwise. > > > > Fixes: 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer") > > I guess this is a local commit in your tree so far, I can't identify it. > > > Reported-by: kernel test robot <lkp@intel.com> > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > --- > > drivers/staging/media/max96712/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/media/max96712/Kconfig b/drivers/staging/media/max96712/Kconfig > > index 258d47644cbd..492a7ff70dd8 100644 > > --- a/drivers/staging/media/max96712/Kconfig > > +++ b/drivers/staging/media/max96712/Kconfig > > @@ -6,6 +6,7 @@ config VIDEO_MAX96712 > > select V4L2_FWNODE > > select VIDEO_V4L2_SUBDEV_API > > select MEDIA_CONTROLLER > > + select VIDEO_V4L2 > > I don't see any other driver 'select' VIDEO_V4L2... > Most 'depend' on VIDEO_V4L2 instead. > > And curiously, I already see > - Add 'depends on VIDEO_V4L2' > > in Niklas' v4. I noticed too late that v3 was already in the media staging tree so I submitted a v4 with this fix. I should probably have submitted a Fixes patch like this one instead of a v4 if I knew it was already picked-up. > > Is this one a special case that 'needs' to select it? Both 'select' and 'depends on' solves the problem reported by the bot, which one is more correct I do not know. > -- > Kieran > > > > > help > > This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer. > > > > -- > > 2.30.2 > >
Quoting Niklas Söderlund (2021-11-01 16:55:02) > Hi Kieran, > > On 2021-11-01 16:30:09 +0000, Kieran Bingham wrote: > > Hi Sakari, > > > > Quoting Sakari Ailus (2021-11-01 13:25:02) > > > Select VIDEO_V4L2 for the driver actually depends on it, failing to > > > compile otherwise. > > > > > > Fixes: 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer") > > > > I guess this is a local commit in your tree so far, I can't identify it. > > > > > Reported-by: kernel test robot <lkp@intel.com> > > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > > --- > > > drivers/staging/media/max96712/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/staging/media/max96712/Kconfig b/drivers/staging/media/max96712/Kconfig > > > index 258d47644cbd..492a7ff70dd8 100644 > > > --- a/drivers/staging/media/max96712/Kconfig > > > +++ b/drivers/staging/media/max96712/Kconfig > > > @@ -6,6 +6,7 @@ config VIDEO_MAX96712 > > > select V4L2_FWNODE > > > select VIDEO_V4L2_SUBDEV_API > > > select MEDIA_CONTROLLER > > > + select VIDEO_V4L2 > > > > I don't see any other driver 'select' VIDEO_V4L2... > > Most 'depend' on VIDEO_V4L2 instead. > > > > And curiously, I already see > > - Add 'depends on VIDEO_V4L2' > > > > in Niklas' v4. > > I noticed too late that v3 was already in the media staging tree so I > submitted a v4 with this fix. I should probably have submitted a Fixes > patch like this one instead of a v4 if I knew it was already picked-up. > > > > > Is this one a special case that 'needs' to select it? > > Both 'select' and 'depends on' solves the problem reported by the bot, > which one is more correct I do not know. Aha, I see. Well - consistency would tell me that 'depends on' would match almost every other driver. I notice that the MAX9286 suffers the same problem. I'll send a patch. -- Kieran > > -- > > Kieran > > > > > > > > > help > > > This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer. > > > > > > -- > > > 2.30.2 > > > > > -- > Regards, > Niklas Söderlund
Hi Sakari, I noticed this patch is marked as Rejected in patchwork, but it's still needed. Will you resurrect this patch? On 2021-11-01 15:25:02 +0200, Sakari Ailus wrote: > Select VIDEO_V4L2 for the driver actually depends on it, failing to > compile otherwise. > > Fixes: 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > drivers/staging/media/max96712/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/media/max96712/Kconfig b/drivers/staging/media/max96712/Kconfig > index 258d47644cbd..492a7ff70dd8 100644 > --- a/drivers/staging/media/max96712/Kconfig > +++ b/drivers/staging/media/max96712/Kconfig > @@ -6,6 +6,7 @@ config VIDEO_MAX96712 > select V4L2_FWNODE > select VIDEO_V4L2_SUBDEV_API > select MEDIA_CONTROLLER > + select VIDEO_V4L2 > help > This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer. > > -- > 2.30.2 >
Hi Niklas, On Thu, Nov 25, 2021 at 09:34:26AM +0100, Niklas Söderlund wrote: > Hi Sakari, > > I noticed this patch is marked as Rejected in patchwork, but it's still > needed. Will you resurrect this patch? Good point. I noticed Kieran submitted something alike but it seems to have been for a different driver. I'll send one that uses depends instead.
diff --git a/drivers/staging/media/max96712/Kconfig b/drivers/staging/media/max96712/Kconfig index 258d47644cbd..492a7ff70dd8 100644 --- a/drivers/staging/media/max96712/Kconfig +++ b/drivers/staging/media/max96712/Kconfig @@ -6,6 +6,7 @@ config VIDEO_MAX96712 select V4L2_FWNODE select VIDEO_V4L2_SUBDEV_API select MEDIA_CONTROLLER + select VIDEO_V4L2 help This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer.