diff mbox series

[-next] media: ti-vpe: csc: remove redundant dev_err call in csc_create()

Message ID 20210401102850.1555368-1-yangyingliang@huawei.com (mailing list archive)
State Accepted, archived
Delegated to: Hans Verkuil
Headers
Series [-next] media: ti-vpe: csc: remove redundant dev_err call in csc_create() |

Commit Message

Yang Yingliang April 1, 2021, 10:28 a.m. UTC 
  There is an error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/media/platform/ti-vpe/csc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Benoit Parrot April 1, 2021, 2 p.m. UTC | #1 
Yang,

Thank you for the patch.

Yang Yingliang <yangyingliang@huawei.com> wrote on Thu [2021-Apr-01 18:28:50 +0800]:
> There is an error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/media/platform/ti-vpe/csc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/ti-vpe/csc.c b/drivers/media/platform/ti-vpe/csc.c
> index f4e0cf72d1cf..ff15bc589f1b 100644
> --- a/drivers/media/platform/ti-vpe/csc.c
> +++ b/drivers/media/platform/ti-vpe/csc.c
> @@ -267,10 +267,8 @@ struct csc_data *csc_create(struct platform_device *pdev, const char *res_name)
>  	}
>  
>  	csc->base = devm_ioremap_resource(&pdev->dev, csc->res);
> -	if (IS_ERR(csc->base)) {
> -		dev_err(&pdev->dev, "failed to ioremap\n");
> +	if (IS_ERR(csc->base))
>  		return ERR_CAST(csc->base);
> -	}

Reviewed-by: Benoit Parrot <bparrot@ti.com>

>  
>  	return csc;
>  }
> -- 
> 2.25.1
>
diff mbox series

Patch

diff --git a/drivers/media/platform/ti-vpe/csc.c b/drivers/media/platform/ti-vpe/csc.c
index f4e0cf72d1cf..ff15bc589f1b 100644
--- a/drivers/media/platform/ti-vpe/csc.c
+++ b/drivers/media/platform/ti-vpe/csc.c
@@ -267,10 +267,8 @@  struct csc_data *csc_create(struct platform_device *pdev, const char *res_name)
 	}
 
 	csc->base = devm_ioremap_resource(&pdev->dev, csc->res);
-	if (IS_ERR(csc->base)) {
-		dev_err(&pdev->dev, "failed to ioremap\n");
+	if (IS_ERR(csc->base))
 		return ERR_CAST(csc->base);
-	}
 
 	return csc;
 }