diff mbox series

media: rkvdec: Remove of_match_ptr()

Message ID 20210320122152.203446-1-festevam@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Hans Verkuil
Headers
Series media: rkvdec: Remove of_match_ptr() |

Commit Message

Fabio Estevam March 20, 2021, 12:21 p.m. UTC 
  When building with CONFIG_OF not set, the following clang
build warning is seen:

>> drivers/staging/media/rkvdec/rkvdec.c:967:34: warning: unused variable 'of_rkvdec_match' [-Wunused-const-variable]

Fix the warning by removing the unnecessary of_match_ptr().

Reported-by: kernel test robot <lkp@intel.com>
Fixes: cd33c830448b ("media: rkvdec: Add the rkvdec driver")
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 drivers/staging/media/rkvdec/rkvdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ezequiel Garcia March 20, 2021, 4:58 p.m. UTC | #1 
On Sat, 2021-03-20 at 09:21 -0300, Fabio Estevam wrote:
> When building with CONFIG_OF not set, the following clang
> build warning is seen:
> 
> > > drivers/staging/media/rkvdec/rkvdec.c:967:34: warning: unused variable 'of_rkvdec_match' [-Wunused-const-variable]
> 
> Fix the warning by removing the unnecessary of_match_ptr().
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: cd33c830448b ("media: rkvdec: Add the rkvdec driver")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  drivers/staging/media/rkvdec/rkvdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c
> index 225eeca73356..0ff013c1fc38 100644
> --- a/drivers/staging/media/rkvdec/rkvdec.c
> +++ b/drivers/staging/media/rkvdec/rkvdec.c
> @@ -1092,7 +1092,7 @@ static struct platform_driver rkvdec_driver = {
>         .remove = rkvdec_remove,
>         .driver = {
>                    .name = "rkvdec",
> -                  .of_match_table = of_match_ptr(of_rkvdec_match),
> +                  .of_match_table = of_rkvdec_match,
>                    .pm = &rkvdec_pm_ops,
>         },
>  };

Looks good.

Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>

Thanks,
Ezequiel
diff mbox series

Patch

diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c
index 225eeca73356..0ff013c1fc38 100644
--- a/drivers/staging/media/rkvdec/rkvdec.c
+++ b/drivers/staging/media/rkvdec/rkvdec.c
@@ -1092,7 +1092,7 @@  static struct platform_driver rkvdec_driver = {
 	.remove = rkvdec_remove,
 	.driver = {
 		   .name = "rkvdec",
-		   .of_match_table = of_match_ptr(of_rkvdec_match),
+		   .of_match_table = of_rkvdec_match,
 		   .pm = &rkvdec_pm_ops,
 	},
 };