diff mbox series

[v6,1/4] media: rockchip: rkisp1: fix comment about number of histogram sub-windows

Message ID 20210118110448.275389-2-heiko@sntech.de (mailing list archive)
State Superseded, archived
Delegated to: Hans Verkuil
Headers
Series Fix the rkisp1 userspace API for later IP versions |

Commit Message

Heiko Stuebner Jan. 18, 2021, 11:04 a.m. UTC 
  From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>

The histogram data is divided into 16 sub-windows, not 25.
See RKISP1_CIF_ISP_HIST_BIN_N_MAX being defined as 16 for reference
and this also matches the datasheet.

Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
---
 include/uapi/linux/rkisp1-config.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Helen Koike Jan. 18, 2021, 6:03 p.m. UTC | #1 
On 1/18/21 8:04 AM, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> 
> The histogram data is divided into 16 sub-windows, not 25.
> See RKISP1_CIF_ISP_HIST_BIN_N_MAX being defined as 16 for reference
> and this also matches the datasheet.
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>

Acked-by: Helen Koike <helen.koike@collabora.com>

> ---
>  include/uapi/linux/rkisp1-config.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/rkisp1-config.h b/include/uapi/linux/rkisp1-config.h
> index 6e449e784260..ba443771cc0b 100644
> --- a/include/uapi/linux/rkisp1-config.h
> +++ b/include/uapi/linux/rkisp1-config.h
> @@ -846,7 +846,7 @@ struct rkisp1_cif_isp_af_stat {
>   *
>   * @hist_bins: measured bin counters
>   *
> - * Measurement window divided into 25 sub-windows, set
> + * Measurement window divided into 16 sub-windows, set
>   * with ISP_HIST_XXX
>   */
>  struct rkisp1_cif_isp_hist_stat {
>
diff mbox series

Patch

diff --git a/include/uapi/linux/rkisp1-config.h b/include/uapi/linux/rkisp1-config.h
index 6e449e784260..ba443771cc0b 100644
--- a/include/uapi/linux/rkisp1-config.h
+++ b/include/uapi/linux/rkisp1-config.h
@@ -846,7 +846,7 @@  struct rkisp1_cif_isp_af_stat {
  *
  * @hist_bins: measured bin counters
  *
- * Measurement window divided into 25 sub-windows, set
+ * Measurement window divided into 16 sub-windows, set
  * with ISP_HIST_XXX
  */
 struct rkisp1_cif_isp_hist_stat {