[v1] media: ipu3-cio2: Add headers that ipu3-cio2.h is direct user of

Message ID 20201230204405.62892-1-andriy.shevchenko@linux.intel.com (mailing list archive)
State Accepted, archived
Headers
Series [v1] media: ipu3-cio2: Add headers that ipu3-cio2.h is direct user of |

Commit Message

Andy Shevchenko Dec. 30, 2020, 8:44 p.m. UTC
  Add headers that ipu3-cio2.h is direct user of.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---

Dan, feel free to incorporate this into your series.

 drivers/media/pci/intel/ipu3/ipu3-cio2.h | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
  

Comments

Daniel Scally Jan. 3, 2021, 12:11 a.m. UTC | #1
Hi Andy

On 30/12/2020 20:44, Andy Shevchenko wrote:
> Add headers that ipu3-cio2.h is direct user of.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

For what it's worth:


Reviewed-by: Daniel Scally <djrscally@gmail.com>

Tested-by: Daniel Scally <djrscally@gmail.com>

> ---
>
> Dan, feel free to incorporate this into your series.
Thanks! I'll add it at the beginning so I can include this header in
cio2-bridge.h, with my tags added too I guess
>
>  drivers/media/pci/intel/ipu3/ipu3-cio2.h | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> index ccf0b85ae36f..62187ab5ae43 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> @@ -4,8 +4,26 @@
>  #ifndef __IPU3_CIO2_H
>  #define __IPU3_CIO2_H
>  
> +#include <linux/bits.h>
> +#include <linux/dma-mapping.h>
> +#include <linux/kernel.h>
> +#include <linux/mutex.h>
>  #include <linux/types.h>
>  
> +#include <asm/page.h>
> +
> +#include <media/media-device.h>
> +#include <media/media-entity.h>
> +#include <media/v4l2-async.h>
> +#include <media/v4l2-dev.h>
> +#include <media/v4l2-device.h>
> +#include <media/v4l2-subdev.h>
> +#include <media/videobuf2-core.h>
> +#include <media/videobuf2-v4l2.h>
> +
> +struct cio2_fbpt_entry;		/* defined here, after the first usage */
> +struct pci_dev;
> +
>  #define CIO2_NAME					"ipu3-cio2"
>  #define CIO2_DEVICE_NAME				"Intel IPU3 CIO2"
>  #define CIO2_ENTITY_NAME				"ipu3-csi2"
  
Andy Shevchenko Jan. 3, 2021, 2:45 p.m. UTC | #2
On Sun, Jan 3, 2021 at 2:19 AM Daniel Scally <djrscally@gmail.com> wrote:
> On 30/12/2020 20:44, Andy Shevchenko wrote:
> > Add headers that ipu3-cio2.h is direct user of.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> For what it's worth:
>
>
> Reviewed-by: Daniel Scally <djrscally@gmail.com>
>
> Tested-by: Daniel Scally <djrscally@gmail.com>

Thanks!


> > Dan, feel free to incorporate this into your series.
> Thanks! I'll add it at the beginning so I can include this header in
> cio2-bridge.h, with my tags added too I guess

Right, please go ahead!
  

Patch

diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
index ccf0b85ae36f..62187ab5ae43 100644
--- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h
+++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
@@ -4,8 +4,26 @@ 
 #ifndef __IPU3_CIO2_H
 #define __IPU3_CIO2_H
 
+#include <linux/bits.h>
+#include <linux/dma-mapping.h>
+#include <linux/kernel.h>
+#include <linux/mutex.h>
 #include <linux/types.h>
 
+#include <asm/page.h>
+
+#include <media/media-device.h>
+#include <media/media-entity.h>
+#include <media/v4l2-async.h>
+#include <media/v4l2-dev.h>
+#include <media/v4l2-device.h>
+#include <media/v4l2-subdev.h>
+#include <media/videobuf2-core.h>
+#include <media/videobuf2-v4l2.h>
+
+struct cio2_fbpt_entry;		/* defined here, after the first usage */
+struct pci_dev;
+
 #define CIO2_NAME					"ipu3-cio2"
 #define CIO2_DEVICE_NAME				"Intel IPU3 CIO2"
 #define CIO2_ENTITY_NAME				"ipu3-csi2"