[01/11] drivers: staging: speakup: remove unneeded MODULE_VERSION() call
Commit Message
Remove MODULE_VERSION(), as it doesn't seem to serve any practical
purpose. For in-tree drivers, the kernel version matters.
The drivers have received lots of changes, without the module version
(or the underlying DRV_VERSION macro) ever changed, since the code
landed in the kernel tree. So, it doesn't seem to have any practical
meaning anymore.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/accessibility/speakup/main.c | 1 -
drivers/accessibility/speakup/speakup_acntpc.c | 1 -
drivers/accessibility/speakup/speakup_acntsa.c | 1 -
drivers/accessibility/speakup/speakup_apollo.c | 2 --
drivers/accessibility/speakup/speakup_audptr.c | 2 --
drivers/accessibility/speakup/speakup_bns.c | 2 --
drivers/accessibility/speakup/speakup_decext.c | 1 -
drivers/accessibility/speakup/speakup_decpc.c | 1 -
drivers/accessibility/speakup/speakup_dectlk.c | 1 -
drivers/accessibility/speakup/speakup_dtlk.c | 2 --
drivers/accessibility/speakup/speakup_dummy.c | 2 --
drivers/accessibility/speakup/speakup_keypc.c | 1 -
drivers/accessibility/speakup/speakup_ltlk.c | 2 --
drivers/accessibility/speakup/speakup_soft.c | 1 -
drivers/accessibility/speakup/speakup_spkout.c | 2 --
drivers/accessibility/speakup/speakup_txprt.c | 2 --
16 files changed, 24 deletions(-)
Comments
On Thu, Dec 03, 2020 at 01:47:53PM +0100, Enrico Weigelt, metux IT consult wrote:
> Remove MODULE_VERSION(), as it doesn't seem to serve any practical
> purpose. For in-tree drivers, the kernel version matters.
>
> The drivers have received lots of changes, without the module version
> (or the underlying DRV_VERSION macro) ever changed, since the code
> landed in the kernel tree. So, it doesn't seem to have any practical
> meaning anymore.
>
> Signed-off-by: Enrico Weigelt <info@metux.net>
> ---
> drivers/accessibility/speakup/main.c | 1 -
<snip>
Yous subject line is odd, these are not "staging" drivers anymore, so
why do you say they are there?
thanks,
greg k-h
On Thu, Dec 03, 2020 at 02:25:15PM +0100, Greg KH wrote:
> On Thu, Dec 03, 2020 at 01:47:53PM +0100, Enrico Weigelt, metux IT consult wrote:
> > Remove MODULE_VERSION(), as it doesn't seem to serve any practical
> > purpose. For in-tree drivers, the kernel version matters.
> >
> > The drivers have received lots of changes, without the module version
> > (or the underlying DRV_VERSION macro) ever changed, since the code
> > landed in the kernel tree. So, it doesn't seem to have any practical
> > meaning anymore.
> >
> > Signed-off-by: Enrico Weigelt <info@metux.net>
> > ---
> > drivers/accessibility/speakup/main.c | 1 -
>
> <snip>
>
> Yous subject line is odd, these are not "staging" drivers anymore, so
> why do you say they are there?
Also putting "drivers:" in the subject always seems superfluous.
regards,
dan carpenter
@@ -46,7 +46,6 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("Daniel Drake <dsd@gentoo.org>");
MODULE_DESCRIPTION("Speakup console speech");
MODULE_LICENSE("GPL");
-MODULE_VERSION(SPEAKUP_VERSION);
char *synth_name;
module_param_named(synth, synth_name, charp, 0444);
@@ -315,5 +315,4 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for Accent PC synthesizer");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
@@ -140,5 +140,4 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for Accent SA synthesizer");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
@@ -204,5 +204,3 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for Apollo II synthesizer");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
@@ -167,5 +167,3 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for Audapter synthesizer");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
@@ -124,5 +124,3 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for Braille 'n Speak synthesizers");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
@@ -236,5 +236,4 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for DECtalk External synthesizers");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
@@ -492,4 +492,3 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for DECtalk PC synthesizers");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
@@ -307,5 +307,4 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for DECtalk Express synthesizers");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
@@ -386,5 +386,3 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for DoubleTalk PC synthesizers");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
@@ -130,5 +130,3 @@ module_spk_synth(synth_dummy);
MODULE_AUTHOR("Samuel Thibault <samuel.thibault@ens-lyon.org>");
MODULE_DESCRIPTION("Speakup support for text console");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
@@ -314,5 +314,4 @@ module_spk_synth(synth_keypc);
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for Keynote Gold PC synthesizers");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
@@ -171,5 +171,3 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for DoubleTalk LT/LiteTalk synthesizers");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
@@ -427,4 +427,3 @@ module_spk_synth(synth_soft);
MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_DESCRIPTION("Speakup userspace software synthesizer support");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
@@ -135,5 +135,3 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for Speak Out synthesizers");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
@@ -123,5 +123,3 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for Transport synthesizers");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-