diff mbox series

media: firewire: fix memory leak

Message ID 20200920090137.GA4628@amd (mailing list archive)
State Accepted, archived
Delegated to: Hans Verkuil
Headers
Series media: firewire: fix memory leak |

Commit Message

Pavel Machek Sept. 20, 2020, 9:01 a.m. UTC 
  Fix memory leak in node_probe.
    
Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
diff mbox series

Patch

diff --git a/drivers/media/firewire/firedtv-fw.c b/drivers/media/firewire/firedtv-fw.c
index 3f1ca40b9b98..8a8585261bb8 100644
--- a/drivers/media/firewire/firedtv-fw.c
+++ b/drivers/media/firewire/firedtv-fw.c
@@ -272,8 +272,10 @@  static int node_probe(struct fw_unit *unit, const struct ieee1394_device_id *id)
 
 	name_len = fw_csr_string(unit->directory, CSR_MODEL,
 				 name, sizeof(name));
-	if (name_len < 0)
-		return name_len;
+	if (name_len < 0) {
+		err = name_len;
+		goto fail_free;
+	}
 	for (i = ARRAY_SIZE(model_names); --i; )
 		if (strlen(model_names[i]) <= name_len &&
 		    strncmp(name, model_names[i], name_len) == 0)