Message ID | 20200102134658.GH5050@valkosipuli.retiisi.org.uk (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1in0on-008yOz-Bh; Thu, 02 Jan 2020 13:47:17 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728395AbgABNr7 (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Thu, 2 Jan 2020 08:47:59 -0500 Received: from retiisi.org.uk ([95.216.213.190]:56656 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728378AbgABNr7 (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 2 Jan 2020 08:47:59 -0500 Received: from valkosipuli.localdomain (valkosipuli.retiisi.org.uk [IPv6:2a01:4f9:c010:4572::80:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id 09A3E634C86; Thu, 2 Jan 2020 15:46:58 +0200 (EET) Received: from sailus by valkosipuli.localdomain with local (Exim 4.92) (envelope-from <sakari.ailus@retiisi.org.uk>) id 1in0oU-0001sr-AW; Thu, 02 Jan 2020 15:46:58 +0200 Date: Thu, 2 Jan 2020 15:46:58 +0200 From: Sakari Ailus <sakari.ailus@iki.fi> To: linux-media@vger.kernel.org Cc: laurent.pinchart@ideasonboard.com Subject: [GIT PULL for 5.6] Smiapp PM patches and omap3isp fixes Message-ID: <20200102134658.GH5050@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Series |
[GIT,PULL,for,5.6] Smiapp PM patches and omap3isp fixes
|
|
Pull-request
git://linuxtv.org/sailus/media_tree.git tags/smiapp-pm-5.6-1-signedMessage
Sakari Ailus
Jan. 2, 2020, 1:46 p.m. UTC
Hi Mauro, Here's a few fixes for omap3isp plus cleanups for the smiapp driver. Please pull. The following changes since commit 0885acd77eb4644fd88f6d9f41e433f4ee9bc37a: media: vivid: support multiplanar touch devices (2019-12-16 13:24:16 +0100) are available in the Git repository at: git://linuxtv.org/sailus/media_tree.git tags/smiapp-pm-5.6-1-signed for you to fetch changes up to 5836ef92ac0205bfb6d354b39aabf2fab54f6666: smiapp: Put the device again if starting streaming fails (2020-01-02 14:59:35 +0200) ---------------------------------------------------------------- smiapp patches for 5.6 ---------------------------------------------------------------- Sakari Ailus (4): omap3isp: Ignore failure of stopping streaming on external subdev omap3isp: Don't restart CCDC if we're about to stop smiapp: Avoid maintaining power state information smiapp: Put the device again if starting streaming fails drivers/media/i2c/smiapp/smiapp-core.c | 198 +++++++++++++++++------------- drivers/media/i2c/smiapp/smiapp-regs.c | 3 - drivers/media/i2c/smiapp/smiapp.h | 1 - drivers/media/platform/omap3isp/isp.c | 8 +- drivers/media/platform/omap3isp/ispccdc.c | 12 +- 5 files changed, 126 insertions(+), 96 deletions(-)
Comments
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/patch/60967/
Build log: https://builder.linuxtv.org/job/patchwork/31904/
Build time: 00:04:57
Link: https://lore.kernel.org/linux-media/20200102134658.GH5050@valkosipuli.retiisi.org.uk
gpg: Signature made Thu 02 Jan 2020 01:42:43 PM UTC
gpg: using DSA key F0D0377A0D4F25A79238EFE56D40361B6E28C193
gpg: issuer "sakari.ailus@linux.intel.com"
gpg: Good signature from "Sakari Ailus <sakari.ailus@linux.intel.com>" [full]
Summary: 1 patches and/or PDF generation with issues, being 0 at build time
Error/warnings:
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0003-smiapp-Avoid-maintaining-power-state-information.patch
patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:114: CHECK: Lines should not end with a '('
patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:120: CHECK: Lines should not end with a '('
patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:132: CHECK: Lines should not end with a '('
patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:139: CHECK: Lines should not end with a '('
patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:146: CHECK: Lines should not end with a '('
patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:152: CHECK: Lines should not end with a '('
patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:158: CHECK: Lines should not end with a '('
patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:164: CHECK: Lines should not end with a '('
patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:170: CHECK: Lines should not end with a '('
patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:268: WARNING: Avoid multiple line dereference - prefer 'sensor->pixel_array->ctrl_handler'
Hi Mauro, On Thu, Jan 02, 2020 at 01:55:07PM +0000, Jenkins wrote: > From: builder@linuxtv.org > > Pull request: https://patchwork.linuxtv.org/patch/60967/ > Build log: https://builder.linuxtv.org/job/patchwork/31904/ > Build time: 00:04:57 > Link: https://lore.kernel.org/linux-media/20200102134658.GH5050@valkosipuli.retiisi.org.uk > > gpg: Signature made Thu 02 Jan 2020 01:42:43 PM UTC > gpg: using DSA key F0D0377A0D4F25A79238EFE56D40361B6E28C193 > gpg: issuer "sakari.ailus@linux.intel.com" > gpg: Good signature from "Sakari Ailus <sakari.ailus@linux.intel.com>" [full] > > Summary: 1 patches and/or PDF generation with issues, being 0 at build time > > Error/warnings: > > > Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0003-smiapp-Avoid-maintaining-power-state-information.patch: > $ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0003-smiapp-Avoid-maintaining-power-state-information.patch > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:114: CHECK: Lines should not end with a '(' > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:120: CHECK: Lines should not end with a '(' > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:132: CHECK: Lines should not end with a '(' > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:139: CHECK: Lines should not end with a '(' > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:146: CHECK: Lines should not end with a '(' > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:152: CHECK: Lines should not end with a '(' > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:158: CHECK: Lines should not end with a '(' > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:164: CHECK: Lines should not end with a '(' > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:170: CHECK: Lines should not end with a '(' > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:268: WARNING: Avoid multiple line dereference - prefer 'sensor->pixel_array->ctrl_handler' Regarding this --- parentheses beginning lines are abundantly used by the driver elsewhere (where they were originally moved from). If you prefer, I can send another patch reworking the code to remove parentheses beginning lines. It likely causes a number of cases where lines end up being longer than 80 chars though.