Message ID | 20141226203340.GA1791@amd (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1Y4baB-0002sO-J2; Fri, 26 Dec 2014 21:33:59 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1Y4ba9-0007Xq-jx; Fri, 26 Dec 2014 21:33:59 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751134AbaLZUdp (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 26 Dec 2014 15:33:45 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:55894 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbaLZUdn (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 26 Dec 2014 15:33:43 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id E324781D79; Fri, 26 Dec 2014 21:33:40 +0100 (CET) Date: Fri, 26 Dec 2014 21:33:40 +0100 From: Pavel Machek <pavel@ucw.cz> To: Rob Herring <robherring2@gmail.com> Cc: Bryan Wu <cooloney@gmail.com>, Pali =?iso-8859-1?Q?Roh=E1r?= <pali.rohar@gmail.com>, Sebastian Reichel <sre@debian.org>, Sebastian Reichel <sre@ring0.de>, kernel list <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-omap <linux-omap@vger.kernel.org>, Tony Lindgren <tony@atomide.com>, khilman@kernel.org, Aaro Koskinen <aaro.koskinen@iki.fi>, freemangordon@abv.bg, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Benoit Cousson <bcousson@baylibre.com>, sakari.ailus@iki.fi, Mauro Carvalho Chehab <m.chehab@samsung.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>, Jacek Anaszewski <j.anaszewski@samsung.com> Subject: Re: [PATCHv2] media: i2c/adp1653: devicetree support for adp1653 Message-ID: <20141226203340.GA1791@amd> References: <20141203214641.GA1390@amd> <20141224223434.GA20669@amd> <CAL_JsqJsDqYm-xfEM1CqNzJxfZY6vnYxaBYpT+3t4+gV2F3M1A@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <CAL_JsqJsDqYm-xfEM1CqNzJxfZY6vnYxaBYpT+3t4+gV2F3M1A@mail.gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.12.26.202420 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, KNOWN_FREEWEB_URI 0.05, MSGID_ADDED_BY_MTA 0.05, BODY_SIZE_3000_3999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, INVALID_MSGID_NO_FQDN 0, REFERENCES 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CD 0, __CP_NAME_BODY 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __FORWARDED_MSG 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __KNOWN_FREEWEB_URI2 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __URI_NS , __USER_AGENT 0' |
Commit Message
Pavel Machek
Dec. 26, 2014, 8:33 p.m. UTC
Hi! > > We are moving to device tree support on OMAP3, but that currently > > breaks ADP1653 driver. This adds device tree support, plus required > > documentation. > > > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > > > --- > > > > Changed -microsec to -us, as requested by devicetree people. > > > > Fixed checkpatch issues. > > > > diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt > > index 2d88816..2c6c7c5 100644 > > --- a/Documentation/devicetree/bindings/leds/common.txt > > +++ b/Documentation/devicetree/bindings/leds/common.txt > > @@ -14,6 +14,15 @@ Optional properties for child nodes: > > "ide-disk" - LED indicates disk activity > > "timer" - LED flashes at a fixed, configurable rate > > > > +- max-microamp : maximum intensity in microamperes of the LED > > + (torch LED for flash devices) > > +- flash-max-microamp : maximum intensity in microamperes of the > > + flash LED; it is mandatory if the LED should > > + support the flash mode > > +- flash-timeout-microsec : timeout in microseconds after which the flash > > + LED is turned off > > Doesn't all this go in your flash led binding patch? No, I should not have included this part. > > +Example: > > + > > + adp1653: led-controller@30 { > > + compatible = "adi,adp1653"; > > + reg = <0x30>; > > + gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>; /* 88 */ > > + > > + flash { > > + flash-timeout-us = <500000>; > > + flash-max-microamp = <320000>; > > + max-microamp = <50000>; > > + }; > > + indicator { > > These are different LEDs or different modes? flash & indicator are different LEDs. One is white, one is red. Flash can be used as a flash and as a torch. > > + max-microamp = <17500>; > > This is a bit inconsistent. The binding says this is for flash LEDs > torch mode, but I see no reason why it can't be common. Can you update > the binding doc to be clear here. By inconsisnent, you mean you want patch below? > Also, aren't you missing label properties? label is optional, and as my driver does not yet use it, I forgot about it. Signed-off-by: Pavel Machek <pavel@ucw.cz> index 2c6c7c5..92d4dac 100644
Comments
On Fri, Dec 26, 2014 at 2:33 PM, Pavel Machek <pavel@ucw.cz> wrote: > Hi! > >> > We are moving to device tree support on OMAP3, but that currently >> > breaks ADP1653 driver. This adds device tree support, plus required >> > documentation. >> > >> > Signed-off-by: Pavel Machek <pavel@ucw.cz> >> > >> > --- >> > >> > Changed -microsec to -us, as requested by devicetree people. >> > >> > Fixed checkpatch issues. >> > >> > diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt >> > index 2d88816..2c6c7c5 100644 >> > --- a/Documentation/devicetree/bindings/leds/common.txt >> > +++ b/Documentation/devicetree/bindings/leds/common.txt >> > @@ -14,6 +14,15 @@ Optional properties for child nodes: >> > "ide-disk" - LED indicates disk activity >> > "timer" - LED flashes at a fixed, configurable rate >> > >> > +- max-microamp : maximum intensity in microamperes of the LED >> > + (torch LED for flash devices) >> > +- flash-max-microamp : maximum intensity in microamperes of the >> > + flash LED; it is mandatory if the LED should >> > + support the flash mode >> > +- flash-timeout-microsec : timeout in microseconds after which the flash >> > + LED is turned off >> >> Doesn't all this go in your flash led binding patch? > > No, I should not have included this part. > >> > +Example: >> > + >> > + adp1653: led-controller@30 { >> > + compatible = "adi,adp1653"; >> > + reg = <0x30>; >> > + gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>; /* 88 */ >> > + >> > + flash { >> > + flash-timeout-us = <500000>; >> > + flash-max-microamp = <320000>; >> > + max-microamp = <50000>; >> > + }; >> > + indicator { >> >> These are different LEDs or different modes? > > flash & indicator are different LEDs. One is white, one is red. Flash > can be used as a flash and as a torch. > >> > + max-microamp = <17500>; >> >> This is a bit inconsistent. The binding says this is for flash LEDs >> torch mode, but I see no reason why it can't be common. Can you update >> the binding doc to be clear here. > > By inconsisnent, you mean you want patch below? Yes. >> Also, aren't you missing label properties? > > label is optional, and as my driver does not yet use it, I forgot > about it. Based on your node names, there are obviously user defined functions for them already. So they should have labels whether or not the driver uses them. Rob > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > index 2c6c7c5..92d4dac 100644 > --- a/Documentation/devicetree/bindings/leds/common.txt > +++ b/Documentation/devicetree/bindings/leds/common.txt > @@ -15,7 +15,6 @@ Optional properties for child nodes: > "timer" - LED flashes at a fixed, configurable rate > > - max-microamp : maximum intensity in microamperes of the LED > - (torch LED for flash devices) > - flash-max-microamp : maximum intensity in microamperes of the > flash LED; it is mandatory if the LED should > support the flash mode > > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/Documentation/devicetree/bindings/leds/common.txt +++ b/Documentation/devicetree/bindings/leds/common.txt @@ -15,7 +15,6 @@ Optional properties for child nodes: "timer" - LED flashes at a fixed, configurable rate - max-microamp : maximum intensity in microamperes of the LED - (torch LED for flash devices) - flash-max-microamp : maximum intensity in microamperes of the flash LED; it is mandatory if the LED should support the flash mode