Message ID | 20140925114008.GC3708@mwanda (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Hans Verkuil |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1XX7Pf-00015Z-Ig; Thu, 25 Sep 2014 13:40:43 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-7) with esmtp id 1XX7Pd-0007i2-1q; Thu, 25 Sep 2014 13:40:43 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751574AbaIYLki (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Thu, 25 Sep 2014 07:40:38 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:25829 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbaIYLkh (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 25 Sep 2014 07:40:37 -0400 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s8PBeONq019980 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 25 Sep 2014 11:40:25 GMT Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s8PBeOXF023923 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 25 Sep 2014 11:40:24 GMT Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userz7022.oracle.com (8.14.5+Sun/8.14.4) with ESMTP id s8PBeNuM017399; Thu, 25 Sep 2014 11:40:23 GMT Received: from mwanda (/197.157.0.9) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 25 Sep 2014 04:40:22 -0700 Date: Thu, 25 Sep 2014 14:40:08 +0300 From: Dan Carpenter <dan.carpenter@oracle.com> To: Mauro Carvalho Chehab <m.chehab@samsung.com>, Shuah Khan <shuah.kh@samsung.com> Cc: Fabian Frederick <fabf@skynet.be>, linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] [media] xc5000: use after free in release() Message-ID: <20140925114008.GC3708@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.9.25.113021 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, INVALID_MSGID_NO_FQDN 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CD 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __DATE_TZ_RU 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0' |
Commit Message
Dan Carpenter
Sept. 25, 2014, 11:40 a.m. UTC
I moved the call to hybrid_tuner_release_state(priv) after
"priv->firmware" dereference.
Fixes: 5264a522a597 ('[media] media: tuner xc5000 - release firmwware from xc5000_release()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Comments
On 09/25/2014 05:40 AM, Dan Carpenter wrote: > I moved the call to hybrid_tuner_release_state(priv) after > "priv->firmware" dereference. > > Fixes: 5264a522a597 ('[media] media: tuner xc5000 - release firmwware from xc5000_release()') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/media/tuners/xc5000.c b/drivers/media/tuners/xc5000.c > index e44c8ab..803a0e6 100644 > --- a/drivers/media/tuners/xc5000.c > +++ b/drivers/media/tuners/xc5000.c > @@ -1333,9 +1333,9 @@ static int xc5000_release(struct dvb_frontend *fe) > > if (priv) { > cancel_delayed_work(&priv->timer_sleep); > - hybrid_tuner_release_state(priv); > if (priv->firmware) > release_firmware(priv->firmware); > + hybrid_tuner_release_state(priv); > } > > mutex_unlock(&xc5000_list_mutex); > Thanks for catching it. Reviewed-by: Shuah Khan <shuahkh@osg.samsung.com> -- Shuah
On Thu, Sep 25, 2014 at 02:40:08PM +0300, Dan Carpenter wrote: > I moved the call to hybrid_tuner_release_state(priv) after > "priv->firmware" dereference. > > Fixes: 5264a522a597 ('[media] media: tuner xc5000 - release firmwware from xc5000_release()') We still need this patch. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/15/2014 07:40 AM, Dan Carpenter wrote: > On Thu, Sep 25, 2014 at 02:40:08PM +0300, Dan Carpenter wrote: >> I moved the call to hybrid_tuner_release_state(priv) after >> "priv->firmware" dereference. >> >> Fixes: 5264a522a597 ('[media] media: tuner xc5000 - release firmwware from xc5000_release()') > > We still need this patch. > I didn't see it in media pull request for 3.18. Mauro probably has this on his list for next round. -- Shuah
On Wed, Oct 15, 2014 at 09:12:46AM -0600, Shuah Khan wrote: > On 10/15/2014 07:40 AM, Dan Carpenter wrote: > > On Thu, Sep 25, 2014 at 02:40:08PM +0300, Dan Carpenter wrote: > >> I moved the call to hybrid_tuner_release_state(priv) after > >> "priv->firmware" dereference. > >> > >> Fixes: 5264a522a597 ('[media] media: tuner xc5000 - release firmwware from xc5000_release()') > > > > We still need this patch. > > > > I didn't see it in media pull request for 3.18. Mauro probably > has this on his list for next round. > It's not in linux-next. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/tuners/xc5000.c b/drivers/media/tuners/xc5000.c index e44c8ab..803a0e6 100644 --- a/drivers/media/tuners/xc5000.c +++ b/drivers/media/tuners/xc5000.c @@ -1333,9 +1333,9 @@ static int xc5000_release(struct dvb_frontend *fe) if (priv) { cancel_delayed_work(&priv->timer_sleep); - hybrid_tuner_release_state(priv); if (priv->firmware) release_firmware(priv->firmware); + hybrid_tuner_release_state(priv); } mutex_unlock(&xc5000_list_mutex);