| Message ID | 20110630103104.0a5b8ce6.randy.dunlap@oracle.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Return-path: <mchehab@pedra> Envelope-to: mchehab@pedra Delivery-date: Thu, 30 Jun 2011 14:33:29 -0300 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from <mchehab@pedra>) id 1QcL7J-0005Uu-G4 for mchehab@pedra; Thu, 30 Jun 2011 14:33:29 -0300 Received: from casper.infradead.org [85.118.1.10] by pedra with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Thu, 30 Jun 2011 14:33:29 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QcL5j-0003Bc-5s; Thu, 30 Jun 2011 17:31:51 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753431Ab1F3Rbd (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Thu, 30 Jun 2011 13:31:33 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:21814 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979Ab1F3Rbc (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 30 Jun 2011 13:31:32 -0400 Received: from rtcsinet21.oracle.com (rtcsinet21.oracle.com [66.248.204.29]) by rcsinet10.oracle.com (Switch-3.4.4/Switch-3.4.2) with ESMTP id p5UHVL7o014897 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 30 Jun 2011 17:31:23 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by rtcsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p5UHVK2Q007665 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 30 Jun 2011 17:31:20 GMT Received: from abhmt117.oracle.com (abhmt117.oracle.com [141.146.116.69]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p5UHVDGs012429; Thu, 30 Jun 2011 12:31:14 -0500 Received: from chimera.site (/50.53.38.135) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 30 Jun 2011 10:31:12 -0700 Date: Thu, 30 Jun 2011 10:31:04 -0700 From: Randy Dunlap <randy.dunlap@oracle.com> To: Stephen Rothwell <sfr@canb.auug.org.au>, linux-media@vger.kernel.org Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>, Mauro Carvalho Chehab <mchehab@infradead.org> Subject: [PATCH] media: fix radio-sf16fmr2 build when SND is not enabled Message-Id: <20110630103104.0a5b8ce6.randy.dunlap@oracle.com> In-Reply-To: <20110630165302.12ee1bd0.sfr@canb.auug.org.au> References: <20110630165302.12ee1bd0.sfr@canb.auug.org.au> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Source-IP: rtcsinet21.oracle.com [66.248.204.29] X-CT-RefId: str=0001.0A090202.4E0CB2EB.00C8:SCFSTAT5015188, ss=1, re=-4.000, fgs=0 Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org Sender: <mchehab@pedra> |
Commit Message
Randy Dunlap
June 30, 2011, 5:31 p.m. UTC
From: Randy Dunlap <randy.dunlap@oracle.com> When CONFIG_SND is not enabled, radio-sf16fmr2 build fails with: ERROR: "snd_tea575x_init" [drivers/media/radio/radio-sf16fmr2.ko] undefined! ERROR: "snd_tea575x_exit" [drivers/media/radio/radio-sf16fmr2.ko] undefined! so make this driver depend on SND. Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Hans Verkuil <hverkuil@xs4all.nl> Cc: Mauro Carvalho Chehab <mchehab@infradead.org> Cc: linux-media@vger.kernel.org --- drivers/media/radio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Comments
On Thursday 30 June 2011 19:31:04 Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > When CONFIG_SND is not enabled, radio-sf16fmr2 build fails with: > > ERROR: "snd_tea575x_init" [drivers/media/radio/radio-sf16fmr2.ko] undefined! > ERROR: "snd_tea575x_exit" [drivers/media/radio/radio-sf16fmr2.ko] undefined! > > so make this driver depend on SND. I broke this when converting the driver to use common TEA575x code. Thanks for finding and fixing it. > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > Cc: Hans Verkuil <hverkuil@xs4all.nl> > Cc: Mauro Carvalho Chehab <mchehab@infradead.org> > Cc: linux-media@vger.kernel.org > --- > drivers/media/radio/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20110630.orig/drivers/media/radio/Kconfig > +++ linux-next-20110630/drivers/media/radio/Kconfig > @@ -201,7 +201,7 @@ config RADIO_SF16FMI > > config RADIO_SF16FMR2 > tristate "SF16FMR2 Radio" > - depends on ISA && VIDEO_V4L2 > + depends on ISA && VIDEO_V4L2 && SND > ---help--- > Choose Y here if you have one of these FM radio cards.
--- linux-next-20110630.orig/drivers/media/radio/Kconfig +++ linux-next-20110630/drivers/media/radio/Kconfig @@ -201,7 +201,7 @@ config RADIO_SF16FMI config RADIO_SF16FMR2 tristate "SF16FMR2 Radio" - depends on ISA && VIDEO_V4L2 + depends on ISA && VIDEO_V4L2 && SND ---help--- Choose Y here if you have one of these FM radio cards.