firedtv: fix remote control with newer Xorg evdev
Commit Message
After a recent update of xf86-input-evdev and xorg-server, I noticed
that X11 applications did not receive keypresses from the FireDTV
infrared remote control anymore. Instead, the Xorg log featured lots of
"FireDTV remote control: dropping event due to full queue!"
exclamations. The Linux console did not have an issue with the
FireDTV's RC though.
The fix is to insert EV_SYN events after the key-down/-up events.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/media/dvb/firewire/firedtv-rc.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
Comments
Hi Stefan,
On Sun, Jan 16, 2011 at 09:39:21AM +0100, Stefan Richter wrote:
> @@ -188,6 +189,7 @@ void fdtv_handle_rc(struct firedtv *fdtv
> return;
> }
>
> - input_report_key(fdtv->remote_ctrl_dev, code, 1);
> - input_report_key(fdtv->remote_ctrl_dev, code, 0);
> + input_report_key(idev, code, 1);
input_sync() is needed here as well - userspace is free to accumulate
device state between EV_SYN events.
> + input_report_key(idev, code, 0);
> + input_sync(idev);
> }
>
===================================================================
@@ -172,7 +172,8 @@ void fdtv_unregister_rc(struct firedtv *
void fdtv_handle_rc(struct firedtv *fdtv, unsigned int code)
{
- u16 *keycode = fdtv->remote_ctrl_dev->keycode;
+ struct input_dev *idev = fdtv->remote_ctrl_dev;
+ u16 *keycode = idev->keycode;
if (code >= 0x0300 && code <= 0x031f)
code = keycode[code - 0x0300];
@@ -188,6 +189,7 @@ void fdtv_handle_rc(struct firedtv *fdtv
return;
}
- input_report_key(fdtv->remote_ctrl_dev, code, 1);
- input_report_key(fdtv->remote_ctrl_dev, code, 0);
+ input_report_key(idev, code, 1);
+ input_report_key(idev, code, 0);
+ input_sync(idev);
}