IX2505V: i2c transfer error code ignored
Commit Message
Hello Malcolm!
It seems that ix2505v driver ignores a i2c error in ix2505v_read_status_reg.
This looks like a typing error using (ret = 1) instead of correct (ret == 1).
The attached patch fixes this.
Regards
Matthias
Comments
On Sun, 2010-11-07 at 14:57 +0100, Matthias Schwarzott wrote:
> Hello Malcolm!
>
> It seems that ix2505v driver ignores a i2c error in ix2505v_read_status_reg.
> This looks like a typing error using (ret = 1) instead of correct (ret == 1).
>
> The attached patch fixes this.
Hi Matthias,
Thanks for picking that up.
Acked-by: Malcolm Priestley <tvboxspy@gmail.com>
Regards
Malcolm
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sunday 07 November 2010, Malcolm Priestley wrote:
> On Sun, 2010-11-07 at 14:57 +0100, Matthias Schwarzott wrote:
> > Hello Malcolm!
> >
> > It seems that ix2505v driver ignores a i2c error in
> > ix2505v_read_status_reg. This looks like a typing error using (ret = 1)
> > instead of correct (ret == 1).
> >
> > The attached patch fixes this.
>
> Hi Matthias,
>
> Thanks for picking that up.
>
> Acked-by: Malcolm Priestley <tvboxspy@gmail.com>
>
I forgot the SOB, so here it is:
Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
Regards
Matthias
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
@@ -72,7 +72,7 @@ static int ix2505v_read_status_reg(struct ix2505v_state *state)
ret = i2c_transfer(state->i2c, msg, 1);
deb_i2c("Read %s ", __func__);
- return (ret = 1) ? (int) b2[0] : -1;
+ return (ret == 1) ? (int) b2[0] : -1;
}
static int ix2505v_write(struct ix2505v_state *state, u8 buf[], u8 count)