mbox

[GIT,PATCHES,FOR,2.6.37] gspca for_2.6.37

Message ID 20100925111805.3d093ce7@tele (mailing list archive)
State Rejected, archived
Headers

Pull-request

git://linuxtv.org/jfrancois/gspca.git for_2.6.37

Message

Jean-Francois Moine Sept. 25, 2010, 9:18 a.m. UTC 
  The following changes since commit
dace3857de7a16b83ae7d4e13c94de8e4b267d2a:

  V4L/DVB: tvaudio: remove obsolete tda8425 initialization (2010-09-24 19:20:20 -0300)

are available in the git repository at:
  git://linuxtv.org/jfrancois/gspca.git for_2.6.37

Jean-François Moine (6):
      gspca - benq: Display error messages when gspca debug disabled.
      gspca - benq: Remove useless module load/unload messages.
      gspca - cpia1: Fix compilation warning when gspca debug disabled.
      gspca - many subdrivers: Handle INPUT as a module.
      gspca - spca505: Remove the eeprom write commands of NxUltra.
      gspca - sonixj: Propagate USB errors to higher level.

 drivers/media/video/gspca/benq.c            |   20 ++----
 drivers/media/video/gspca/cpia1.c           |    2 +
 drivers/media/video/gspca/konica.c          |    8 ++-
 drivers/media/video/gspca/ov519.c           |    6 +-
 drivers/media/video/gspca/pac207.c          |    6 +-
 drivers/media/video/gspca/pac7302.c         |    6 +-
 drivers/media/video/gspca/pac7311.c         |    6 +-
 drivers/media/video/gspca/sn9c20x.c         |    6 +-
 drivers/media/video/gspca/sonixb.c          |    6 +-
 drivers/media/video/gspca/sonixj.c          |   91 +++++++++++++++++++++------
 drivers/media/video/gspca/spca505.c         |    4 -
 drivers/media/video/gspca/spca561.c         |    8 ++-
 drivers/media/video/gspca/stv06xx/stv06xx.c |    6 +-
 drivers/media/video/gspca/zc3xx.c           |    6 +-
 14 files changed, 119 insertions(+), 62 deletions(-)

Comments

Mauro Carvalho Chehab Sept. 30, 2010, 12:14 p.m. UTC | #1 
Em 25-09-2010 06:18, Jean-Francois Moine escreveu:
> The following changes since commit
> dace3857de7a16b83ae7d4e13c94de8e4b267d2a:
> 
>   V4L/DVB: tvaudio: remove obsolete tda8425 initialization (2010-09-24 19:20:20 -0300)
> 
> are available in the git repository at:
>   git://linuxtv.org/jfrancois/gspca.git for_2.6.37
> 
> Jean-François Moine (6):
>       gspca - benq: Display error messages when gspca debug disabled.
>       gspca - benq: Remove useless module load/unload messages.
>       gspca - cpia1: Fix compilation warning when gspca debug disabled.
>       gspca - many subdrivers: Handle INPUT as a module.


Please, don't do that:

+#if defined(CONFIG_INPUT) || defined(CONFIG_INPUT_MODULE)
 #include <linux/input.h>
+#endif

It would be a real mess if we start doing it for every include that have
depencencies on kernel. Instead, just keep the include there.

I applied the other patches from this series, keeping this one waiting
for your version 2.


>       gspca - spca505: Remove the eeprom write commands of NxUltra.
>       gspca - sonixj: Propagate USB errors to higher level.
> 
>  drivers/media/video/gspca/benq.c            |   20 ++----
>  drivers/media/video/gspca/cpia1.c           |    2 +
>  drivers/media/video/gspca/konica.c          |    8 ++-
>  drivers/media/video/gspca/ov519.c           |    6 +-
>  drivers/media/video/gspca/pac207.c          |    6 +-
>  drivers/media/video/gspca/pac7302.c         |    6 +-
>  drivers/media/video/gspca/pac7311.c         |    6 +-
>  drivers/media/video/gspca/sn9c20x.c         |    6 +-
>  drivers/media/video/gspca/sonixb.c          |    6 +-
>  drivers/media/video/gspca/sonixj.c          |   91 +++++++++++++++++++++------
>  drivers/media/video/gspca/spca505.c         |    4 -
>  drivers/media/video/gspca/spca561.c         |    8 ++-
>  drivers/media/video/gspca/stv06xx/stv06xx.c |    6 +-
>  drivers/media/video/gspca/zc3xx.c           |    6 +-
>  14 files changed, 119 insertions(+), 62 deletions(-)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html