Message ID | 20100824084528.GA26618@elte.hu (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-path: <mchehab@pedra> Envelope-to: mchehab@pedra Delivery-date: Tue, 24 Aug 2010 08:45:15 -0300 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from <mchehab@pedra>) id 1OnrwJ-0002Cc-7x for mchehab@pedra; Tue, 24 Aug 2010 08:45:15 -0300 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Tue, 24 Aug 2010 08:45:15 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1Onp9B-0003nM-GG; Tue, 24 Aug 2010 08:46:21 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751531Ab0HXIpx (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Tue, 24 Aug 2010 04:45:53 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:44674 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751190Ab0HXIpw (ORCPT <rfc822;linux-media@vger.kernel.org>); Tue, 24 Aug 2010 04:45:52 -0400 Received: from elvis.elte.hu ([157.181.1.14]) by mx3.mail.elte.hu with esmtp (Exim) id 1Onp8P-00069p-2i from <mingo@elte.hu>; Tue, 24 Aug 2010 10:45:36 +0200 Received: by elvis.elte.hu (Postfix, from userid 1004) id 7661F3E22D9; Tue, 24 Aug 2010 10:45:27 +0200 (CEST) Date: Tue, 24 Aug 2010 10:45:28 +0200 From: Ingo Molnar <mingo@elte.hu> To: Mauro Carvalho Chehab <mchehab@redhat.com> Cc: Linus Torvalds <torvalds@linux-foundation.org>, Andrew Morton <akpm@linux-foundation.org>, Linux Media Mailing List <linux-media@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Randy Dunlap <randy.dunlap@oracle.com> Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency Message-ID: <20100824084528.GA26618@elte.hu> References: <4C643A08.3000605@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C643A08.3000605@redhat.com> User-Agent: Mutt/1.5.20 (2009-08-17) Received-SPF: neutral (mx3: 157.181.1.14 is neither permitted nor denied by domain of elte.hu) client-ip=157.181.1.14; envelope-from=mingo@elte.hu; helo=elvis.elte.hu; X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0016] Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org Sender: Mauro Carvalho Chehab <mchehab@pedra> |
Commit Message
Ingo Molnar
Aug. 24, 2010, 8:45 a.m. UTC
* Mauro Carvalho Chehab <mchehab@redhat.com> wrote: > Linus, > > Please pull from: > ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus > > For 3 build fixes. > > Cheers, > Mauro. > > The following changes since commit ad41a1e0cab07c5125456e8d38e5b1ab148d04aa: > > Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 10:17:19 -0700) > > are available in the git repository at: > > ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus > > Mauro Carvalho Chehab (2): > V4L/DVB: Fix IR_CORE dependencies > V4L/DVB: fix Kconfig to depends on VIDEO_IR > > Randy Dunlap (1): > V4L/DVB: v4l2-ctrls.c: needs to include slab.h FYI, there's one more IR_CORE related build bug which triggers frequently in randconfig tests - see the fix below. Thanks, Ingo -------------------> From c56aef270d7ec01564c632c1f7ebab6b8f9f032c Mon Sep 17 00:00:00 2001 From: Ingo Molnar <mingo@elte.hu> Date: Tue, 24 Aug 2010 10:41:33 +0200 Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency This build bug triggers: drivers/built-in.o: In function `mantis_exit': (.text+0x377413): undefined reference to `ir_input_unregister' drivers/built-in.o: In function `mantis_input_init': (.text+0x3774ff): undefined reference to `__ir_input_register' If MANTIS_CORE is enabled but IR_CORE is not. Add the correct dependency. Signed-off-by: Ingo Molnar <mingo@elte.hu> --- drivers/media/dvb/mantis/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Comments
On 08/24/10 01:45, Ingo Molnar wrote: > > * Mauro Carvalho Chehab <mchehab@redhat.com> wrote: > >> Linus, >> >> Please pull from: >> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus >> >> For 3 build fixes. >> >> Cheers, >> Mauro. >> >> The following changes since commit ad41a1e0cab07c5125456e8d38e5b1ab148d04aa: >> >> Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 10:17:19 -0700) >> >> are available in the git repository at: >> >> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus >> >> Mauro Carvalho Chehab (2): >> V4L/DVB: Fix IR_CORE dependencies >> V4L/DVB: fix Kconfig to depends on VIDEO_IR >> >> Randy Dunlap (1): >> V4L/DVB: v4l2-ctrls.c: needs to include slab.h > > FYI, there's one more IR_CORE related build bug which triggers > frequently in randconfig tests - see the fix below. > > Thanks, > > Ingo > > -------------------> > From c56aef270d7ec01564c632c1f7ebab6b8f9f032c Mon Sep 17 00:00:00 2001 > From: Ingo Molnar <mingo@elte.hu> > Date: Tue, 24 Aug 2010 10:41:33 +0200 > Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency > > This build bug triggers: > > drivers/built-in.o: In function `mantis_exit': > (.text+0x377413): undefined reference to `ir_input_unregister' > drivers/built-in.o: In function `mantis_input_init': > (.text+0x3774ff): undefined reference to `__ir_input_register' > > If MANTIS_CORE is enabled but IR_CORE is not. Add the correct > dependency. > > Signed-off-by: Ingo Molnar <mingo@elte.hu> > --- > drivers/media/dvb/mantis/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/dvb/mantis/Kconfig b/drivers/media/dvb/mantis/Kconfig > index decdeda..fd0830e 100644 > --- a/drivers/media/dvb/mantis/Kconfig > +++ b/drivers/media/dvb/mantis/Kconfig > @@ -1,6 +1,6 @@ > config MANTIS_CORE > tristate "Mantis/Hopper PCI bridge based devices" > - depends on PCI && I2C && INPUT > + depends on PCI && I2C && INPUT && IR_CORE > > help > Support for PCI cards based on the Mantis and Hopper PCi bridge. Acked-by: Randy Dunlap <randy.dunlap@oracle.com> http://lkml.org/lkml/2010/8/17/341 thanks,
* Randy Dunlap <randy.dunlap@oracle.com> wrote: > On 08/24/10 01:45, Ingo Molnar wrote: > > > > * Mauro Carvalho Chehab <mchehab@redhat.com> wrote: > > > >> Linus, > >> > >> Please pull from: > >> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus > >> > >> For 3 build fixes. > >> > >> Cheers, > >> Mauro. > >> > >> The following changes since commit ad41a1e0cab07c5125456e8d38e5b1ab148d04aa: > >> > >> Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 10:17:19 -0700) > >> > >> are available in the git repository at: > >> > >> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus > >> > >> Mauro Carvalho Chehab (2): > >> V4L/DVB: Fix IR_CORE dependencies > >> V4L/DVB: fix Kconfig to depends on VIDEO_IR > >> > >> Randy Dunlap (1): > >> V4L/DVB: v4l2-ctrls.c: needs to include slab.h > > > > FYI, there's one more IR_CORE related build bug which triggers > > frequently in randconfig tests - see the fix below. > > > > Thanks, > > > > Ingo > > > > -------------------> > > From c56aef270d7ec01564c632c1f7ebab6b8f9f032c Mon Sep 17 00:00:00 2001 > > From: Ingo Molnar <mingo@elte.hu> > > Date: Tue, 24 Aug 2010 10:41:33 +0200 > > Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency > > > > This build bug triggers: > > > > drivers/built-in.o: In function `mantis_exit': > > (.text+0x377413): undefined reference to `ir_input_unregister' > > drivers/built-in.o: In function `mantis_input_init': > > (.text+0x3774ff): undefined reference to `__ir_input_register' > > > > If MANTIS_CORE is enabled but IR_CORE is not. Add the correct > > dependency. > > > > Signed-off-by: Ingo Molnar <mingo@elte.hu> > > --- > > drivers/media/dvb/mantis/Kconfig | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/media/dvb/mantis/Kconfig b/drivers/media/dvb/mantis/Kconfig > > index decdeda..fd0830e 100644 > > --- a/drivers/media/dvb/mantis/Kconfig > > +++ b/drivers/media/dvb/mantis/Kconfig > > @@ -1,6 +1,6 @@ > > config MANTIS_CORE > > tristate "Mantis/Hopper PCI bridge based devices" > > - depends on PCI && I2C && INPUT > > + depends on PCI && I2C && INPUT && IR_CORE > > > > help > > Support for PCI cards based on the Mantis and Hopper PCi bridge. > > > Acked-by: Randy Dunlap <randy.dunlap@oracle.com> > http://lkml.org/lkml/2010/8/17/341 Your patch came first :-) Btw., the reason i missed your patch is that i grepped lkml for the static build failure - while your changelog contained the modular one. Oh well :) Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Em 24-08-2010 16:30, Ingo Molnar escreveu: > > * Randy Dunlap <randy.dunlap@oracle.com> wrote: > >> On 08/24/10 01:45, Ingo Molnar wrote: >>> >>> * Mauro Carvalho Chehab <mchehab@redhat.com> wrote: >>> >>>> Linus, >>>> >>>> Please pull from: >>>> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus >>>> >>>> For 3 build fixes. >>>> >>>> Cheers, >>>> Mauro. >>>> >>>> The following changes since commit ad41a1e0cab07c5125456e8d38e5b1ab148d04aa: >>>> >>>> Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 10:17:19 -0700) >>>> >>>> are available in the git repository at: >>>> >>>> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus >>>> >>>> Mauro Carvalho Chehab (2): >>>> V4L/DVB: Fix IR_CORE dependencies >>>> V4L/DVB: fix Kconfig to depends on VIDEO_IR >>>> >>>> Randy Dunlap (1): >>>> V4L/DVB: v4l2-ctrls.c: needs to include slab.h >>> >>> FYI, there's one more IR_CORE related build bug which triggers >>> frequently in randconfig tests - see the fix below. >>> >>> Thanks, >>> >>> Ingo >>> >>> -------------------> >>> From c56aef270d7ec01564c632c1f7ebab6b8f9f032c Mon Sep 17 00:00:00 2001 >>> From: Ingo Molnar <mingo@elte.hu> >>> Date: Tue, 24 Aug 2010 10:41:33 +0200 >>> Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency >>> >>> This build bug triggers: >>> >>> drivers/built-in.o: In function `mantis_exit': >>> (.text+0x377413): undefined reference to `ir_input_unregister' >>> drivers/built-in.o: In function `mantis_input_init': >>> (.text+0x3774ff): undefined reference to `__ir_input_register' >>> >>> If MANTIS_CORE is enabled but IR_CORE is not. Add the correct >>> dependency. >>> >>> Signed-off-by: Ingo Molnar <mingo@elte.hu> >>> --- >>> drivers/media/dvb/mantis/Kconfig | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/drivers/media/dvb/mantis/Kconfig b/drivers/media/dvb/mantis/Kconfig >>> index decdeda..fd0830e 100644 >>> --- a/drivers/media/dvb/mantis/Kconfig >>> +++ b/drivers/media/dvb/mantis/Kconfig >>> @@ -1,6 +1,6 @@ >>> config MANTIS_CORE >>> tristate "Mantis/Hopper PCI bridge based devices" >>> - depends on PCI && I2C && INPUT >>> + depends on PCI && I2C && INPUT && IR_CORE >>> >>> help >>> Support for PCI cards based on the Mantis and Hopper PCi bridge. >> >> >> Acked-by: Randy Dunlap <randy.dunlap@oracle.com> >> http://lkml.org/lkml/2010/8/17/341 > > Your patch came first :-) > > Btw., the reason i missed your patch is that i grepped lkml for the > static build failure - while your changelog contained the modular one. > Oh well :) I've added this patch earlier today on my tree: http://git.linuxtv.org/media_tree.git?a=commit;h=3a057c36346f60bd0fb4fe7d7a68c4d931d8768f and the other IR_CORE fixup at staging/tm6000: http://git.linuxtv.org/media_tree.git?a=commit;h=926a2496438f44268130f72f5e102dcac484573d I'll be sending them today to my linux-next tree and likely tomorrow to upstream, together with a few other fixes. > > Thanks, > > Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/dvb/mantis/Kconfig b/drivers/media/dvb/mantis/Kconfig index decdeda..fd0830e 100644 --- a/drivers/media/dvb/mantis/Kconfig +++ b/drivers/media/dvb/mantis/Kconfig @@ -1,6 +1,6 @@ config MANTIS_CORE tristate "Mantis/Hopper PCI bridge based devices" - depends on PCI && I2C && INPUT + depends on PCI && I2C && INPUT && IR_CORE help Support for PCI cards based on the Mantis and Hopper PCi bridge.