| Message ID | 20100809105635.4208c7ac.randy.dunlap@oracle.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Return-path: <mchehab@pedra> Envelope-to: mchehab@pedra Delivery-date: Mon, 09 Aug 2010 15:00:21 -0300 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from <mchehab@pedra>) id 1OiWe5-0000gz-5Q for mchehab@pedra; Mon, 09 Aug 2010 15:00:21 -0300 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Mon, 09 Aug 2010 15:00:20 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1OiWcU-0002bL-Oc; Mon, 09 Aug 2010 17:58:42 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753463Ab0HIR6K (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Mon, 9 Aug 2010 13:58:10 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:54797 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753354Ab0HIR6H (ORCPT <rfc822; linux-media@vger.kernel.org>); Mon, 9 Aug 2010 13:58:07 -0400 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o79Hw0dW023101 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 9 Aug 2010 17:58:01 GMT Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o79GsqJa012875; Mon, 9 Aug 2010 17:57:59 GMT Received: from abhmt001.oracle.com by acsmt353.oracle.com with ESMTP id 479923791281376599; Mon, 09 Aug 2010 10:56:39 -0700 Received: from chimera.site (/173.50.240.230) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 09 Aug 2010 10:56:38 -0700 Date: Mon, 9 Aug 2010 10:56:35 -0700 From: Randy Dunlap <randy.dunlap@oracle.com> To: Stephen Rothwell <sfr@canb.auug.org.au>, linux-media@vger.kernel.org, Mauro Carvalho Chehab <mchehab@infradead.org> Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org> Subject: [PATCH -next] v4l2-ctrls.c: needs to include slab.h Message-Id: <20100809105635.4208c7ac.randy.dunlap@oracle.com> In-Reply-To: <20100809132314.789e13f3.sfr@canb.auug.org.au> References: <20100809132314.789e13f3.sfr@canb.auug.org.au> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org Sender: Mauro Carvalho Chehab <mchehab@pedra> |
Commit Message
Randy Dunlap
Aug. 9, 2010, 5:56 p.m. UTC
From: Randy Dunlap <randy.dunlap@oracle.com> v4l2-ctrls.c needs to include slab.h to prevent build errors: drivers/media/video/v4l2-ctrls.c:766: error: implicit declaration of function 'kzalloc' drivers/media/video/v4l2-ctrls.c:786: error: implicit declaration of function 'kfree' drivers/media/video/v4l2-ctrls.c:1528: error: implicit declaration of function 'kmalloc' Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Mauro Carvalho Chehab <mchehab@infradead.org> --- drivers/media/video/v4l2-ctrls.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Comments
On Mon, 2010-08-09 at 10:56 -0700, Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > v4l2-ctrls.c needs to include slab.h to prevent build errors: This appears to have been missed. Running mainline git: Linux amalthea 2.6.35-06998-g3d30701 #1 SMP Wed Aug 11 15:33:16 BST 2010 x86_64 Intel(R) Core(TM)2 Duo CPU T9400 @ 2.53GHz GenuineIntel GNU/Linux Enabling Video 4 Linux results in the breakage promised by Randy: > drivers/media/video/v4l2-ctrls.c:766: error: implicit declaration of function 'kzalloc' > drivers/media/video/v4l2-ctrls.c:786: error: implicit declaration of function 'kfree' > drivers/media/video/v4l2-ctrls.c:1528: error: implicit declaration of function 'kmalloc' Please apply. Regards,
--- linux-next-20100809.orig/drivers/media/video/v4l2-ctrls.c +++ linux-next-20100809/drivers/media/video/v4l2-ctrls.c @@ -19,6 +19,7 @@ */ #include <linux/ctype.h> +#include <linux/slab.h> #include <media/v4l2-ioctl.h> #include <media/v4l2-device.h> #include <media/v4l2-ctrls.h>