diff mbox

input: fix uninitialized old_keycode oops in input_set_keycode

Message ID 20100719195912.GC31837@redhat.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Jarod Wilson July 19, 2010, 7:59 p.m. UTC 
  Patch as suggested by Kyle McMartin, in response to Red Hat bugzilla
615707, filed against a rawhide kernel carrying ir-core enabling patches
from the linuxtv staging/other tree. Fix is based on the similar logic in
input_set_keycode_big, and is confirmed by the bz reporter.

CC: Kyle McMartin <kmcmartin@redhat.com>
Signed-off-by: Jarod Wilson <jarod@redhat.com>
---
 drivers/input/input.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff mbox

Patch

diff --git a/drivers/input/input.c b/drivers/input/input.c
index ce5d90d..0c71977 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -900,6 +900,7 @@  int input_set_keycode(struct input_dev *dev,
 		if (retval)
 			goto out;
 
+		old_keycode = kt_entry.keycode;
 		kt_entry.keycode = keycode;
 
 		retval = dev->setkeycodebig(dev, &kt_entry);