diff mbox

cx25821: fix double unlock in medusa_video_init()

Message ID 20091228165946.GD17645@bicker (mailing list archive)
State Superseded, archived
Headers

Commit Message

Dan Carpenter Dec. 28, 2009, 4:59 p.m. UTC 
  medusa_set_videostandard() takes the lock but it always drops it before
returning.

This was found with a static checker and compile tested only.  :/

Signed-off-by: Dan Carpenter <error27@gmail.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- orig/drivers/staging/cx25821/cx25821-medusa-video.c	2009-12-28 09:13:01.000000000 +0200
+++ devel/drivers/staging/cx25821/cx25821-medusa-video.c	2009-12-28 09:13:55.000000000 +0200
@@ -860,10 +860,8 @@  int medusa_video_init(struct cx25821_dev
 
 	ret_val = medusa_set_videostandard(dev);
 
-	if (ret_val < 0) {
-		mutex_unlock(&dev->lock);
+	if (ret_val < 0)
 		return -EINVAL;
-	}
 
 	return 1;
 }