Message ID | 20090415104808.13062f47@gmail.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-path: <linux-media-owner@vger.kernel.org> Envelope-to: mchehab@infradead.org Delivery-date: Wed, 15 Apr 2009 13:48:22 +0000 Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1Lu5TR-00089s-JE; Wed, 15 Apr 2009 13:48:22 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751955AbZDONsT (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Wed, 15 Apr 2009 09:48:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752715AbZDONsT (ORCPT <rfc822;linux-media-outgoing>); Wed, 15 Apr 2009 09:48:19 -0400 Received: from an-out-0708.google.com ([209.85.132.244]:1943 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751886AbZDONsP (ORCPT <rfc822;linux-media@vger.kernel.org>); Wed, 15 Apr 2009 09:48:15 -0400 Received: by an-out-0708.google.com with SMTP id d14so2898376and.1 for <linux-media@vger.kernel.org>; Wed, 15 Apr 2009 06:48:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:in-reply-to:references:x-mailer:mime-version :content-type; bh=r7Vzs5XyfQwJxf/RxOZpQkYZryUs/lTv+eLIzaXfkLg=; b=v4RNvz1SS3K0Haz+BWIP33L5n/Sb8ElPU10i6GQvfE+lHRHOSbgGHrDiZvTSqKdTqd gAP1n/FmwKN+5qWSNKYyx05O60ivGDt547lgoNFa8BVOBeLA7rYwyEyG8YEp9rG6qqid f/joZWa6cpZBfKYatyBRpD2mDHDyQdKy0oCcM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=AEvxj3B7VG24m0pVpOwHnLdcFXIQ3HgfuUhQkhI6qok2XrcIBdXMqlbc2l0tMuG5Mu XUEpyYiJuDFYMBpTfu+EZCQHaRTLsLk4CwKO15jIDqf6PuZTxklrOf+dar2wD9E4yWAz ONl17ph3cx8qzuoobgLPJOONduLaPXRFNGogY= Received: by 10.100.120.19 with SMTP id s19mr382599anc.66.1239803293943; Wed, 15 Apr 2009 06:48:13 -0700 (PDT) Received: from localhost.localdomain ([201.21.233.102]) by mx.google.com with ESMTPS id c23sm302661ana.3.2009.04.15.06.48.11 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 15 Apr 2009 06:48:13 -0700 (PDT) Date: Wed, 15 Apr 2009 10:48:08 -0300 From: Douglas Schilling Landgraf <dougsland@gmail.com> To: Laurent Pinchart <laurent.pinchart@skynet.be> Cc: linux-media@vger.kernel.org, Mauro Carvalho Chehab <mchehab@infradead.org> Subject: Re: [PATCH] uvc: Add Microsoft VX 500 webcam Message-ID: <20090415104808.13062f47@gmail.com> In-Reply-To: <200904151146.52459.laurent.pinchart@skynet.be> References: <68cac7520904150003n150bff9bp616cc49e684d947d@mail.gmail.com> <200904151146.52459.laurent.pinchart@skynet.be> X-Mailer: Claws Mail 3.7.0 (GTK+ 2.12.12; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/zllw/hS6OrvmBf5+dO06eLh" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Douglas Schilling Landgraf
April 15, 2009, 1:48 p.m. UTC
Hello Laurent, On Wed, 15 Apr 2009 11:46:52 +0200 Laurent Pinchart <laurent.pinchart@skynet.be> wrote: > Hi Douglas, > > On Wednesday 15 April 2009 09:03:45 Douglas Schilling Landgraf wrote: > > Hello Laurent, > > > > Attached patch for the following: > > > > Added Microsoft VX 500 webcam to uvc driver. > > > > Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com> > > Could you please send me the output of > > lsusb -v -d 045e:074a > > using usbutils 0.72 or newer (0.73+ preferred) ? > usbutils-0.73-2 > Have you tried the latest driver ? Yes > The MINMAX quirk isn't required > anymore for most cameras (although the two supported Microsoft > webcams still need it, so I doubt it will work as-is). > Indeed, attached new patch. Thanks, Douglas Bus 002 Device 015: ID 045e:074a Microsoft Corp. Device Descriptor: bLength 18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 239 Miscellaneous Device bDeviceSubClass 2 ? bDeviceProtocol 1 Interface Association bMaxPacketSize0 64 idVendor 0x045e Microsoft Corp. idProduct 0x074a bcdDevice 1.01 iManufacturer 2 Microsoft iProduct 1 Microsoft LifeCam iSerial 0 bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 569 bNumInterfaces 2 bConfigurationValue 1 iConfiguration 0 bmAttributes 0x80 (Bus Powered) MaxPower 150mA Interface Association: bLength 8 bDescriptorType 11 bFirstInterface 0 bInterfaceCount 2 bFunctionClass 14 Video bFunctionSubClass 3 Video Interface Collection bFunctionProtocol 0 iFunction 1 Microsoft LifeCam Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 0 bAlternateSetting 0 bNumEndpoints 1 bInterfaceClass 14 Video bInterfaceSubClass 1 Video Control bInterfaceProtocol 0 iInterface 1 Microsoft LifeCam VideoControl Interface Descriptor: bLength 13 bDescriptorType 36 bDescriptorSubtype 1 (HEADER) bcdUVC 1.00 wTotalLength 103 dwClockFrequency 15.000000MHz bInCollection 1 baInterfaceNr( 0) 1 VideoControl Interface Descriptor: bLength 9 bDescriptorType 36 bDescriptorSubtype 3 (OUTPUT_TERMINAL) bTerminalID 2 wTerminalType 0x0101 USB Streaming bAssocTerminal 0 bSourceID 5 iTerminal 0 VideoControl Interface Descriptor: bLength 26 bDescriptorType 36 bDescriptorSubtype 6 (EXTENSION_UNIT) bUnitID 4 guidExtensionCode {7033f028-1163-2e4a-ba2c-6890eb334016} bNumControl 8 bNrPins 1 baSourceID( 0) 3 bControlSize 1 bmControls( 0) 0x0f iExtension 0 VideoControl Interface Descriptor: bLength 26 bDescriptorType 36 bDescriptorSubtype 6 (EXTENSION_UNIT) bUnitID 5 guidExtensionCode {3fae1228-d7bc-114e-a357-6f1edef7d61d} bNumControl 8 bNrPins 1 baSourceID( 0) 4 bControlSize 1 bmControls( 0) 0x00 iExtension 0 VideoControl Interface Descriptor: bLength 18 bDescriptorType 36 bDescriptorSubtype 2 (INPUT_TERMINAL) bTerminalID 1 wTerminalType 0x0201 Camera Sensor bAssocTerminal 0 iTerminal 0 wObjectiveFocalLengthMin 0 wObjectiveFocalLengthMax 0 wOcularFocalLength 0 bControlSize 3 bmControls 0x00000000 VideoControl Interface Descriptor: bLength 11 bDescriptorType 36 bDescriptorSubtype 5 (PROCESSING_UNIT) Warning: Descriptor too short bUnitID 3 bSourceID 1 wMaxMultiplier 0 bControlSize 2 bmControls 0x0000053f Brightness Contrast Hue Saturation Sharpness Gamma Backlight Compensation Power Line Frequency iProcessing 0 bmVideoStandards 0x 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x83 EP 3 IN bmAttributes 3 Transfer Type Interrupt Synch Type None Usage Type Data wMaxPacketSize 0x0010 1x 16 bytes bInterval 6 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass 14 Video bInterfaceSubClass 2 Video Streaming bInterfaceProtocol 0 iInterface 0 VideoStreaming Interface Descriptor: bLength 14 bDescriptorType 36 bDescriptorSubtype 1 (INPUT_HEADER) bNumFormats 1 wTotalLength 323 bEndPointAddress 129 bmInfo 0 bTerminalLink 2 bStillCaptureMethod 2 bTriggerSupport 1 bTriggerUsage 0 bControlSize 1 bmaControls( 0) 27 VideoStreaming Interface Descriptor: bLength 27 bDescriptorType 36 bDescriptorSubtype 4 (FORMAT_UNCOMPRESSED) bFormatIndex 1 bNumFrameDescriptors 5 guidFormat {59555932-0000-1000-8000-00aa00389b71} bBitsPerPixel 16 bDefaultFrameIndex 1 bAspectRatioX 0 bAspectRatioY 0 bmInterlaceFlags 0x00 Interlaced stream or variable: No Fields per frame: 1 fields Field 1 first: No Field pattern: Field 1 only bCopyProtect 0 VideoStreaming Interface Descriptor: bLength 50 bDescriptorType 36 bDescriptorSubtype 5 (FRAME_UNCOMPRESSED) bFrameIndex 1 bmCapabilities 0x00 Still image unsupported wWidth 640 wHeight 480 dwMinBitRate 614400 dwMaxBitRate 18432000 dwMaxVideoFrameBufferSize 614400 dwDefaultFrameInterval 333333 bFrameIntervalType 6 dwFrameInterval( 0) 333333 dwFrameInterval( 1) 500000 dwFrameInterval( 2) 666666 dwFrameInterval( 3) 1000000 dwFrameInterval( 4) 2000000 dwFrameInterval( 5) 10000000 VideoStreaming Interface Descriptor: bLength 50 bDescriptorType 36 bDescriptorSubtype 5 (FRAME_UNCOMPRESSED) bFrameIndex 2 bmCapabilities 0x00 Still image unsupported wWidth 352 wHeight 288 dwMinBitRate 202752 dwMaxBitRate 6082560 dwMaxVideoFrameBufferSize 202752 dwDefaultFrameInterval 333333 bFrameIntervalType 6 dwFrameInterval( 0) 333333 dwFrameInterval( 1) 500000 dwFrameInterval( 2) 666666 dwFrameInterval( 3) 1000000 dwFrameInterval( 4) 2000000 dwFrameInterval( 5) 10000000 VideoStreaming Interface Descriptor: bLength 50 bDescriptorType 36 bDescriptorSubtype 5 (FRAME_UNCOMPRESSED) bFrameIndex 3 bmCapabilities 0x00 Still image unsupported wWidth 320 wHeight 240 dwMinBitRate 153600 dwMaxBitRate 4608000 dwMaxVideoFrameBufferSize 153600 dwDefaultFrameInterval 333333 bFrameIntervalType 6 dwFrameInterval( 0) 333333 dwFrameInterval( 1) 500000 dwFrameInterval( 2) 666666 dwFrameInterval( 3) 1000000 dwFrameInterval( 4) 2000000 dwFrameInterval( 5) 10000000 VideoStreaming Interface Descriptor: bLength 50 bDescriptorType 36 bDescriptorSubtype 5 (FRAME_UNCOMPRESSED) bFrameIndex 4 bmCapabilities 0x00 Still image unsupported wWidth 176 wHeight 144 dwMinBitRate 50688 dwMaxBitRate 1520640 dwMaxVideoFrameBufferSize 50688 dwDefaultFrameInterval 333333 bFrameIntervalType 6 dwFrameInterval( 0) 333333 dwFrameInterval( 1) 500000 dwFrameInterval( 2) 666666 dwFrameInterval( 3) 1000000 dwFrameInterval( 4) 2000000 dwFrameInterval( 5) 10000000 VideoStreaming Interface Descriptor: bLength 50 bDescriptorType 36 bDescriptorSubtype 5 (FRAME_UNCOMPRESSED) bFrameIndex 5 bmCapabilities 0x00 Still image unsupported wWidth 160 wHeight 120 dwMinBitRate 38400 dwMaxBitRate 1152000 dwMaxVideoFrameBufferSize 38400 dwDefaultFrameInterval 333333 bFrameIntervalType 6 dwFrameInterval( 0) 333333 dwFrameInterval( 1) 500000 dwFrameInterval( 2) 666666 dwFrameInterval( 3) 1000000 dwFrameInterval( 4) 2000000 dwFrameInterval( 5) 10000000 VideoStreaming Interface Descriptor: bLength 26 bDescriptorType 36 bDescriptorSubtype 3 (STILL_IMAGE_FRAME) bEndpointAddress 0 bNumImageSizePatterns 5 wWidth( 0) 640 wHeight( 0) 480 wWidth( 1) 352 wHeight( 1) 288 wWidth( 2) 320 wHeight( 2) 240 wWidth( 3) 176 wHeight( 3) 144 wWidth( 4) 160 wHeight( 4) 120 bNumCompressionPatterns 5 VideoStreaming Interface Descriptor: bLength 6 bDescriptorType 36 bDescriptorSubtype 13 (COLORFORMAT) bColorPrimaries 1 (BT.709,sRGB) bTransferCharacteristics 1 (BT.709) bMatrixCoefficients 4 (SMPTE 170M (BT.601)) Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 1 bNumEndpoints 1 bInterfaceClass 14 Video bInterfaceSubClass 2 Video Streaming bInterfaceProtocol 0 iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes 5 Transfer Type Isochronous Synch Type Asynchronous Usage Type Data wMaxPacketSize 0x0080 1x 128 bytes bInterval 1 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 2 bNumEndpoints 1 bInterfaceClass 14 Video bInterfaceSubClass 2 Video Streaming bInterfaceProtocol 0 iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes 5 Transfer Type Isochronous Synch Type Asynchronous Usage Type Data wMaxPacketSize 0x0100 1x 256 bytes bInterval 1 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 3 bNumEndpoints 1 bInterfaceClass 14 Video bInterfaceSubClass 2 Video Streaming bInterfaceProtocol 0 iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes 5 Transfer Type Isochronous Synch Type Asynchronous Usage Type Data wMaxPacketSize 0x0320 1x 800 bytes bInterval 1 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 4 bNumEndpoints 1 bInterfaceClass 14 Video bInterfaceSubClass 2 Video Streaming bInterfaceProtocol 0 iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes 5 Transfer Type Isochronous Synch Type Asynchronous Usage Type Data wMaxPacketSize 0x0b20 2x 800 bytes bInterval 1 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 5 bNumEndpoints 1 bInterfaceClass 14 Video bInterfaceSubClass 2 Video Streaming bInterfaceProtocol 0 iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes 5 Transfer Type Isochronous Synch Type Asynchronous Usage Type Data wMaxPacketSize 0x1320 3x 800 bytes bInterval 1 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 6 bNumEndpoints 1 bInterfaceClass 14 Video bInterfaceSubClass 2 Video Streaming bInterfaceProtocol 0 iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes 5 Transfer Type Isochronous Synch Type Asynchronous Usage Type Data wMaxPacketSize 0x1400 3x 1024 bytes bInterval 1 Device Qualifier (for other device speed): bLength 10 bDescriptorType 6 bcdUSB 2.00 bDeviceClass 239 Miscellaneous Device bDeviceSubClass 2 ? bDeviceProtocol 1 Interface Association bMaxPacketSize0 64 bNumConfigurations 1 Device Status: 0x0000 (Bus Powered)
Comments
Hi Douglas, On Wednesday 15 April 2009 15:48:08 Douglas Schilling Landgraf wrote: > Hello Laurent, > > On Wed, 15 Apr 2009 11:46:52 +0200 > > Laurent Pinchart <laurent.pinchart@skynet.be> wrote: > > Hi Douglas, > > > > On Wednesday 15 April 2009 09:03:45 Douglas Schilling Landgraf wrote: > > > Hello Laurent, > > > > > > Attached patch for the following: > > > > > > Added Microsoft VX 500 webcam to uvc driver. > > > > > > Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com> > > > > Could you please send me the output of > > > > lsusb -v -d 045e:074a > > > > using usbutils 0.72 or newer (0.73+ preferred) ? > > usbutils-0.73-2 > > > Have you tried the latest driver ? > > Yes > > > The MINMAX quirk isn't required > > anymore for most cameras (although the two supported Microsoft > > webcams still need it, so I doubt it will work as-is). > > Indeed, attached new patch. The new patch shouldn't be needed at all, as it doesn't declare any quirk. The camera should work out of the box using the latest driver. Best regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Laurent, On Mon, 20 Apr 2009 20:07:31 +0200 Laurent Pinchart <laurent.pinchart@skynet.be> wrote: > Hi Douglas, > > On Wednesday 15 April 2009 15:48:08 Douglas Schilling Landgraf wrote: > > Hello Laurent, > > > > On Wed, 15 Apr 2009 11:46:52 +0200 > > > > Laurent Pinchart <laurent.pinchart@skynet.be> wrote: > > > Hi Douglas, > > > > > > On Wednesday 15 April 2009 09:03:45 Douglas Schilling Landgraf > > > wrote: > > > > Hello Laurent, > > > > > > > > Attached patch for the following: > > > > > > > > Added Microsoft VX 500 webcam to uvc driver. > > > > > > > > Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com> > > > > > > Could you please send me the output of > > > > > > lsusb -v -d 045e:074a > > > > > > using usbutils 0.72 or newer (0.73+ preferred) ? > > > > usbutils-0.73-2 > > > > > Have you tried the latest driver ? > > > > Yes > > > > > The MINMAX quirk isn't required > > > anymore for most cameras (although the two supported Microsoft > > > webcams still need it, so I doubt it will work as-is). > > > > Indeed, attached new patch. > > The new patch shouldn't be needed at all, as it doesn't declare any > quirk. The camera should work out of the box using the latest driver. It doesn't work to me. :-( > Best regards, > > Laurent Pinchart > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Douglas, On Friday 24 April 2009 03:05:25 Douglas Schilling Landgraf wrote: > On Mon, 20 Apr 2009 20:07:31 +0200 Laurent Pinchart wrote: > > On Wednesday 15 April 2009 15:48:08 Douglas Schilling Landgraf wrote: > > > On Wed, 15 Apr 2009 11:46:52 +0200 Laurent Pinchart wrote: > > > > > > > > The MINMAX quirk isn't required > > > > anymore for most cameras (although the two supported Microsoft > > > > webcams still need it, so I doubt it will work as-is). > > > > > > Indeed, attached new patch. > > > > The new patch shouldn't be needed at all, as it doesn't declare any > > quirk. The camera should work out of the box using the latest driver. > > It doesn't work to me. :-( That sounds weird. Are you telling me that your camera works when you apply your second patch and doesn't when you don't apply it ? I can understand that the first patch could be required, but the second one shouldn't make any difference. Make sure you removed the first before applying the second. Best regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff -r 0374bd81c2bb linux/drivers/media/video/uvc/uvc_driver.c --- a/linux/drivers/media/video/uvc/uvc_driver.c Tue Apr 14 15:03:39 2009 -0300 +++ b/linux/drivers/media/video/uvc/uvc_driver.c Wed Apr 15 10:40:14 2009 -0300 @@ -1778,6 +1778,15 @@ .bInterfaceSubClass = 1, .bInterfaceProtocol = 0, .driver_info = UVC_QUIRK_PROBE_MINMAX }, + /* Microsoft Lifecam VX-500 */ + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE + | USB_DEVICE_ID_MATCH_INT_INFO, + .idVendor = 0x045e, + .idProduct = 0x074a, + .bInterfaceClass = USB_CLASS_VIDEO, + .bInterfaceSubClass = 1, + .bInterfaceProtocol = 0, + }, /* Microsoft Lifecam VX-7000 */ { .match_flags = USB_DEVICE_ID_MATCH_DEVICE | USB_DEVICE_ID_MATCH_INT_INFO,