| Message ID | 1500518480-3568-1-git-send-email-festevam@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1dY1PE-0008OC-8d; Thu, 20 Jul 2017 02:41:36 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.89/mailfrontend-7) with esmtp id 1dY1PB-0002S4-3C; Thu, 20 Jul 2017 04:41:35 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932591AbdGTClc (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Wed, 19 Jul 2017 22:41:32 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:34986 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932243AbdGTClb (ORCPT <rfc822;linux-media@vger.kernel.org>); Wed, 19 Jul 2017 22:41:31 -0400 Received: by mail-qt0-f194.google.com with SMTP id p25so2040069qtp.2 for <linux-media@vger.kernel.org>; Wed, 19 Jul 2017 19:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=6BbOPvJtI89dohKouxm1f6wRDaoHgdzpkXHCCf2EKcs=; b=I8Kf/u7Q2MVRpswSAyr/diCjUkkZfc6kmmIeFrgWnv0GauvtBWr0q2JndSO2r74CbQ Pm4rOsxz66bEpyQzEUBs0Bv3ncXAMiMpDYUHbapSgto3CFU+xVuURDIxvfLE0MhwH9Pl 7Kj0NVemttZNq/ueIL5fN8+W3h4/TjWRwx17Kx1dtysX7xqVq5Vr9NQLWV00UASIls57 w5211dYgOVWsKIytkAeiZTdLM8O4WcCmBOdzb4HhGpyCgXlAw/GhhxalGoONSaKLiLeT jThGuw68e89b1C8GBpomAWsKQsRUKY39RQ85oCACBmkIa5GPCfZ1w1iLSdLcmAknGg+A yRPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6BbOPvJtI89dohKouxm1f6wRDaoHgdzpkXHCCf2EKcs=; b=Kiv+iIEWdIoUDMvDGYp1jPM9aW0yzTLgN64aPdVqiS7CQGmsaJMDa/fg5L0ZxEEBoK ihatrAsBYMdC5sih7urTGwLqxhdkVkUMa1ef1gzi1RpUfMqFZdyRnDcOcFqvrsmZur71 S4u+Yb6gumIa21b9IBievAf3LnD1V1b1Bl7uMgnJjcceZ3qcY4SwmAvTQsF66cxTKJop FcPBWhRRt0xGP2/K9CfGcCc9bVChHPXUzCrQO+bQumEg7PEnaMCakzKnp6QM4qNkQt5c S7b43S4Uym/55xfze0Oi/K83iHjg7SSGremy2VVzKRaq2jO28pzKKqKF9MuX1vFE/msF ifww== X-Gm-Message-State: AIVw110E8N6sttf6Rgeage9AqD/t4i9zktVS3gLICizqcCGIzM9TvTGA mxB7eWDdlnePhA== X-Received: by 10.237.43.134 with SMTP id e6mr3073742qtd.131.1500518490845; Wed, 19 Jul 2017 19:41:30 -0700 (PDT) Received: from localhost.localdomain ([189.61.213.245]) by smtp.gmail.com with ESMTPSA id w46sm1130257qtw.28.2017.07.19.19.41.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 19 Jul 2017 19:41:30 -0700 (PDT) From: Fabio Estevam <festevam@gmail.com> To: hans.verkuil@cisco.com Cc: slongerbeam@gmail.com, mchehab@s-opensource.com, linux-media@vger.kernel.org, Fabio Estevam <fabio.estevam@nxp.com> Subject: [PATCH] [media] ov5640: Remove unneeded gpiod NULL check Date: Wed, 19 Jul 2017 23:41:20 -0300 Message-Id: <1500518480-3568-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2017.7.20.23615 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_800_899 0, DKIM_SIGNATURE 0, NO_URI_HTTPS 0, __ANY_URI 0, __CC_NAME 0, __CC_NAME_DIFF_FROM_ACC 0, __CC_REAL_NAMES 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_DOMAIN_IN_ANY_CC2 0, __FROM_DOMAIN_IN_RCPT 0, __FROM_GMAIL 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_LIST_ID 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MULTIPLE_RCPTS_CC_X2 0, __NO_HTML_TAG_RAW 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' |
Commit Message
Fabio Estevam
July 20, 2017, 2:41 a.m. UTC
From: Fabio Estevam <fabio.estevam@nxp.com> The gpiod API checks for NULL descriptors, so there is no need to duplicate the check in the driver. Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> --- drivers/media/i2c/ov5640.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Comments
Acked-by: Steve Longerbeam <steve_longerbeam@mentor.com> On 07/19/2017 07:41 PM, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@nxp.com> > > The gpiod API checks for NULL descriptors, so there is no need to > duplicate the check in the driver. > > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> > --- > drivers/media/i2c/ov5640.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c > index 1f5b483..39a2269 100644 > --- a/drivers/media/i2c/ov5640.c > +++ b/drivers/media/i2c/ov5640.c > @@ -1524,8 +1524,7 @@ static int ov5640_restore_mode(struct ov5640_dev *sensor) > > static void ov5640_power(struct ov5640_dev *sensor, bool enable) > { > - if (sensor->pwdn_gpio) > - gpiod_set_value(sensor->pwdn_gpio, enable ? 0 : 1); > + gpiod_set_value(sensor->pwdn_gpio, enable ? 0 : 1); > } > > static void ov5640_reset(struct ov5640_dev *sensor) >
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index 1f5b483..39a2269 100644 --- a/drivers/media/i2c/ov5640.c +++ b/drivers/media/i2c/ov5640.c @@ -1524,8 +1524,7 @@ static int ov5640_restore_mode(struct ov5640_dev *sensor) static void ov5640_power(struct ov5640_dev *sensor, bool enable) { - if (sensor->pwdn_gpio) - gpiod_set_value(sensor->pwdn_gpio, enable ? 0 : 1); + gpiod_set_value(sensor->pwdn_gpio, enable ? 0 : 1); } static void ov5640_reset(struct ov5640_dev *sensor)