Message ID | 1433178847-19850-1-git-send-email-fabio.estevam@freescale.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Hans Verkuil |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1YzUkC-0006jN-B8; Mon, 01 Jun 2015 20:47:28 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.76/mailfrontend-5) with esmtp id 1YzUk9-00061d-6X; Mon, 01 Jun 2015 20:47:27 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752038AbbFASrX (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 1 Jun 2015 14:47:23 -0400 Received: from mail-bn1bbn0105.outbound.protection.outlook.com ([157.56.111.105]:42215 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751874AbbFASrV (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 1 Jun 2015 14:47:21 -0400 Received: from BN3PR0301CA0050.namprd03.prod.outlook.com (10.160.152.146) by BL2PR03MB244.namprd03.prod.outlook.com (10.255.231.26) with Microsoft SMTP Server (TLS) id 15.1.184.10; Mon, 1 Jun 2015 17:14:30 +0000 Received: from BY2FFO11FD030.protection.gbl (2a01:111:f400:7c0c::198) by BN3PR0301CA0050.outlook.office365.com (2a01:111:e400:401e::18) with Microsoft SMTP Server (TLS) id 15.1.172.22 via Frontend Transport; Mon, 1 Jun 2015 17:14:30 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of freescale.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD030.mail.protection.outlook.com (10.1.14.211) with Microsoft SMTP Server (TLS) id 15.1.184.11 via Frontend Transport; Mon, 1 Jun 2015 17:14:29 +0000 Received: from fabio-Latitude-E6410.am.freescale.net ([10.29.244.79]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id t51HERlv017083; Mon, 1 Jun 2015 10:14:28 -0700 From: Fabio Estevam <fabio.estevam@freescale.com> To: <mchehab@osg.samsung.com> CC: <linux-media@vger.kernel.org>, Fabio Estevam <fabio.estevam@freescale.com> Subject: [PATCH] [media] radio-si470x-i2c: Pass the IRQF_ONESHOT flag Date: Mon, 1 Jun 2015 14:14:07 -0300 Message-ID: <1433178847-19850-1-git-send-email-fabio.estevam@freescale.com> X-Mailer: git-send-email 1.9.1 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD030; 1:Lo/jzjsrGp8BWmuI+pdK2iR7CWc33uzMvxoOMnTTVaAJT2KIanE752+YuFBwnIsO6r+eQQKN2J9/vaSheKDL4h1qmtp3V/PngrFDyUm1b7G0KnpmyRm2Y/O07HhaCGIhG8kQ7Rw57Hi3D0wjusNuiIfQfulKFsfwoyCkxYMjQ4K37cDFmJVZPasFkcswSK9g/oNV1D1gracNuX2tKX+lQEDSknJhoa/VdjmfTkjGMDaLHMtSHQMvlSETiA2l9SOTLZHje9xPYeT3nGQ/n6HeSfnrVP29qZf6zl6vfrqkI/xPg3n4HCVmejHNMXHWeRhWsckaWaU6RL04awGrvOEZZw== X-Forefront-Antispam-Report: CIP:192.88.158.2; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(339900001)(189002)(199003)(6806004)(62966003)(50466002)(48376002)(50986999)(230783001)(46102003)(86362001)(87936001)(77156002)(47776003)(85426001)(64706001)(19580395003)(2351001)(33646002)(229853001)(69596002)(19580405001)(104016003)(105606002)(36756003)(106466001)(81156007)(97736004)(4001540100001)(5001830100001)(92566002)(5001920100001)(5001960100002)(107886002)(110136002)(77096005)(5001860100001)(189998001)(68736005)(50226001)(4001430100001); DIR:OUT; SFP:1102; SCL:1; SRVR:BL2PR03MB244; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB244; 2:MtKzPlBznlfzI714+QN78vq7573xzVJMTxcDejedW11SQRg+aAYxMXq+KBwr9cjc; 2:FSMYFt9qdwbaJLEcurTOWvY1nHMFsH48Fi47t+2gDdujqiDfnL7BSH5FXW0TGXWKfyXoQ9PEivODqi7rX/ObLA/lIWNzBNMWeCvzzCubsQ3yiMi7qJ0ck4/QtbOz5xJCzhfxIP43M4a9+sKPpY6zZ0aWsDFnFjLEYvfwa8DxeWcD/Ja0aXj1qPVr21JLMETbJND5pmMVilKYPsAeN8zvpzcUFl5+1ospklEfO5jZeYE=; 6:WadraeReRk6IALzjGJhjHGkRfa8u7Ms1z4VWPihtpKyc6I/OSSz7vCLpGvgRNmDI/D+ZEcg9d+wphFFAhx1yqM0eG4WpNgXib5I1r09YZy9KFePcQsDbiou99ZvBl7fgP3CGRBdWpuAoGBy5EPK16hZFjofwMraKUKODSoza2jPYCSkC2lo3jSshLUbw3jQXNyYsbH0tpmogiII7hSK+o33DfnjeOSfOBUPbqx2jeA+EOwfmb8Sr+EvEIafXuuD3h1+UDWkQp6ASOnpRcZq/FtBNc8mMzUhS6BFukuESFMWGELLP97zvaeqIPH+LenM3LQeHIJCYJPSWYwWrKK9wgw==; 3:kOXEh1V6kQ/UrDRoUJz80LIxhxmPzCUNPbc2S85ENVTLMGSF3gsNQRoB1NoB6xvEaEDlKY0EhAJBYgJyZG5YtnxSsHLCus2HO9+HBwbxAphV1TQ0efPRpn6fnDp0NJ6rpcdWCDt2g+v3fdrb4c7tzsUty+0HCq4sXy4GbY6qJN0ePD+XrTvBcIBcb15erB3jMU8zCaAXXihJSoMyHa3vJDZuzmNpTw0KdPikJQrhwvYZYoc+WsDU2MVGOirWr45qAmybZEx9RiDK1GNnh7lNVqL2va9HuXXyvR0fWPC3w1JsvS4AvkvBmv3hTH+TgDZl X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB244; X-Microsoft-Antispam-PRVS: <BL2PR03MB2440939018B75C816577EB5E9B60@BL2PR03MB244.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(520003)(5005006)(3002001); SRVR:BL2PR03MB244; BCL:0; PCL:0; RULEID:; SRVR:BL2PR03MB244; X-Forefront-PRVS: 05947791E4 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL2PR03MB244; 9:tbmaGYOPVLT+pRiGsJakWrEd9TlEK60Toky3uw37EV7?= =?us-ascii?Q?NmPOO7gye3ecyUMe0nN3PlisOfShIM23i5LhOlGqgHejzODdWHu894bxTivE?= =?us-ascii?Q?jmj69++zKeaMA7R2wKmlWF7bl39CRxAIvX2TQffo7xMzIHQhV6CIidDgrfm1?= =?us-ascii?Q?8o0XI2EaHAyPvvPwkCsk8R7QJLzAcgqpqYKtubLKGsjFrgl6NeFszFlkDSMO?= =?us-ascii?Q?ZhgFFfExNCSbKzoM/iHrPqCJB/KSzUrbWbsxPm47z//1twHnaiMCLDBZ1Wb8?= =?us-ascii?Q?N6tKjnFuftzM6QKds/EpJFQCfoD6yjdt8oZwrrDw1JYHD3J8Ipv8d999ITQz?= =?us-ascii?Q?zVphUYBcFsZrylR//OT/L1INX1tO38ClaqBCvNIxTjpn/PDwi7+6+ad6yhSY?= =?us-ascii?Q?TPC497OOxfXibwSVhD7N6bO3NdVvHPc52774PXFhmnURvUkEA7QDuNB2tcrw?= =?us-ascii?Q?oPGk/kxEc97jWWn1Ns+yX1UV+C+bTV7bZOiFPxB0LY0BhKG4NvcwLJWg83Wz?= =?us-ascii?Q?LPNOi6prfg3v408o36QcgwbVeKRl/qT3NnSUgjbb1lxcCfc0YCpAALO91axU?= =?us-ascii?Q?JJeX41UzyoMrn+qzZbWnEQe/3fJGNEH98AX4G4rmroFq5zPamoVgQVTXoCTT?= =?us-ascii?Q?vJhpGhYWSkbZVWJVe+IGLwysm4O5s+1YZYouv7N4CW0hEsiEOcuf+5u4YoCu?= =?us-ascii?Q?YqSnoNBrRD/6ch6igoIA3/IV8O5a9sbbsqR++UW7Jmrw7Z1T3UA+mWu/HhtY?= =?us-ascii?Q?+UrPjOktifPfsvNe73Km6fn+BjUMmk06w8JuGQCYcmyNMEKPjM/pHM1d0mLl?= =?us-ascii?Q?LXftRsZhi60AmHQb+iwV4ZFQg2L+tHUci9gbkJB0oCG89vF6j/tcizMYqEvR?= =?us-ascii?Q?IX1DSyNI+bCekX7jjKSA/K78g/9ddE+vDaqyA6VRaAfYdA1si/yJ2b8+Y31z?= =?us-ascii?Q?N6/lZEY5o6AyiU8AycxHGdV/nMid9E+jT+xFb3P70kcaV3jUMvYsk8HvRCSC?= =?us-ascii?Q?sxY0AnATPCkVqMuNOogxZruWXKD4aHre/66fjxSei1BpO1Kmi0kV+E9PLTWb?= =?us-ascii?Q?lrkVm1seklzkvh5TSIaLkWTjLpj/6mBfI4XtJTegbE5H4q/0+YshFherHaRa?= =?us-ascii?Q?lvHot350=3D?= X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB244; 3:uxClPlwdji4LEFU5FTvH128ofzdz3uz4r4s5tDN+bct+dfjAR8Bb+8+sGiKwJOWRPvU2QJAbH89mnj6RnSL09ZgDlvyb3RaNV1XqpN6rNjKQSDbkoYd4xJuvs2rC/32MzGPu63nT0SkuqzWDr5ImlQ==; 10:qcNLnkcXroj1+BYO+S3pUzJ9ss2AVBd/0RHnOyCFdUmvbLIPte3R5l0kLRhIB7G0eaKGaWdPWq/nScZkcItEvd+pemnUIQQ/4ykoghWErvc=; 6:1re6XFcv77vFMopjwzIiUaXl2UmQ+4FWexP9SNrZMdG1Wmhn4Uy/PLMQAoOudqi9 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2015 17:14:29.7215 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB244 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.6.1.183915 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1300_1399 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __LINES_OF_YELLING 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Fabio Estevam
June 1, 2015, 5:14 p.m. UTC
Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
threaded IRQs without a primary handler need to be requested with
IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/media/radio/si470x/radio-si470x-i2c.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/radio/si470x/radio-si470x-i2c.c b/drivers/media/radio/si470x/radio-si470x-i2c.c index 2a497c8..49fe845 100644 --- a/drivers/media/radio/si470x/radio-si470x-i2c.c +++ b/drivers/media/radio/si470x/radio-si470x-i2c.c @@ -421,7 +421,8 @@ static int si470x_i2c_probe(struct i2c_client *client, init_waitqueue_head(&radio->read_queue); retval = request_threaded_irq(client->irq, NULL, si470x_i2c_interrupt, - IRQF_TRIGGER_FALLING, DRIVER_NAME, radio); + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, DRIVER_NAME, + radio); if (retval) { dev_err(&client->dev, "Failed to register interrupt\n"); goto err_rds;