[2/3] s5p-mfc-dec: Don't use encoder stop command

Message ID 1418677859-31440-3-git-send-email-nicolas.dufresne@collabora.com (mailing list archive)
State Accepted, archived
Delegated to: Kamil Debski
Headers

Commit Message

Nicolas Dufresne Dec. 15, 2014, 9:10 p.m. UTC
  The decoder should handle V4L2_DEC_CMD_STOP to trigger drain,
but it currently expecting V4L2_ENC_CMD_STOP.

Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
---
 drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Kamil Debski Jan. 8, 2015, 12:50 p.m. UTC | #1
> -----Original Message-----
> From: Nicolas Dufresne [mailto:nicolas.dufresne@collabora.com]
> Sent: Monday, December 15, 2014 10:11 PM
> To: linux-media@vger.kernel.org
> Cc: Kamil Debski; Arun Kumar K; Nicolas Dufresne
> Subject: [PATCH 2/3] s5p-mfc-dec: Don't use encoder stop command
> 
> The decoder should handle V4L2_DEC_CMD_STOP to trigger drain, but it
> currently expecting V4L2_ENC_CMD_STOP.
> 
> Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

Acked-by: Kamil Debski <k.debski@samsung.com>

> ---
>  drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
> b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
> index 99e2e84..98304fc 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
> @@ -816,7 +816,7 @@ static int vidioc_decoder_cmd(struct file *file,
> void *priv,
>  	unsigned long flags;
> 
>  	switch (cmd->cmd) {
> -	case V4L2_ENC_CMD_STOP:
> +	case V4L2_DEC_CMD_STOP:
>  		if (cmd->flags != 0)
>  			return -EINVAL;
> 
> --
> 2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  

Patch

diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
index 99e2e84..98304fc 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
@@ -816,7 +816,7 @@  static int vidioc_decoder_cmd(struct file *file, void *priv,
 	unsigned long flags;
 
 	switch (cmd->cmd) {
-	case V4L2_ENC_CMD_STOP:
+	case V4L2_DEC_CMD_STOP:
 		if (cmd->flags != 0)
 			return -EINVAL;