[3/3,media] coda: Remove devm_kzalloc() error message

Message ID 1412451652-27220-3-git-send-email-festevam@gmail.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Fabio Estevam Oct. 4, 2014, 7:40 p.m. UTC
  From: Fabio Estevam <fabio.estevam@freescale.com>

Core code already prints on OOM errors, so no need to keep this here.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/media/platform/coda/coda-common.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
  

Comments

Philipp Zabel Oct. 5, 2014, 7:37 a.m. UTC | #1
Hi Fabio,

On Sat, Oct 04, 2014 at 04:40:52PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Core code already prints on OOM errors, so no need to keep this here.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

I already have sent this patch:
https://www.mail-archive.com/linux-media@vger.kernel.org/msg80093.html

regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  

Patch

diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c
index 951f1d4..72b624e 100644
--- a/drivers/media/platform/coda/coda-common.c
+++ b/drivers/media/platform/coda/coda-common.c
@@ -1846,11 +1846,8 @@  static int coda_probe(struct platform_device *pdev)
 	int ret, irq;
 
 	dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
-	if (!dev) {
-		dev_err(&pdev->dev, "Not enough memory for %s\n",
-			CODA_NAME);
+	if (!dev)
 		return -ENOMEM;
-	}
 
 	spin_lock_init(&dev->irqlock);
 	INIT_LIST_HEAD(&dev->instances);