mbox

[GIT,PULL,FOR,3.10] DiBxxxx: fixes and improvements

Message ID 1411209.JetyNPSOgp@dibcom294 (mailing list archive)
State Accepted, archived
Headers

Pull-request

git://git.linuxtv.org/pb/media_tree.git/ master

Message

Patrick Boettcher April 22, 2013, 8:12 a.m. UTC 
  Hi Mauro,

These patches contains some fixes and changes for the DiBcom demods and 
SIPs.

Please merge for 3.10 if possible.


The following changes since commit 60d509fa6a9c4653a86ad830e4c4b30360b23f0e:

  Linux 3.9-rc8 (2013-04-21 14:38:45 -0700)

are available in the git repository at:

  git://git.linuxtv.org/pb/media_tree.git/ master

for you to fetch changes up to 7e39d1958b186e5af259b9fde1a006853b4663ab:

  [media] dib8000: do not freeze AGCs by default (2013-04-22 10:06:48 +0200)

----------------------------------------------------------------
Olivier Grenie (6):
      [media] dib8000: enhancement
      [media] dib7000p: enhancement
      [media] dib0090: enhancement
      [media] dib8096: enhancement
      [media] dib7090p: remove the support for the dib7090E
      [media] dib7090p: improve the support of the dib7090 and dib7790

Patrick Boettcher (1):
      [media] dib8000: do not freeze AGCs by default

 drivers/media/dvb-core/dvb-usb-ids.h         |    3 +-
 drivers/media/dvb-frontends/dib0090.c        |  438 ++---
 drivers/media/dvb-frontends/dib7000p.c       |   17 +-
 drivers/media/dvb-frontends/dib7000p.h       |    7 +
 drivers/media/dvb-frontends/dib8000.c        | 2239 +++++++++++++---------
 drivers/media/dvb-frontends/dib8000.h        |    6 +-
 drivers/media/dvb-frontends/dibx000_common.h |    3 +-
 drivers/media/usb/dvb-usb/dib0700_devices.c  |  465 +++--
 8 files changed, 1780 insertions(+), 1398 deletions(-)


regards,
--
Patrick
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Mauro Carvalho Chehab April 27, 2013, 2:28 p.m. UTC | #1 
Hi Patrick,

Em Mon, 22 Apr 2013 10:12:34 +0200
Patrick Boettcher <pboettcher@kernellabs.com> escreveu:

> Hi Mauro,
> 
> These patches contains some fixes and changes for the DiBcom demods and 
> SIPs.
> 
> Please merge for 3.10 if possible.
> 
> 
> The following changes since commit 60d509fa6a9c4653a86ad830e4c4b30360b23f0e:
> 
>   Linux 3.9-rc8 (2013-04-21 14:38:45 -0700)
> 
> are available in the git repository at:
> 
>   git://git.linuxtv.org/pb/media_tree.git/ master

Hmm... I suspect that there's something wrong with those changes.

Testing it with a dib8076 usb stick seems that the code is worse than
before, as it is now harder to get a lock here.

With the previous code:

INFO     Scanning frequency #1 725142857
Carrier(0x03) Signal= 67.46% C/N= 0.00% UCB= 0 postBER= 0
Viterbi(0x05) Signal= 67.08% C/N= 0.00% UCB= 0 postBER= 2097151
Viterbi(0x07) Signal= 67.54% C/N= 0.25% UCB= 165 postBER= 0
Sync   (0x0f) Signal= 67.06% C/N= 0.23% UCB= 151 postBER= 0
Lock   (0x1f) Signal= 67.58% C/N= 0.24% UCB= 160 postBER= 338688
Service #0 (60320) BAND HD channel 57.1.0
Service #1 (60345) BAND 1SEG channel 57.1.1

With the new code:

INFO     Scanning frequency #1 725142857
       (0x00) Signal= 68.80% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.78% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.69% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.82% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.29% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.27% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.28% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.27% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.55% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.50% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.43% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.65% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.75% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.29% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.28% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.25% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.43% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.46% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.43% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.90% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.50% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.28% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.22% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.22% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.43% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.41% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.41% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.96% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.42% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.24% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.22% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.25% C/N= 0.00% UCB= 0 postBER= 0

So, it seems that the changes broke something.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Olivier GRENIE April 28, 2013, 8:28 p.m. UTC | #2 
Hello Mauro,
I will have a look tomorrow and gives a patch. Sorry for this mistake.

regards,
Olivier