Message ID | 1380279558-21651-13-git-send-email-arun.kk@samsung.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Sylwester Nawrocki |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1VPVmS-0004vb-N1; Fri, 27 Sep 2013 13:00:16 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1VPVmQ-0005vo-5w; Fri, 27 Sep 2013 13:00:16 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753233Ab3I0LAC (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 27 Sep 2013 07:00:02 -0400 Received: from mail-pb0-f52.google.com ([209.85.160.52]:51476 "EHLO mail-pb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753187Ab3I0K76 (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 27 Sep 2013 06:59:58 -0400 Received: by mail-pb0-f52.google.com with SMTP id wz12so2390695pbc.39 for <multiple recipients>; Fri, 27 Sep 2013 03:59:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=UmP54ubsTXfeetnuji6my8nVVspm3L5PTLfU8oAlZ7A=; b=oZp3QUL8HbAKDPesq6IbiobC5yr+8LjcL5o84bpYur5SCyDsdojr1RKl2O/deoN6Dx KtHjzIzlFFmh/duj0K/LbkRVFG8G/Ea/ovNZSTGR6ceoEKP2M78l6iL2cMkCbJzwSLTW B1gE/jsZtXYvjyYH3R40/GHQ/tLS8uZopnCFY0N9UpYzH+upc3n8zaBDmogCVUI/Wrnr buYVXa3/KNbToXSqomdjP0PsIuwL+Pie/JsI3MDFWBpADWrQyVxkE8kqAvGmBlroKEEw jRutP92f5AeIzqBZBUF3kfGRtaOMNhJ/Bi0hJ5tT047AVi56KHOoAa0msWjJQyxJQzXM gEXQ== X-Received: by 10.67.15.70 with SMTP id fm6mr10648673pad.109.1380279597988; Fri, 27 Sep 2013 03:59:57 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPSA id xs1sm11724012pac.7.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 27 Sep 2013 03:59:57 -0700 (PDT) From: Arun Kumar K <arun.kk@samsung.com> To: linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org Cc: s.nawrocki@samsung.com, hverkuil@xs4all.nl, swarren@wwwdotorg.org, mark.rutland@arm.com, Pawel.Moll@arm.com, galak@codeaurora.org, a.hajda@samsung.com, sachin.kamat@linaro.org, shaik.ameer@samsung.com, kilyeon.im@samsung.com, arunkk.samsung@gmail.com Subject: [PATCH v9 12/13] V4L: s5k6a3: Change sensor min/max resolutions Date: Fri, 27 Sep 2013 16:29:17 +0530 Message-Id: <1380279558-21651-13-git-send-email-arun.kk@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1380279558-21651-1-git-send-email-arun.kk@samsung.com> References: <1380279558-21651-1-git-send-email-arun.kk@samsung.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.9.27.105115 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1300_1399 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, FROM_NAME_PHRASE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' |
Commit Message
Arun Kumar K
Sept. 27, 2013, 10:59 a.m. UTC
s5k6a3 sensor has actual pixel resolution of 1408x1402 against the active resolution 1392x1392. The real resolution is needed when raw sensor SRGB data is dumped to memory by fimc-lite. Signed-off-by: Arun Kumar K <arun.kk@samsung.com> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- drivers/media/i2c/s5k6a3.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
Comments
Hi Arun, My apologies for the delay. On 27/09/13 12:59, Arun Kumar K wrote: > s5k6a3 sensor has actual pixel resolution of 1408x1402 against > the active resolution 1392x1392. The real resolution is needed > when raw sensor SRGB data is dumped to memory by fimc-lite. > > Signed-off-by: Arun Kumar K <arun.kk@samsung.com> > Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > drivers/media/i2c/s5k6a3.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/i2c/s5k6a3.c b/drivers/media/i2c/s5k6a3.c > index ccbb4fc..e70e217 100644 > --- a/drivers/media/i2c/s5k6a3.c > +++ b/drivers/media/i2c/s5k6a3.c > @@ -25,10 +25,12 @@ > #include <media/v4l2-async.h> > #include <media/v4l2-subdev.h> > > -#define S5K6A3_SENSOR_MAX_WIDTH 1392 > -#define S5K6A3_SENSOR_MAX_HEIGHT 1392 > -#define S5K6A3_SENSOR_MIN_WIDTH 32 > -#define S5K6A3_SENSOR_MIN_HEIGHT 32 > +#define S5K6A3_SENSOR_MAX_WIDTH 1408 > +#define S5K6A3_SENSOR_MAX_HEIGHT 1402 Where these numbers come from ? I digged in the datasheet and the pixel array size for S5K6A3YX is 1412 x 1412 pixels. I will use this value in my updated s5k6a3 driver patch I'm going to post today. And I will drop this patch from this series. > +#define S5K6A3_SENSOR_ACTIVE_WIDTH 1392 > +#define S5K6A3_SENSOR_ACTIVE_HEIGHT 1392 S5K6A3_SENSOR_ACTIVE_* macros are not used anywhere ? Can they be dropped ? Same applies to your S5K4E5 driver patch. > +#define S5K6A3_SENSOR_MIN_WIDTH (32 + 16) > +#define S5K6A3_SENSOR_MIN_HEIGHT (32 + 10) > > #define S5K6A3_DEF_PIX_WIDTH 1296 > #define S5K6A3_DEF_PIX_HEIGHT 732 > Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sylwester, On Thu, Oct 17, 2013 at 10:33 PM, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > Hi Arun, > > My apologies for the delay. > > On 27/09/13 12:59, Arun Kumar K wrote: >> s5k6a3 sensor has actual pixel resolution of 1408x1402 against >> the active resolution 1392x1392. The real resolution is needed >> when raw sensor SRGB data is dumped to memory by fimc-lite. >> >> Signed-off-by: Arun Kumar K <arun.kk@samsung.com> >> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> >> --- >> drivers/media/i2c/s5k6a3.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/media/i2c/s5k6a3.c b/drivers/media/i2c/s5k6a3.c >> index ccbb4fc..e70e217 100644 >> --- a/drivers/media/i2c/s5k6a3.c >> +++ b/drivers/media/i2c/s5k6a3.c >> @@ -25,10 +25,12 @@ >> #include <media/v4l2-async.h> >> #include <media/v4l2-subdev.h> >> >> -#define S5K6A3_SENSOR_MAX_WIDTH 1392 >> -#define S5K6A3_SENSOR_MAX_HEIGHT 1392 >> -#define S5K6A3_SENSOR_MIN_WIDTH 32 >> -#define S5K6A3_SENSOR_MIN_HEIGHT 32 >> +#define S5K6A3_SENSOR_MAX_WIDTH 1408 >> +#define S5K6A3_SENSOR_MAX_HEIGHT 1402 > > Where these numbers come from ? I digged in the datasheet and the pixel > array size for S5K6A3YX is 1412 x 1412 pixels. I will use this value > in my updated s5k6a3 driver patch I'm going to post today. And I will > drop this patch from this series. > These are the numbers used in the the reference driver. I will check if the values 1412x1412 works or not. There are also limitations imposed by the fimc-is firmware too as we just pass on the sensor_id to the firmware and I can see from the firmware log that it assumes max size of 1408x1402 for 6a3. >> +#define S5K6A3_SENSOR_ACTIVE_WIDTH 1392 >> +#define S5K6A3_SENSOR_ACTIVE_HEIGHT 1392 > > > S5K6A3_SENSOR_ACTIVE_* macros are not used anywhere ? Can they be dropped ? > Same applies to your S5K4E5 driver patch. > Yes I will drop them. In my next series, I will drop this 6a3 patch and keep only 4e5 sensor. Regards Arun -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/i2c/s5k6a3.c b/drivers/media/i2c/s5k6a3.c index ccbb4fc..e70e217 100644 --- a/drivers/media/i2c/s5k6a3.c +++ b/drivers/media/i2c/s5k6a3.c @@ -25,10 +25,12 @@ #include <media/v4l2-async.h> #include <media/v4l2-subdev.h> -#define S5K6A3_SENSOR_MAX_WIDTH 1392 -#define S5K6A3_SENSOR_MAX_HEIGHT 1392 -#define S5K6A3_SENSOR_MIN_WIDTH 32 -#define S5K6A3_SENSOR_MIN_HEIGHT 32 +#define S5K6A3_SENSOR_MAX_WIDTH 1408 +#define S5K6A3_SENSOR_MAX_HEIGHT 1402 +#define S5K6A3_SENSOR_ACTIVE_WIDTH 1392 +#define S5K6A3_SENSOR_ACTIVE_HEIGHT 1392 +#define S5K6A3_SENSOR_MIN_WIDTH (32 + 16) +#define S5K6A3_SENSOR_MIN_HEIGHT (32 + 10) #define S5K6A3_DEF_PIX_WIDTH 1296 #define S5K6A3_DEF_PIX_HEIGHT 732