Message ID | 1376856050-30538-1-git-send-email-s.nawrocki@samsung.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Sylwester Nawrocki |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1VB9A1-0004by-73; Sun, 18 Aug 2013 22:01:13 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1VB99y-00034o-5E; Sun, 18 Aug 2013 22:01:12 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754403Ab3HRUBH (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Sun, 18 Aug 2013 16:01:07 -0400 Received: from mail-ea0-f179.google.com ([209.85.215.179]:61433 "EHLO mail-ea0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754178Ab3HRUBG (ORCPT <rfc822;linux-media@vger.kernel.org>); Sun, 18 Aug 2013 16:01:06 -0400 Received: by mail-ea0-f179.google.com with SMTP id b10so1932609eae.10 for <linux-media@vger.kernel.org>; Sun, 18 Aug 2013 13:01:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=R2JfvFPogG8wrzu6tQUw7b4Wn2LVkMftMAdgcAatlOI=; b=SyX7QV43WBtenr40tVA182dV0tb1fIDwWzWu1VC1pqMY/j5NryxiBQmRM5Y+K7Z/kY B5q79K93GvEYrJBQjHxlKdbExVy3bc4n2gz3LvZlzccIGpzCxFw9OI+gpci7xjMOcFsJ rNPE51dC50i3brz82DRvW/vD+gOq0pTNsBWs4pvypZN/i5zJvBWT5H97lJyuVEr8R1l7 wGobQ7SIBvCAugGFlhfsyzP2kS2Y1Q2BEccRajBUJvKffUwUK/Cj7V1A2VIJm05q8l3A wGlRde+qUAIw+SWwFRVHD8BhYdh1UU21KeN9kgWfF6JwkiRse1a8WNSqmHZ4RipT4ij+ ivEA== X-Received: by 10.15.75.73 with SMTP id k49mr16339624eey.36.1376856064865; Sun, 18 Aug 2013 13:01:04 -0700 (PDT) Received: from localhost.localdomain (093105185086.warszawa.vectranet.pl. [93.105.185.86]) by mx.google.com with ESMTPSA id a1sm12265189eem.1.1969.12.31.16.00.00 (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 18 Aug 2013 13:01:04 -0700 (PDT) From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com> To: linux-media@vger.kernel.org Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>, Hans Verkuil <hans.verkuil@cisco.com> Subject: [PATCH] s5p-tv: Include missing v4l2-dv-timings.h header file Date: Sun, 18 Aug 2013 22:00:50 +0200 Message-Id: <1376856050-30538-1-git-send-email-s.nawrocki@samsung.com> X-Mailer: git-send-email 1.7.4.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.8.18.195419 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, CT_TEXT_PLAIN_UTF8_CAPS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __INT_PROD_TV 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' |
Commit Message
Sylwester Nawrocki
Aug. 18, 2013, 8 p.m. UTC
Include the v4l2-dv-timings.h header file which in the s5p-tv driver which
was supposed to be updated in commit 2576415846bcbad3c0a6885fc44f95083710
"[media] v4l2: move dv-timings related code to v4l2-dv-timings.c"
This fixes following build error:
drivers/media/platform/s5p-tv/hdmi_drv.c: In function ‘hdmi_s_dv_timings’:
drivers/media/platform/s5p-tv/hdmi_drv.c:628:3: error: implicit declaration of function ‘v4l_match_dv_timings’
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
drivers/media/platform/s5p-tv/hdmi_drv.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Comments
On 08/18/2013 10:00 PM, Sylwester Nawrocki wrote: > Include the v4l2-dv-timings.h header file which in the s5p-tv driver which > was supposed to be updated in commit 2576415846bcbad3c0a6885fc44f95083710 > "[media] v4l2: move dv-timings related code to v4l2-dv-timings.c" > > This fixes following build error: > > drivers/media/platform/s5p-tv/hdmi_drv.c: In function ‘hdmi_s_dv_timings’: > drivers/media/platform/s5p-tv/hdmi_drv.c:628:3: error: implicit declaration of function ‘v4l_match_dv_timings’ > > Cc: Hans Verkuil <hans.verkuil@cisco.com> Acked-by: Hans Verkuil <hans.verkuil@cisco.com> My apologies for missing this one. Regards, Hans > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > drivers/media/platform/s5p-tv/hdmi_drv.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/media/platform/s5p-tv/hdmi_drv.c b/drivers/media/platform/s5p-tv/hdmi_drv.c > index 1b34c36..f9af2c2 100644 > --- a/drivers/media/platform/s5p-tv/hdmi_drv.c > +++ b/drivers/media/platform/s5p-tv/hdmi_drv.c > @@ -37,6 +37,7 @@ > #include <media/v4l2-common.h> > #include <media/v4l2-dev.h> > #include <media/v4l2-device.h> > +#include <media/v4l2-dv-timings.h> > > #include "regs-hdmi.h" > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Hans, On 08/19/2013 09:15 AM, Hans Verkuil wrote: > On 08/18/2013 10:00 PM, Sylwester Nawrocki wrote: >> Include the v4l2-dv-timings.h header file which in the s5p-tv driver which >> was supposed to be updated in commit 2576415846bcbad3c0a6885fc44f95083710 >> "[media] v4l2: move dv-timings related code to v4l2-dv-timings.c" >> >> This fixes following build error: >> >> drivers/media/platform/s5p-tv/hdmi_drv.c: In function ‘hdmi_s_dv_timings’: >> drivers/media/platform/s5p-tv/hdmi_drv.c:628:3: error: implicit declaration of function ‘v4l_match_dv_timings’ >> >> Cc: Hans Verkuil <hans.verkuil@cisco.com> > > Acked-by: Hans Verkuil <hans.verkuil@cisco.com> > > My apologies for missing this one. That's all right. Shit happens. I was wondering why this error didn't show up in your daily builds. -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed 21 August 2013 10:25:18 Sylwester Nawrocki wrote: > Hi Hans, > > On 08/19/2013 09:15 AM, Hans Verkuil wrote: > > On 08/18/2013 10:00 PM, Sylwester Nawrocki wrote: > >> Include the v4l2-dv-timings.h header file which in the s5p-tv driver which > >> was supposed to be updated in commit 2576415846bcbad3c0a6885fc44f95083710 > >> "[media] v4l2: move dv-timings related code to v4l2-dv-timings.c" > >> > >> This fixes following build error: > >> > >> drivers/media/platform/s5p-tv/hdmi_drv.c: In function ‘hdmi_s_dv_timings’: > >> drivers/media/platform/s5p-tv/hdmi_drv.c:628:3: error: implicit declaration of function ‘v4l_match_dv_timings’ > >> > >> Cc: Hans Verkuil <hans.verkuil@cisco.com> > > > > Acked-by: Hans Verkuil <hans.verkuil@cisco.com> > > > > My apologies for missing this one. > > That's all right. Shit happens. I was wondering why this error > didn't show up in your daily builds. I had a local patch for that and I forgot to remove it. So next time it will show up as an error again. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/s5p-tv/hdmi_drv.c b/drivers/media/platform/s5p-tv/hdmi_drv.c index 1b34c36..f9af2c2 100644 --- a/drivers/media/platform/s5p-tv/hdmi_drv.c +++ b/drivers/media/platform/s5p-tv/hdmi_drv.c @@ -37,6 +37,7 @@ #include <media/v4l2-common.h> #include <media/v4l2-dev.h> #include <media/v4l2-device.h> +#include <media/v4l2-dv-timings.h> #include "regs-hdmi.h"