Message ID | 1356689908-6866-2-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1ToX90-0004HS-HX; Fri, 28 Dec 2012 11:26:26 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp id 1ToX8z-0007IM-CX; Fri, 28 Dec 2012 11:26:26 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752383Ab2L1K0Y (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 28 Dec 2012 05:26:24 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:47524 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752082Ab2L1K0X (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 28 Dec 2012 05:26:23 -0500 Received: by mail-pb0-f46.google.com with SMTP id wy7so5828877pbc.5 for <linux-media@vger.kernel.org>; Fri, 28 Dec 2012 02:26:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=u+NP5DXrAK5z0j4LohlDY+1+GJXuorYDsnY89QweGsM=; b=YkMGDCF0HNZVb+Jit9p9jyiKGjpbzM0xdNCJXtovAJqurLbHNAoNS25fHbplEV7cnm 0q8YGpigNQw5b+RgC5mWBIqCrw1CAVzuCvAGO2tI+X6LgE5i8BpcjAhPn3OwBQa4UZbO 5aSkpP99XZM2cs+Clt5Xt48M4m7umWYMhgWthZBZhNvdMeX6pNJJ5IR+Ze/Vx+EZuJkj oeAQ3Dmm+haM0D7WXNGTjaVlLUDomQPM4bJ+b0FvusJH+8bNOLFo6LFKF8FQcntLecU9 FdOcwfX/R3SJD8SQUdb+7B2KEIQbSaLW1eD3z1oSTfuAb8ZxICYA2njjt+Q6AneoRJHr Nm6Q== X-Received: by 10.66.80.70 with SMTP id p6mr97819472pax.23.1356690383349; Fri, 28 Dec 2012 02:26:23 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id is3sm19485354pbc.6.2012.12.28.02.26.19 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 28 Dec 2012 02:26:22 -0800 (PST) From: Sachin Kamat <sachin.kamat@linaro.org> To: linux-media@vger.kernel.org Cc: k.debski@samsung.com, s.nawrocki@samsung.com, sylvester.nawrocki@gmail.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 2/3] [media] s5p-mfc: Remove redundant 'break' Date: Fri, 28 Dec 2012 15:48:27 +0530 Message-Id: <1356689908-6866-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1356689908-6866-1-git-send-email-sachin.kamat@linaro.org> References: <1356689908-6866-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQmmJ9VfETBzE7SfzXY1n1EmgR+6PcO8V2ADLUhJkhJSbzXEO81JPNAwsmz5a/KJDkX303+a Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.12.28.101815 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' |
Commit Message
Sachin Kamat
Dec. 28, 2012, 10:18 a.m. UTC
The code returns before this statement. Hence not required.
Silences the following smatch message:
drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c:525
s5p_mfc_set_dec_frame_buffer_v5() info: ignoring unreachable code.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
Comments
Hi Sachin, Thank you for your patch. Best wishes,
Thanks Kamil. I assume you have 'Acked' this patch as well :) On 2 January 2013 23:59, Kamil Debski <k.debski@samsung.com> wrote: > Hi Sachin, > > Thank you for your patch. > > Best wishes, > -- > Kamil Debski > Linux Platform Group > Samsung Poland R&D Center > >> -----Original Message----- >> From: linux-media-owner@vger.kernel.org [mailto:linux-media- >> owner@vger.kernel.org] On Behalf Of Sachin Kamat >> Sent: Friday, December 28, 2012 11:18 AM >> To: linux-media@vger.kernel.org >> Cc: k.debski@samsung.com; s.nawrocki@samsung.com; >> sylvester.nawrocki@gmail.com; sachin.kamat@linaro.org; >> patches@linaro.org >> Subject: [PATCH 2/3] [media] s5p-mfc: Remove redundant 'break' >> >> The code returns before this statement. Hence not required. >> Silences the following smatch message: >> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c:525 >> s5p_mfc_set_dec_frame_buffer_v5() info: ignoring unreachable code. >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> --- >> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c >> b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c >> index bb99d3d..b0f277e 100644 >> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c >> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c >> @@ -522,7 +522,6 @@ int s5p_mfc_set_dec_frame_buffer_v5(struct >> s5p_mfc_ctx *ctx) >> mfc_err("Unknown codec for decoding (%x)\n", >> ctx->codec_mode); >> return -EINVAL; >> - break; >> } >> frame_size = ctx->luma_size; >> frame_size_ch = ctx->chroma_size; >> -- >> 1.7.4.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-media" >> in the body of a message to majordomo@vger.kernel.org More majordomo >> info at http://vger.kernel.org/majordomo-info.html > >
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c index bb99d3d..b0f277e 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c @@ -522,7 +522,6 @@ int s5p_mfc_set_dec_frame_buffer_v5(struct s5p_mfc_ctx *ctx) mfc_err("Unknown codec for decoding (%x)\n", ctx->codec_mode); return -EINVAL; - break; } frame_size = ctx->luma_size; frame_size_ch = ctx->chroma_size;