Message ID | 1352115573-8321-1-git-send-email-yamanetoshi@gmail.com (mailing list archive) |
---|---|
State | Rejected, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1TVL22-0006PT-BJ for patchwork@linuxtv.org; Mon, 05 Nov 2012 12:39:54 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp for <patchwork@linuxtv.org> id 1TVL21-0006bR-Ij; Mon, 05 Nov 2012 12:39:54 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753783Ab2KELjj (ORCPT <rfc822;patchwork@linuxtv.org>); Mon, 5 Nov 2012 06:39:39 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:50610 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753489Ab2KELji (ORCPT <rfc822; linux-media@vger.kernel.org>); Mon, 5 Nov 2012 06:39:38 -0500 Received: by mail-pa0-f46.google.com with SMTP id hz1so3872337pad.19 for <multiple recipients>; Mon, 05 Nov 2012 03:39:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=XGzEO2BobBmwNmfZSD5+b9pAvFy4TQ69BuWdMcKgdzQ=; b=xhwe6O4rntpoh3GGbfigRDgno2QqGmPQXrmCY+UPLHMNZhfi/N8Wu0pHMBOVrmLVlq UAA2iEj3bAL5BGwp9yIMJV/8g3Lk0ZkO5UrSdiH494Z9pvmfCvORcyDpjCMcFwl6dt6S UAbA75SXznRnne+OF13+MLxhzKchG/7CghEVK3au2Kb4dO8amQkD5PbVxUIL6Uxdw1f2 7HjYYOmPMx8qqepTWdE1u0cM05ZJ/BNbhogO4vlLgvTJCTt6mcfjD3Rx3rr3InxzNC35 GYS/B1hOI058kduZQbCYef6eF/Y4AtEjXUK/XULbfmA3aGxw+dUvW9oys8X0edozIHXQ MeMg== Received: by 10.66.88.4 with SMTP id bc4mr27516930pab.42.1352115578563; Mon, 05 Nov 2012 03:39:38 -0800 (PST) Received: from localhost (softbank220057059032.bbtec.net. [220.57.59.32]) by mx.google.com with ESMTPS id az8sm10529353pab.24.2012.11.05.03.39.36 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 05 Nov 2012 03:39:38 -0800 (PST) From: YAMANE Toshiaki <yamanetoshi@gmail.com> To: Greg Kroah-Hartman <greg@kroah.com>, linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org, YAMANE Toshiaki <yamanetoshi@gmail.com> Subject: [PATCH 2/2] staging/media: Fix trailing statements should be on next line in go7007/go7007-fw.c Date: Mon, 5 Nov 2012 20:39:33 +0900 Message-Id: <1352115573-8321-1-git-send-email-yamanetoshi@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1352115526-8287-1-git-send-email-yamanetoshi@gmail.com> References: <1352115526-8287-1-git-send-email-yamanetoshi@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.11.5.113315 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' |
Commit Message
YAMANE Toshiaki
Nov. 5, 2012, 11:39 a.m. UTC
fixed below checkpatch error.
- ERROR: trailing statements should be on next line
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
---
drivers/staging/media/go7007/go7007-fw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
Em Mon, 5 Nov 2012 20:39:33 +0900 YAMANE Toshiaki <yamanetoshi@gmail.com> escreveu: > fixed below checkpatch error. > - ERROR: trailing statements should be on next line > > Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com> > --- > drivers/staging/media/go7007/go7007-fw.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/go7007/go7007-fw.c b/drivers/staging/media/go7007/go7007-fw.c > index f99c05b..cfce760 100644 > --- a/drivers/staging/media/go7007/go7007-fw.c > +++ b/drivers/staging/media/go7007/go7007-fw.c > @@ -725,7 +725,8 @@ static int vti_bitlen(struct go7007 *go) > { > unsigned int i, max_time_incr = go->sensor_framerate / go->fps_scale; > > - for (i = 31; (max_time_incr & ((1 << i) - 1)) == max_time_incr; --i); > + for (i = 31; (max_time_incr & ((1 << i) - 1)) == max_time_incr; --i) > + ; Nah, this doesn't sound right to me. IMO, in this specific case, checkpatch.pl did a bad job. At least on my eyes, the first line is easier to read than the other two ones. > return i + 1; > } > Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2012-12-21 at 18:43 -0200, Mauro Carvalho Chehab wrote: > Em Mon, 5 Nov 2012 20:39:33 +0900 > YAMANE Toshiaki <yamanetoshi@gmail.com> escreveu: > > > fixed below checkpatch error. > > - ERROR: trailing statements should be on next line > > > > Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com> > > --- > > drivers/staging/media/go7007/go7007-fw.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/media/go7007/go7007-fw.c b/drivers/staging/media/go7007/go7007-fw.c > > index f99c05b..cfce760 100644 > > --- a/drivers/staging/media/go7007/go7007-fw.c > > +++ b/drivers/staging/media/go7007/go7007-fw.c > > @@ -725,7 +725,8 @@ static int vti_bitlen(struct go7007 *go) > > { > > unsigned int i, max_time_incr = go->sensor_framerate / go->fps_scale; > > > > - for (i = 31; (max_time_incr & ((1 << i) - 1)) == max_time_incr; --i); > > + for (i = 31; (max_time_incr & ((1 << i) - 1)) == max_time_incr; --i) > > + ; > > Nah, this doesn't sound right to me. IMO, in this specific case, > checkpatch.pl did a bad job. Is this even guaranteed to exit the loop? Maybe using ffs would be more sensible. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/media/go7007/go7007-fw.c b/drivers/staging/media/go7007/go7007-fw.c index f99c05b..cfce760 100644 --- a/drivers/staging/media/go7007/go7007-fw.c +++ b/drivers/staging/media/go7007/go7007-fw.c @@ -725,7 +725,8 @@ static int vti_bitlen(struct go7007 *go) { unsigned int i, max_time_incr = go->sensor_framerate / go->fps_scale; - for (i = 31; (max_time_incr & ((1 << i) - 1)) == max_time_incr; --i); + for (i = 31; (max_time_incr & ((1 << i) - 1)) == max_time_incr; --i) + ; return i + 1; }