diff mbox

lg2160: fix off-by-one error in lg216x_write_regs

Message ID 1337614442-31599-1-git-send-email-mkrufky@linuxtv.org (mailing list archive)
State Superseded, archived
Headers

Commit Message

Michael Krufky May 21, 2012, 3:34 p.m. UTC 
  Fix an off-by-one error in lg216x_write_regs, causing the last element
of the lg216x init block to be ignored.  Spotted by Dan Carpenteter.

Thanks-to: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
---
 drivers/media/dvb/frontends/lg2160.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Ira Krufky May 21, 2012, 3:58 p.m. UTC | #1 
eeek!  spelling error in dan's name!  my apologies.  I will correct
this in my tree before I ask Mauro to merge it.

-Mike

On Mon, May 21, 2012 at 11:34 AM, Michael Krufky <mkrufky@kernellabs.com> wrote:
> Fix an off-by-one error in lg216x_write_regs, causing the last element
> of the lg216x init block to be ignored.  Spotted by Dan Carpenteter.
>
> Thanks-to: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
> ---
>  drivers/media/dvb/frontends/lg2160.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb/frontends/lg2160.c b/drivers/media/dvb/frontends/lg2160.c
> index a3ab1a5..cc11260 100644
> --- a/drivers/media/dvb/frontends/lg2160.c
> +++ b/drivers/media/dvb/frontends/lg2160.c
> @@ -126,7 +126,7 @@ static int lg216x_write_regs(struct lg216x_state *state,
>
>        lg_reg("writing %d registers...\n", len);
>
> -       for (i = 0; i < len - 1; i++) {
> +       for (i = 0; i < len; i++) {
>                ret = lg216x_write_reg(state, regs[i].reg, regs[i].val);
>                if (lg_fail(ret))
>                        return ret;
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dan Carpenter May 21, 2012, 4:05 p.m. UTC | #2 
On Mon, May 21, 2012 at 11:58:06AM -0400, Michael Krufky wrote:
> eeek!  spelling error in dan's name!  my apologies.  I will correct
> this in my tree before I ask Mauro to merge it.
> 

Hehe.  Also since you're redoing it, could you change the Thanks-to:
to Reported-by:?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/dvb/frontends/lg2160.c b/drivers/media/dvb/frontends/lg2160.c
index a3ab1a5..cc11260 100644
--- a/drivers/media/dvb/frontends/lg2160.c
+++ b/drivers/media/dvb/frontends/lg2160.c
@@ -126,7 +126,7 @@  static int lg216x_write_regs(struct lg216x_state *state,
 
 	lg_reg("writing %d registers...\n", len);
 
-	for (i = 0; i < len - 1; i++) {
+	for (i = 0; i < len; i++) {
 		ret = lg216x_write_reg(state, regs[i].reg, regs[i].val);
 		if (lg_fail(ret))
 			return ret;