[2/6] v4l/dvb: fix Kconfig dependencies on VIDEO_CAPTURE_DRIVERS

  From: Arnd Bergmann <arnd@arndb.de>

Kconfig warns about unsatisfied dependencies of symbols that
are directly selected.

Many capture drivers depend on DVB capture drivers, which
are hidden behind the CONFIG_DVB_CAPTURE_DRIVERS setting.

The solution here is to enable DVB_CAPTURE_DRIVERS unconditionally
when both DVB and VIDEO_CAPTURE_DRIVERS are enabled.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
 drivers/media/dvb/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
  

Em 03-05-2012 19:22, mathieu.poirier@linaro.org escreveu:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Kconfig warns about unsatisfied dependencies of symbols that
> are directly selected.
> 
> Many capture drivers depend on DVB capture drivers, which
> are hidden behind the CONFIG_DVB_CAPTURE_DRIVERS setting.
> 
> The solution here is to enable DVB_CAPTURE_DRIVERS unconditionally
> when both DVB and VIDEO_CAPTURE_DRIVERS are enabled.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
>  drivers/media/dvb/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/dvb/Kconfig b/drivers/media/dvb/Kconfig
> index f6e40b3..c617996 100644
> --- a/drivers/media/dvb/Kconfig
> +++ b/drivers/media/dvb/Kconfig
> @@ -29,7 +29,7 @@ config DVB_DYNAMIC_MINORS
>  	  If you are unsure about this, say N here.
>  
>  menuconfig DVB_CAPTURE_DRIVERS
> -	bool "DVB/ATSC adapters"
> +	bool "DVB/ATSC adapters" if !VIDEO_CAPTURE_DRIVERS
>  	depends on DVB_CORE
>  	default y
>  	---help---

No, this is not right. Users can select either DVB or V4L2 (or hybrid) 
devices independently.

If now a warning is happening, is because something changed Kconfig
behavior on some non-expected way.

Nack.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  

Em 15-05-2012 07:44, Mauro Carvalho Chehab escreveu:
> Em 03-05-2012 19:22, mathieu.poirier@linaro.org escreveu:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> Kconfig warns about unsatisfied dependencies of symbols that
>> are directly selected.
>>
>> Many capture drivers depend on DVB capture drivers, which
>> are hidden behind the CONFIG_DVB_CAPTURE_DRIVERS setting.
>>
>> The solution here is to enable DVB_CAPTURE_DRIVERS unconditionally
>> when both DVB and VIDEO_CAPTURE_DRIVERS are enabled.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>> ---
>>  drivers/media/dvb/Kconfig |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/media/dvb/Kconfig b/drivers/media/dvb/Kconfig
>> index f6e40b3..c617996 100644
>> --- a/drivers/media/dvb/Kconfig
>> +++ b/drivers/media/dvb/Kconfig
>> @@ -29,7 +29,7 @@ config DVB_DYNAMIC_MINORS
>>  	  If you are unsure about this, say N here.
>>  
>>  menuconfig DVB_CAPTURE_DRIVERS
>> -	bool "DVB/ATSC adapters"
>> +	bool "DVB/ATSC adapters" if !VIDEO_CAPTURE_DRIVERS
>>  	depends on DVB_CORE
>>  	default y
>>  	---help---
> 
> No, this is not right. Users can select either DVB or V4L2 (or hybrid) 
> devices independently.
> 
> If now a warning is happening, is because something changed Kconfig
> behavior on some non-expected way.

I remember a similar bug in the past that it was solved by using a new
Kconfig dialect "visible if".

Not sure it this applies here.

> 
> Nack.
> 
> Regards,
> Mauro

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html