[1/3] media: video: mx2_camera.c: Fix build warning by initializing 'res_emma'

Message ID 1329312801-20501-1-git-send-email-festevam@gmail.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Fabio Estevam Feb. 15, 2012, 1:33 p.m. UTC
  Fix the following build warning:

drivers/media/video/mx2_camera.c: In function 'mx2_camera_probe':
drivers/media/video/mx2_camera.c:1527: warning: 'res_emma' may be used uninitialized in this function

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/media/video/mx2_camera.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
  

Comments

Guennadi Liakhovetski Feb. 20, 2012, 3:13 p.m. UTC | #1
Hi Fabio

On Wed, 15 Feb 2012, Fabio Estevam wrote:

> Fix the following build warning:
> 
> drivers/media/video/mx2_camera.c: In function 'mx2_camera_probe':
> drivers/media/video/mx2_camera.c:1527: warning: 'res_emma' may be used uninitialized in this function

This warning should be no longer occur after recent patches from Javier 
Martin, that should appear in 3.4.

Thanks
Guennadi

> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/media/video/mx2_camera.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c
> index 04aab0c..5888e33 100644
> --- a/drivers/media/video/mx2_camera.c
> +++ b/drivers/media/video/mx2_camera.c
> @@ -1524,7 +1524,7 @@ out:
>  static int __devinit mx2_camera_probe(struct platform_device *pdev)
>  {
>  	struct mx2_camera_dev *pcdev;
> -	struct resource *res_csi, *res_emma;
> +	struct resource *res_csi, *res_emma = NULL;
>  	void __iomem *base_csi;
>  	int irq_csi, irq_emma;
>  	irq_handler_t mx2_cam_irq_handler = cpu_is_mx25() ? mx25_camera_irq
> -- 
> 1.7.1
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  

Patch

diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c
index 04aab0c..5888e33 100644
--- a/drivers/media/video/mx2_camera.c
+++ b/drivers/media/video/mx2_camera.c
@@ -1524,7 +1524,7 @@  out:
 static int __devinit mx2_camera_probe(struct platform_device *pdev)
 {
 	struct mx2_camera_dev *pcdev;
-	struct resource *res_csi, *res_emma;
+	struct resource *res_csi, *res_emma = NULL;
 	void __iomem *base_csi;
 	int irq_csi, irq_emma;
 	irq_handler_t mx2_cam_irq_handler = cpu_is_mx25() ? mx25_camera_irq