| Message ID | 1307458058-29030-7-git-send-email-amber@ti.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Return-path: <mchehab@pedra> Envelope-to: mchehab@pedra Delivery-date: Tue, 07 Jun 2011 11:49:31 -0300 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from <mchehab@pedra>) id 1QTxaz-00037b-DF for mchehab@pedra; Tue, 07 Jun 2011 11:49:30 -0300 Received: from casper.infradead.org [85.118.1.10] by pedra with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Tue, 07 Jun 2011 11:49:29 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QTxaS-0006dG-AH; Tue, 07 Jun 2011 14:48:56 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755013Ab1FGOsE (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Tue, 7 Jun 2011 10:48:04 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:34620 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754942Ab1FGOsD (ORCPT <rfc822;linux-media@vger.kernel.org>); Tue, 7 Jun 2011 10:48:03 -0400 Received: from dlep35.itg.ti.com ([157.170.170.118]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id p57Em3H8004844 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <linux-media@vger.kernel.org>; Tue, 7 Jun 2011 09:48:03 -0500 Received: from dlep26.itg.ti.com (smtp-le.itg.ti.com [157.170.170.27]) by dlep35.itg.ti.com (8.13.7/8.13.8) with ESMTP id p57Em3Cu013491 for <linux-media@vger.kernel.org>; Tue, 7 Jun 2011 09:48:03 -0500 (CDT) Received: from dlee73.ent.ti.com (localhost [127.0.0.1]) by dlep26.itg.ti.com (8.13.8/8.13.8) with ESMTP id p57Em29I025849; Tue, 7 Jun 2011 09:48:02 -0500 (CDT) Received: from dlelxv24.itg.ti.com (172.17.1.199) by DLEE73.ent.ti.com (157.170.170.88) with Microsoft SMTP Server id 8.3.106.1; Tue, 7 Jun 2011 09:48:02 -0500 Received: from legion.dal.design.ti.com (legion.dal.design.ti.com [128.247.22.53]) by dlelxv24.itg.ti.com (8.13.8/8.13.8) with ESMTP id p57Em2Nt016092; Tue, 7 Jun 2011 09:48:02 -0500 Received: from localhost (a0393674u.apr.dhcp.ti.com [172.24.137.179]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id p57Em0f22435; Tue, 7 Jun 2011 09:48:00 -0500 (CDT) From: Amber Jain <amber@ti.com> To: <linux-media@vger.kernel.org> CC: <hvaibhav@ti.com>, <sumit.semwal@ti.com>, Amber Jain <amber@ti.com>, Samreen <samreen@ti.com> Subject: [PATCH 6/6] V4l2: OMAP: VOUT: Minor Cleanup, removing the unnecessary code. Date: Tue, 7 Jun 2011 20:17:38 +0530 Message-ID: <1307458058-29030-7-git-send-email-amber@ti.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1307458058-29030-1-git-send-email-amber@ti.com> References: <1307458058-29030-1-git-send-email-amber@ti.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org Sender: <mchehab@pedra> |
Commit Message
Amber Jain
June 7, 2011, 2:47 p.m. UTC
Minor changes to remove the unused code from omap_vout driver. Signed-off-by: Amber Jain <amber@ti.com> Signed-off-by: Samreen <samreen@ti.com> --- drivers/media/video/omap/omap_vout.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-)
Comments
> -----Original Message----- > From: JAIN, AMBER > Sent: Tuesday, June 07, 2011 8:18 PM > To: linux-media@vger.kernel.org > Cc: Hiremath, Vaibhav; Semwal, Sumit; JAIN, AMBER; Nilofer, Samreen > Subject: [PATCH 6/6] V4l2: OMAP: VOUT: Minor Cleanup, removing the > unnecessary code. > > Minor changes to remove the unused code from omap_vout driver. > > Signed-off-by: Amber Jain <amber@ti.com> > Signed-off-by: Samreen <samreen@ti.com> > --- > drivers/media/video/omap/omap_vout.c | 6 ------ > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/video/omap/omap_vout.c > b/drivers/media/video/omap/omap_vout.c > index 25025a1..4aeea06 100644 > --- a/drivers/media/video/omap/omap_vout.c > +++ b/drivers/media/video/omap/omap_vout.c > @@ -1090,10 +1090,7 @@ static int vidioc_enum_fmt_vid_out_mplane(struct > file *file, void *fh, > struct v4l2_fmtdesc *fmt) > { > int index = fmt->index; > - enum v4l2_buf_type type = fmt->type; > > - fmt->index = index; > - fmt->type = type; [Hiremath, Vaibhav] These lines are not present in main-line driver? Which baseline have you used for this patch? Thanks, Vaibhav > if (index >= NUM_OUTPUT_FORMATS) > return -EINVAL; > > @@ -1268,10 +1265,7 @@ static int vidioc_enum_fmt_vid_overlay(struct file > *file, void *fh, > struct v4l2_fmtdesc *fmt) > { > int index = fmt->index; > - enum v4l2_buf_type type = fmt->type; > > - fmt->index = index; > - fmt->type = type; > if (index >= NUM_OUTPUT_FORMATS) > return -EINVAL; > > -- > 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: Hiremath, Vaibhav > Sent: Wednesday, July 06, 2011 12:38 AM > To: JAIN, AMBER; linux-media@vger.kernel.org > Cc: Semwal, Sumit; Nilofer, Samreen > Subject: RE: [PATCH 6/6] V4l2: OMAP: VOUT: Minor Cleanup, removing the > unnecessary code. > > > > -----Original Message----- > > From: JAIN, AMBER > > Sent: Tuesday, June 07, 2011 8:18 PM > > To: linux-media@vger.kernel.org > > Cc: Hiremath, Vaibhav; Semwal, Sumit; JAIN, AMBER; Nilofer, Samreen > > Subject: [PATCH 6/6] V4l2: OMAP: VOUT: Minor Cleanup, removing the > > unnecessary code. > > > > Minor changes to remove the unused code from omap_vout driver. > > > > Signed-off-by: Amber Jain <amber@ti.com> > > Signed-off-by: Samreen <samreen@ti.com> > > --- > > drivers/media/video/omap/omap_vout.c | 6 ------ > > 1 files changed, 0 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/media/video/omap/omap_vout.c > > b/drivers/media/video/omap/omap_vout.c > > index 25025a1..4aeea06 100644 > > --- a/drivers/media/video/omap/omap_vout.c > > +++ b/drivers/media/video/omap/omap_vout.c > > @@ -1090,10 +1090,7 @@ static int vidioc_enum_fmt_vid_out_mplane(struct > > file *file, void *fh, > > struct v4l2_fmtdesc *fmt) > > { > > int index = fmt->index; > > - enum v4l2_buf_type type = fmt->type; > > > > - fmt->index = index; > > - fmt->type = type; > [Hiremath, Vaibhav] These lines are not present in main-line driver? Which > baseline have you used for this patch? [Hiremath, Vaibhav] My bad, I hit send button quite early. I will queue this up for 3.1. Acked-by: Vaibhav Hiremath <hvaibhav@ti.com> Thanks, Vaibhav > > Thanks, > Vaibhav > > > if (index >= NUM_OUTPUT_FORMATS) > > return -EINVAL; > > > > @@ -1268,10 +1265,7 @@ static int vidioc_enum_fmt_vid_overlay(struct > file > > *file, void *fh, > > struct v4l2_fmtdesc *fmt) > > { > > int index = fmt->index; > > - enum v4l2_buf_type type = fmt->type; > > > > - fmt->index = index; > > - fmt->type = type; > > if (index >= NUM_OUTPUT_FORMATS) > > return -EINVAL; > > > > -- > > 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: Hiremath, Vaibhav > Sent: Wednesday, July 06, 2011 12:38 AM > To: JAIN, AMBER; linux-media@vger.kernel.org > Cc: Semwal, Sumit; Nilofer, Samreen > Subject: RE: [PATCH 6/6] V4l2: OMAP: VOUT: Minor Cleanup, removing the > unnecessary code. > > > > -----Original Message----- > > From: JAIN, AMBER > > Sent: Tuesday, June 07, 2011 8:18 PM > > To: linux-media@vger.kernel.org > > Cc: Hiremath, Vaibhav; Semwal, Sumit; JAIN, AMBER; Nilofer, Samreen > > Subject: [PATCH 6/6] V4l2: OMAP: VOUT: Minor Cleanup, removing the > > unnecessary code. > > > > Minor changes to remove the unused code from omap_vout driver. > > > > Signed-off-by: Amber Jain <amber@ti.com> > > Signed-off-by: Samreen <samreen@ti.com> > > --- > > drivers/media/video/omap/omap_vout.c | 6 ------ > > 1 files changed, 0 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/media/video/omap/omap_vout.c > > b/drivers/media/video/omap/omap_vout.c > > index 25025a1..4aeea06 100644 > > --- a/drivers/media/video/omap/omap_vout.c > > +++ b/drivers/media/video/omap/omap_vout.c > > @@ -1090,10 +1090,7 @@ static int vidioc_enum_fmt_vid_out_mplane(struct > > file *file, void *fh, > > struct v4l2_fmtdesc *fmt) > > { > > int index = fmt->index; > > - enum v4l2_buf_type type = fmt->type; > > > > - fmt->index = index; > > - fmt->type = type; > [Hiremath, Vaibhav] These lines are not present in main-line driver? Which > baseline have you used for this patch? I checked it again, it is present in mainline. Can you please check 3.0-rc6 branch. Thanks, Amber > > Thanks, > Vaibhav > > > if (index >= NUM_OUTPUT_FORMATS) > > return -EINVAL; > > > > @@ -1268,10 +1265,7 @@ static int vidioc_enum_fmt_vid_overlay(struct > file > > *file, void *fh, > > struct v4l2_fmtdesc *fmt) > > { > > int index = fmt->index; > > - enum v4l2_buf_type type = fmt->type; > > > > - fmt->index = index; > > - fmt->type = type; > > if (index >= NUM_OUTPUT_FORMATS) > > return -EINVAL; > > > > -- > > 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/video/omap/omap_vout.c b/drivers/media/video/omap/omap_vout.c index 25025a1..4aeea06 100644 --- a/drivers/media/video/omap/omap_vout.c +++ b/drivers/media/video/omap/omap_vout.c @@ -1090,10 +1090,7 @@ static int vidioc_enum_fmt_vid_out_mplane(struct file *file, void *fh, struct v4l2_fmtdesc *fmt) { int index = fmt->index; - enum v4l2_buf_type type = fmt->type; - fmt->index = index; - fmt->type = type; if (index >= NUM_OUTPUT_FORMATS) return -EINVAL; @@ -1268,10 +1265,7 @@ static int vidioc_enum_fmt_vid_overlay(struct file *file, void *fh, struct v4l2_fmtdesc *fmt) { int index = fmt->index; - enum v4l2_buf_type type = fmt->type; - fmt->index = index; - fmt->type = type; if (index >= NUM_OUTPUT_FORMATS) return -EINVAL;