Message ID | 1293750484-1161-3-git-send-email-justinmattock@gmail.com (mailing list archive) |
---|---|
State | Not Applicable, archived |
Headers |
Return-path: <mchehab@gaivota> Envelope-to: mchehab@gaivota Delivery-date: Thu, 30 Dec 2010 22:11:44 -0200 Received: from mchehab by gaivota with local (Exim 4.72) (envelope-from <mchehab@gaivota>) id 1PYSau-0000Sc-AW for mchehab@gaivota; Thu, 30 Dec 2010 22:11:44 -0200 Received: from casper.infradead.org [85.118.1.10] by gaivota with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Thu, 30 Dec 2010 22:11:44 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PYRhL-00045k-C7; Thu, 30 Dec 2010 23:14:19 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753722Ab0L3XNf (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Thu, 30 Dec 2010 18:13:35 -0500 Received: from mail-gw0-f46.google.com ([74.125.83.46]:64019 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752309Ab0L3XIM (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 30 Dec 2010 18:08:12 -0500 Received: by mail-gw0-f46.google.com with SMTP id 20so5484626gwj.19 for <multiple recipients>; Thu, 30 Dec 2010 15:08:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=Bn0ohyPCjopsjVISGoNX5AfFI0nxYVp+/qhpUmt8pEk=; b=VtiXwSBvGp/VT+LBSW0yQbYTfczPRbBMvEdKKdXPT8qzZUhm3guADp+OgItOZqZTd2 hto/NAhAYpxm8GScrAPb8O7s2BquAr6L0nOVsyYVziF3uj0BoW9O8yqX/fzx6L1XcgF/ 6PngNxn4F6nD5nHgnpROn1TOMybohKoMXtBkA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=KjmAF8j6s/MbWLAPg5etZNLszciO+z+jB51CQp2m8LkTETEeBve/xu7YSoWH+nQrxC ri/TgY007bC32t+Cpx3zWcHXL2a30r4A2KHUVr7VHBrr8uxdMUIvFAm4NRPSYibcTTjc 60bKhHN6Ie4P0MNeUHPVUBMJ7SYb6e//oyWNo= Received: by 10.90.113.10 with SMTP id l10mr3758814agc.121.1293750491166; Thu, 30 Dec 2010 15:08:11 -0800 (PST) Received: from localhost.localdomain ([76.91.45.220]) by mx.google.com with ESMTPS id z23sm5611318yhc.24.2010.12.30.15.08.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 30 Dec 2010 15:08:10 -0800 (PST) From: "Justin P. Mattock" <justinmattock@gmail.com> To: trivial@kernel.org Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, ivtv-devel@ivtvdriver.org, linux-media@vger.kernel.org, linux-wireless@vger.kernel.org, linux-scsi@vger.kernel.org, spi-devel-general@lists.sourceforge.net, devel@driverdev.osuosl.org, linux-usb@vger.kernel.org, "Justin P. Mattock" <justinmattock@gmail.com> Subject: [PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h Typo change diable to disable. Date: Thu, 30 Dec 2010 15:07:52 -0800 Message-Id: <1293750484-1161-3-git-send-email-justinmattock@gmail.com> X-Mailer: git-send-email 1.6.5.2.180.gc5b3e In-Reply-To: <1293750484-1161-2-git-send-email-justinmattock@gmail.com> References: <1293750484-1161-1-git-send-email-justinmattock@gmail.com> <1293750484-1161-2-git-send-email-justinmattock@gmail.com> Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org Sender: Mauro Carvalho Chehab <mchehab@gaivota> |
Commit Message
Justin P. Mattock
Dec. 30, 2010, 11:07 p.m. UTC
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
drivers/staging/rtl8187se/r8180_hw.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Comments
On 12/30/2010 05:07 PM, Justin P. Mattock wrote: > The below patch fixes a typo "diable" to "disable". Please let me know if this > is correct or not. > > Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> > > --- ACKed-by: Larry Finger <Larry.Finger@lwfinger.net> > drivers/staging/rtl8187se/r8180_hw.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/rtl8187se/r8180_hw.h b/drivers/staging/rtl8187se/r8180_hw.h > index 3fca144..2911d40 100644 > --- a/drivers/staging/rtl8187se/r8180_hw.h > +++ b/drivers/staging/rtl8187se/r8180_hw.h > @@ -554,7 +554,7 @@ > /* by amy for power save */ > /* by amy for antenna */ > #define EEPROM_SW_REVD_OFFSET 0x3f > -/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable. */ > +/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled. */ > #define EEPROM_SW_AD_MASK 0x0300 > #define EEPROM_SW_AD_ENABLE 0x0100 > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 30 Dec 2010, Justin P. Mattock wrote: > The below patch fixes a typo "diable" to "disable". Please let me know if this > is correct or not. > > Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> > > --- > drivers/staging/rtl8187se/r8180_hw.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/rtl8187se/r8180_hw.h b/drivers/staging/rtl8187se/r8180_hw.h > index 3fca144..2911d40 100644 > --- a/drivers/staging/rtl8187se/r8180_hw.h > +++ b/drivers/staging/rtl8187se/r8180_hw.h > @@ -554,7 +554,7 @@ > /* by amy for power save */ > /* by amy for antenna */ > #define EEPROM_SW_REVD_OFFSET 0x3f > -/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable. */ > +/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled. */ I think, "other values disable" was what you meant? Finn > #define EEPROM_SW_AD_MASK 0x0300 > #define EEPROM_SW_AD_ENABLE 0x0100 > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/31/2010 10:48 PM, Finn Thain wrote: > > On Thu, 30 Dec 2010, Justin P. Mattock wrote: > >> The below patch fixes a typo "diable" to "disable". Please let me know if this >> is correct or not. >> >> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com> >> >> --- >> drivers/staging/rtl8187se/r8180_hw.h | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/staging/rtl8187se/r8180_hw.h b/drivers/staging/rtl8187se/r8180_hw.h >> index 3fca144..2911d40 100644 >> --- a/drivers/staging/rtl8187se/r8180_hw.h >> +++ b/drivers/staging/rtl8187se/r8180_hw.h >> @@ -554,7 +554,7 @@ >> /* by amy for power save */ >> /* by amy for antenna */ >> #define EEPROM_SW_REVD_OFFSET 0x3f >> -/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable. */ >> +/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled. */ > > I think, "other values disable" was what you meant? > > Finn > >> #define EEPROM_SW_AD_MASK 0x0300 >> #define EEPROM_SW_AD_ENABLE 0x0100 >> >> > no! I changed it to disabled to make it proper.. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 31, 2010 at 11:43:30PM -0800, Justin P. Mattock wrote: > On 12/31/2010 10:48 PM, Finn Thain wrote: > >>-/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable. */ > >>+/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled. */ > > > >I think, "other values disable" was what you meant? > > > >Finn > > > >> #define EEPROM_SW_AD_MASK 0x0300 > >> #define EEPROM_SW_AD_ENABLE 0x0100 > >> > >> > > > > no! I changed it to disabled to make it proper.. Finn is obviously right, but maybe a compromise would be: Only the value EEPROM_SW_AD_ENABLE means "enable", other values mean "disable". regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/01/2011 01:09 AM, Dan Carpenter wrote: > On Fri, Dec 31, 2010 at 11:43:30PM -0800, Justin P. Mattock wrote: >> On 12/31/2010 10:48 PM, Finn Thain wrote: >>>> -/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable. */ >>>> +/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled. */ >>> >>> I think, "other values disable" was what you meant? >>> >>> Finn >>> >>>> #define EEPROM_SW_AD_MASK 0x0300 >>>> #define EEPROM_SW_AD_ENABLE 0x0100 >>>> >>>> >>> >> >> no! I changed it to disabled to make it proper.. > > Finn is obviously right, but maybe a compromise would be: > > Only the value EEPROM_SW_AD_ENABLE means "enable", other values mean > "disable". > > regards, > dan carpenter > ahh.. I see what you your saying now.. alright let me send this out that way.. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/rtl8187se/r8180_hw.h b/drivers/staging/rtl8187se/r8180_hw.h index 3fca144..2911d40 100644 --- a/drivers/staging/rtl8187se/r8180_hw.h +++ b/drivers/staging/rtl8187se/r8180_hw.h @@ -554,7 +554,7 @@ /* by amy for power save */ /* by amy for antenna */ #define EEPROM_SW_REVD_OFFSET 0x3f -/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable. */ +/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled. */ #define EEPROM_SW_AD_MASK 0x0300 #define EEPROM_SW_AD_ENABLE 0x0100