| Message ID | 1280489933-20865-7-git-send-email-maximlevitsky@gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Return-path: <linux-media-owner@vger.kernel.org> Envelope-to: mchehab@infradead.org Delivery-date: Fri, 30 Jul 2010 11:39:23 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Fri, 30 Jul 2010 09:07:19 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1Oenvv-0005HB-Gc; Fri, 30 Jul 2010 11:39:23 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758520Ab0G3LjT (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Fri, 30 Jul 2010 07:39:19 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:45907 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758488Ab0G3LjP (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 30 Jul 2010 07:39:15 -0400 Received: by mail-fx0-f46.google.com with SMTP id 14so798180fxm.19 for <multiple recipients>; Fri, 30 Jul 2010 04:39:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=0NBfodEt9gMNFoOP+Kdp0Mbqr1JC0ygByNyc69QHBbo=; b=PZ5DZ2YLE5OxUsJNu8KfCZmwXsXKVlMSR3+2wrUtv1WUcfKSZbld5QFlcBI4f6fjWo EB6GOJjQWpaHFXzRItV8Om8AHA0HQRIQd4KI9boZjlvb1pwDswSa3wTsTgfGh4hG2A9C Shjiep5OB8/+hiPh7Ni9gZQwzJpyrgHSEFpTg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=viJ53jZYF+wsDrCh9gBluo/gXVW+504NbZdmblKPmRwL4GaBmu/bdofSA5YCrosnCJ +m0KW4hGhjvaof1lPpp6lqUaDeyZHT+aI7u6iDQ/kmMyvh5SWEBZnLVMhO4kfa1zM8Ko qHKs1uCUgPkSeABFX6sea0PaBQyqsAm0WZw98= Received: by 10.223.114.69 with SMTP id d5mr1847584faq.43.1280489953987; Fri, 30 Jul 2010 04:39:13 -0700 (PDT) Received: from localhost.localdomain (IGLD-84-228-19-51.inter.net.il [84.228.19.51]) by mx.google.com with ESMTPS id q17sm767482faa.21.2010.07.30.04.39.12 (version=SSLv3 cipher=RC4-MD5); Fri, 30 Jul 2010 04:39:13 -0700 (PDT) From: Maxim Levitsky <maximlevitsky@gmail.com> To: lirc-list@lists.sourceforge.net Cc: Jarod Wilson <jarod@wilsonet.com>, linux-input@vger.kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab <mchehab@redhat.com>, Christoph Bartelmus <lirc@bartelmus.de>, Maxim Levitsky <maximlevitsky@gmail.com> Subject: [PATCH 06/13] IR: nec decoder: fix repeat. Date: Fri, 30 Jul 2010 14:38:46 +0300 Message-Id: <1280489933-20865-7-git-send-email-maximlevitsky@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1280489933-20865-1-git-send-email-maximlevitsky@gmail.com> References: <1280489933-20865-1-git-send-email-maximlevitsky@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Maxim Levitsky
July 30, 2010, 11:38 a.m. UTC
Repeat space is 4 units, not 8.
Current code would never trigger a repeat.
However that isn't true for NECX, so repeat there
must be handled differently.
Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
---
drivers/media/IR/ir-nec-decoder.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Comments
Em 30-07-2010 08:38, Maxim Levitsky escreveu: > Repeat space is 4 units, not 8. > Current code would never trigger a repeat. Yes, this fixed the issue: Jul 30 16:53:52 agua kernel: [24343.507577] ir_getkeycode: unknown key for scancode 0x0009 Jul 30 16:53:52 agua kernel: [24343.507588] ir_nec_decode: Repeat last key Jul 30 16:53:52 agua kernel: [24343.507590] ir_nec_decode: NEC scancode 0x0009 Jul 30 16:53:52 agua kernel: [24343.507592] ir_getkeycode: unknown key for scancode 0x0009 Jul 30 16:53:52 agua kernel: [24343.507595] ir_nec_decode: Repeat last key Jul 30 16:53:52 agua kernel: [24343.724242] ir_nec_decode: NEC scancode 0x0009 Jul 30 16:53:52 agua kernel: [24343.724246] ir_getkeycode: unknown key for scancode 0x0009 Jul 30 16:53:52 agua kernel: [24343.724257] ir_nec_decode: Repeat last key Jul 30 16:53:52 agua kernel: [24343.724259] ir_nec_decode: NEC scancode 0x0009 Jul 30 16:53:52 agua kernel: [24343.724261] ir_getkeycode: unknown key for scancode 0x0009 Jul 30 16:53:52 agua kernel: [24343.724264] ir_nec_decode: Repeat last key Jul 30 16:53:53 agua kernel: [24343.937576] ir_nec_decode: NEC scancode 0x0009 Jul 30 16:53:53 agua kernel: [24343.937580] ir_getkeycode: unknown key for scancode 0x0009 Jul 30 16:53:53 agua kernel: [24343.937592] ir_nec_decode: Repeat last key Jul 30 16:53:53 agua kernel: [24343.937594] ir_nec_decode: NEC scancode 0x0009 Jul 30 16:53:53 agua kernel: [24343.937596] ir_getkeycode: unknown key for scancode 0x0009 Jul 30 16:53:53 agua kernel: [24343.937599] ir_nec_decode: Repeat last key > > However that isn't true for NECX, so repeat there > must be handled differently. > > Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com> Please preserve Andy's reviewed-by: when re-submitting a patch. > --- > drivers/media/IR/ir-nec-decoder.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/IR/ir-nec-decoder.c b/drivers/media/IR/ir-nec-decoder.c > index 52e0f37..1c0cf03 100644 > --- a/drivers/media/IR/ir-nec-decoder.c > +++ b/drivers/media/IR/ir-nec-decoder.c > @@ -20,7 +20,7 @@ > #define NEC_HEADER_PULSE (16 * NEC_UNIT) > #define NECX_HEADER_PULSE (8 * NEC_UNIT) /* Less common NEC variant */ > #define NEC_HEADER_SPACE (8 * NEC_UNIT) > -#define NEC_REPEAT_SPACE (8 * NEC_UNIT) > +#define NEC_REPEAT_SPACE (4 * NEC_UNIT) > #define NEC_BIT_PULSE (1 * NEC_UNIT) > #define NEC_BIT_0_SPACE (1 * NEC_UNIT) > #define NEC_BIT_1_SPACE (3 * NEC_UNIT) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2010-07-30 at 16:36 -0300, Mauro Carvalho Chehab wrote: > Em 30-07-2010 08:38, Maxim Levitsky escreveu: > > Repeat space is 4 units, not 8. > > Current code would never trigger a repeat. > > Yes, this fixed the issue: > > Jul 30 16:53:52 agua kernel: [24343.507577] ir_getkeycode: unknown key for scancode 0x0009 > Jul 30 16:53:52 agua kernel: [24343.507588] ir_nec_decode: Repeat last key > Jul 30 16:53:52 agua kernel: [24343.507590] ir_nec_decode: NEC scancode 0x0009 > Jul 30 16:53:52 agua kernel: [24343.507592] ir_getkeycode: unknown key for scancode 0x0009 > Jul 30 16:53:52 agua kernel: [24343.507595] ir_nec_decode: Repeat last key > Jul 30 16:53:52 agua kernel: [24343.724242] ir_nec_decode: NEC scancode 0x0009 > Jul 30 16:53:52 agua kernel: [24343.724246] ir_getkeycode: unknown key for scancode 0x0009 > Jul 30 16:53:52 agua kernel: [24343.724257] ir_nec_decode: Repeat last key > Jul 30 16:53:52 agua kernel: [24343.724259] ir_nec_decode: NEC scancode 0x0009 > Jul 30 16:53:52 agua kernel: [24343.724261] ir_getkeycode: unknown key for scancode 0x0009 > Jul 30 16:53:52 agua kernel: [24343.724264] ir_nec_decode: Repeat last key > Jul 30 16:53:53 agua kernel: [24343.937576] ir_nec_decode: NEC scancode 0x0009 > Jul 30 16:53:53 agua kernel: [24343.937580] ir_getkeycode: unknown key for scancode 0x0009 > Jul 30 16:53:53 agua kernel: [24343.937592] ir_nec_decode: Repeat last key > Jul 30 16:53:53 agua kernel: [24343.937594] ir_nec_decode: NEC scancode 0x0009 > Jul 30 16:53:53 agua kernel: [24343.937596] ir_getkeycode: unknown key for scancode 0x0009 > Jul 30 16:53:53 agua kernel: [24343.937599] ir_nec_decode: Repeat last key > > > > > However that isn't true for NECX, so repeat there > > must be handled differently. > > > > Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com> > > Please preserve Andy's reviewed-by: when re-submitting a patch. Yep, sorry about that! Although, if I change a patch, I shouldn't preserve signed-off, reviewed-by, lines, right? Best regards, Maxim Levitsky > > > --- > > drivers/media/IR/ir-nec-decoder.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/media/IR/ir-nec-decoder.c b/drivers/media/IR/ir-nec-decoder.c > > index 52e0f37..1c0cf03 100644 > > --- a/drivers/media/IR/ir-nec-decoder.c > > +++ b/drivers/media/IR/ir-nec-decoder.c > > @@ -20,7 +20,7 @@ > > #define NEC_HEADER_PULSE (16 * NEC_UNIT) > > #define NECX_HEADER_PULSE (8 * NEC_UNIT) /* Less common NEC variant */ > > #define NEC_HEADER_SPACE (8 * NEC_UNIT) > > -#define NEC_REPEAT_SPACE (8 * NEC_UNIT) > > +#define NEC_REPEAT_SPACE (4 * NEC_UNIT) > > #define NEC_BIT_PULSE (1 * NEC_UNIT) > > #define NEC_BIT_0_SPACE (1 * NEC_UNIT) > > #define NEC_BIT_1_SPACE (3 * NEC_UNIT) > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/IR/ir-nec-decoder.c b/drivers/media/IR/ir-nec-decoder.c index 52e0f37..1c0cf03 100644 --- a/drivers/media/IR/ir-nec-decoder.c +++ b/drivers/media/IR/ir-nec-decoder.c @@ -20,7 +20,7 @@ #define NEC_HEADER_PULSE (16 * NEC_UNIT) #define NECX_HEADER_PULSE (8 * NEC_UNIT) /* Less common NEC variant */ #define NEC_HEADER_SPACE (8 * NEC_UNIT) -#define NEC_REPEAT_SPACE (8 * NEC_UNIT) +#define NEC_REPEAT_SPACE (4 * NEC_UNIT) #define NEC_BIT_PULSE (1 * NEC_UNIT) #define NEC_BIT_0_SPACE (1 * NEC_UNIT) #define NEC_BIT_1_SPACE (3 * NEC_UNIT)