| Message ID | 1276547208-26569-8-git-send-email-justinmattock@gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Return-path: <linux-media-owner@vger.kernel.org> Envelope-to: mchehab@infradead.org Delivery-date: Mon, 14 Jun 2010 20:28:20 +0000 Received: from bombadil.infradead.org [18.85.46.34] by localhost with IMAP (fetchmail-6.3.17) for <mchehab@localhost> (single-drop); Tue, 15 Jun 2010 07:59:47 +0300 (EEST) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1OOGGa-0004yF-Et; Mon, 14 Jun 2010 20:28:20 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756073Ab0FNU1d (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Mon, 14 Jun 2010 16:27:33 -0400 Received: from mail-px0-f174.google.com ([209.85.212.174]:65524 "EHLO mail-px0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755885Ab0FNU1D (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 14 Jun 2010 16:27:03 -0400 Received: by mail-px0-f174.google.com with SMTP id 8so3026668pxi.19 for <multiple recipients>; Mon, 14 Jun 2010 13:27:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=20VJNbR19y23JUmMrJeST0EMJaYCB8SFr/UyCwweIUk=; b=B0rdwYeV6Mp5hN10CMbxjpkEk+HeG5mo9i+220lsE/+rl85CSH/c0mHRFs9prJa5YJ vTk47ev2DjFKrRScMtEfaoNelKBtkF7oMJUNzeOGo9FR7zYivRAxaGPD4upR4+TKoUqk D4novXZnO1w2myDrBcOgRwlAeqkjmjpt2przM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=Px4K/mnufaYKB41cv3ApPrz4ZtmD8OeeuQHUjweoACuHKkEqdojDQ1I3+ZY82hx2lW ygSIKLVCFOzBQXhtUPnVUKrJLTKm60wU6PgZTlmB2ifCUOzPhIQpJLx4SMFezTLeC0hD o4y+UWYejfYkTyV1/haLmj8fKZalyfqYaJGPY= Received: by 10.115.66.9 with SMTP id t9mr4932450wak.78.1276547222528; Mon, 14 Jun 2010 13:27:02 -0700 (PDT) Received: from localhost.localdomain ([76.91.45.220]) by mx.google.com with ESMTPS id r20sm58982854wam.5.2010.06.14.13.27.00 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 14 Jun 2010 13:27:01 -0700 (PDT) From: "Justin P. Mattock" <justinmattock@gmail.com> To: linux-kernel@vger.kernel.org Cc: reiserfs-devel@vger.kernel.org, linux-bluetooth@vger.kernel.org, clemens@ladisch.de, debora@linux.vnet.ibm.com, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-media@vger.kernel.org, "Justin P. Mattock" <justinmattock@gmail.com> Subject: [PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' set but not used Date: Mon, 14 Jun 2010 13:26:47 -0700 Message-Id: <1276547208-26569-8-git-send-email-justinmattock@gmail.com> X-Mailer: git-send-email 1.7.1.rc1.21.gf3bd6 In-Reply-To: <1276547208-26569-1-git-send-email-justinmattock@gmail.com> References: <1276547208-26569-1-git-send-email-justinmattock@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Justin P. Mattock
June 14, 2010, 8:26 p.m. UTC
Temporary fix until something is resolved
to fix the below warning:
CC [M] drivers/ieee1394/sbp2.o
drivers/ieee1394/sbp2.c: In function 'sbp2_parse_unit_directory':
drivers/ieee1394/sbp2.c:1353:6: warning: variable 'unit_characteristics' set but not used
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
drivers/ieee1394/sbp2.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
Comments
On Mon, 14 Jun 2010 13:26:47 -0700, Justin P. Mattock wrote: > Temporary fix until something is resolved This is wrong by design, sorry. Warnings aren't blocking, and thus need no "temporary fix". Such temporary fixes would be only hiding the warning, cancelling the good work of gcc developers. Nack nack nack. > to fix the below warning: > CC [M] drivers/ieee1394/sbp2.o > drivers/ieee1394/sbp2.c: In function 'sbp2_parse_unit_directory': > drivers/ieee1394/sbp2.c:1353:6: warning: variable 'unit_characteristics' set but not used > Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> > > --- > drivers/ieee1394/sbp2.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c > index 4565cb5..fcf8bd5 100644 > --- a/drivers/ieee1394/sbp2.c > +++ b/drivers/ieee1394/sbp2.c > @@ -1356,6 +1356,8 @@ static void sbp2_parse_unit_directory(struct sbp2_lu *lu, > > management_agent_addr = 0; > unit_characteristics = 0; > + if (!unit_characteristics) > + unit_characteristics = 0; > firmware_revision = SBP2_ROM_VALUE_MISSING; > model = ud->flags & UNIT_DIRECTORY_MODEL_ID ? > ud->model_id : SBP2_ROM_VALUE_MISSING;
On 06/15/2010 04:38 AM, Jean Delvare wrote: > On Mon, 14 Jun 2010 13:26:47 -0700, Justin P. Mattock wrote: >> Temporary fix until something is resolved > > This is wrong by design, sorry. Warnings aren't blocking, and thus need > no "temporary fix". Such temporary fixes would be only hiding the > warning, cancelling the good work of gcc developers. Nack nack nack. > o.k. >> to fix the below warning: >> CC [M] drivers/ieee1394/sbp2.o >> drivers/ieee1394/sbp2.c: In function 'sbp2_parse_unit_directory': >> drivers/ieee1394/sbp2.c:1353:6: warning: variable 'unit_characteristics' set but not used >> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com> >> >> --- >> drivers/ieee1394/sbp2.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c >> index 4565cb5..fcf8bd5 100644 >> --- a/drivers/ieee1394/sbp2.c >> +++ b/drivers/ieee1394/sbp2.c >> @@ -1356,6 +1356,8 @@ static void sbp2_parse_unit_directory(struct sbp2_lu *lu, >> >> management_agent_addr = 0; >> unit_characteristics = 0; >> + if (!unit_characteristics) >> + unit_characteristics = 0; >> firmware_revision = SBP2_ROM_VALUE_MISSING; >> model = ud->flags& UNIT_DIRECTORY_MODEL_ID ? >> ud->model_id : SBP2_ROM_VALUE_MISSING; > > Thanks for the response and info on this. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c index 4565cb5..fcf8bd5 100644 --- a/drivers/ieee1394/sbp2.c +++ b/drivers/ieee1394/sbp2.c @@ -1356,6 +1356,8 @@ static void sbp2_parse_unit_directory(struct sbp2_lu *lu, management_agent_addr = 0; unit_characteristics = 0; + if (!unit_characteristics) + unit_characteristics = 0; firmware_revision = SBP2_ROM_VALUE_MISSING; model = ud->flags & UNIT_DIRECTORY_MODEL_ID ? ud->model_id : SBP2_ROM_VALUE_MISSING;