tm6000: bugfix image position

Message ID	1273246144-6876-1-git-send-email-stefan.ringel@arcor.de (mailing list archive)
State	Superseded, archived
Headers	Envelope-to: mchehab@infradead.org Delivery-date: Fri, 07 May 2010 15:31:09 +0000 sender: stefan.ringel@arcor.de) by mail-in-09.arcor-online.net (Postfix) with ESMTPA id A3F1D197A70; Fri, 7 May 2010 17:30:42 +0200 (CEST) From: stefan.ringel@arcor.de To: linux-media@vger.kernel.org Cc: mchehab@redhat.com, Stefan Ringel <stefan.ringel@arcor.de> Subject: [PATCH] tm6000: bugfix image position Date: Fri, 7 May 2010 17:29:04 +0200 Message-Id: <1273246144-6876-1-git-send-email-stefan.ringel@arcor.de> Sender: linux-media-owner@vger.kernel.org Precedence: bulk

Message ID

1273246144-6876-1-git-send-email-stefan.ringel@arcor.de (mailing list archive)

State

Superseded, archived

Headers

Envelope-to: mchehab@infradead.org
Delivery-date: Fri, 07 May 2010 15:31:09 +0000
From: stefan.ringel@arcor.de
To: linux-media@vger.kernel.org
Cc: mchehab@redhat.com, Stefan Ringel <stefan.ringel@arcor.de>
Subject: [PATCH] tm6000: bugfix image position
Date: Fri,  7 May 2010 17:29:04 +0200
Message-Id: <1273246144-6876-1-git-send-email-stefan.ringel@arcor.de>
Sender: linux-media-owner@vger.kernel.org
Precedence: bulk

Commit Message

Stefan Ringel May 7, 2010, 3:29 p.m. UTC

  From: Stefan Ringel <stefan.ringel@arcor.de>

bugfix incorrect image and line position in videobuffer


Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
---
 drivers/staging/tm6000/tm6000-video.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Stefan Ringel May 7, 2010, 3:46 p.m. UTC | #1

Am 07.05.2010 17:29, schrieb stefan.ringel@arcor.de:
> From: Stefan Ringel <stefan.ringel@arcor.de>
>
> bugfix incorrect image and line position in videobuffer
>
>
> Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
> ---
>  drivers/staging/tm6000/tm6000-video.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/tm6000/tm6000-video.c b/drivers/staging/tm6000/tm6000-video.c
> index 9554472..f7248f0 100644
> --- a/drivers/staging/tm6000/tm6000-video.c
> +++ b/drivers/staging/tm6000/tm6000-video.c
> @@ -223,8 +223,8 @@ static int copy_packet(struct urb *urb, u32 header, u8 **ptr, u8 *endp,
>  			 * It should, instead, check if the user selected
>  			 * entrelaced or non-entrelaced mode
>  			 */
> -			pos= ((line<<1)+field)*linewidth +
> -				block*TM6000_URB_MSG_LEN;
> +			pos = ((line << 1) - field - 1) * linewidth +
> +				block * TM6000_URB_MSG_LEN;
>  
>  			/* Don't allow to write out of the buffer */
>  			if (pos+TM6000_URB_MSG_LEN > (*buf)->vb.size) {
>   


http://www.stefanringel.de/pub/tm6000_image_07_05_2010.jpg

Bee Hock Goh May 7, 2010, 6:17 p.m. UTC | #2

Stefan,

This fix the ugly green line on the top.

btw, do you notice that there seem to be black gap on the left and
right of the screen?

On Fri, May 7, 2010 at 11:46 PM, Stefan Ringel <stefan.ringel@arcor.de> wrote:
> Am 07.05.2010 17:29, schrieb stefan.ringel@arcor.de:
>> From: Stefan Ringel <stefan.ringel@arcor.de>
>>
>> bugfix incorrect image and line position in videobuffer
>>
>>
>> Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
>> ---
>>  drivers/staging/tm6000/tm6000-video.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/tm6000/tm6000-video.c b/drivers/staging/tm6000/tm6000-video.c
>> index 9554472..f7248f0 100644
>> --- a/drivers/staging/tm6000/tm6000-video.c
>> +++ b/drivers/staging/tm6000/tm6000-video.c
>> @@ -223,8 +223,8 @@ static int copy_packet(struct urb *urb, u32 header, u8 **ptr, u8 *endp,
>>                        * It should, instead, check if the user selected
>>                        * entrelaced or non-entrelaced mode
>>                        */
>> -                     pos= ((line<<1)+field)*linewidth +
>> -                             block*TM6000_URB_MSG_LEN;
>> +                     pos = ((line << 1) - field - 1) * linewidth +
>> +                             block * TM6000_URB_MSG_LEN;
>>
>>                       /* Don't allow to write out of the buffer */
>>                       if (pos+TM6000_URB_MSG_LEN > (*buf)->vb.size) {
>>
>
>
> http://www.stefanringel.de/pub/tm6000_image_07_05_2010.jpg
>
> --
> Stefan Ringel <stefan.ringel@arcor.de>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Stefan Ringel May 7, 2010, 6:37 p.m. UTC | #3

Am 07.05.2010 20:17, schrieb Bee Hock Goh:
> Stefan,
>
> This fix the ugly green line on the top.
>
> btw, do you notice that there seem to be black gap on the left and
> right of the screen?
>   
Have you seen my picture? I corrected that field inverted is, ergo line
1 field 1 is line 0, line 1 field 0 is line 1, line 2 field 1 is line 2,
line 2 field 0 is line 3 ... . I have not wrote from the black gap -
that is video calibration! And what for ugly green  line, what I have is
a green code and that is normal!
> On Fri, May 7, 2010 at 11:46 PM, Stefan Ringel <stefan.ringel@arcor.de> wrote:
>   
>> Am 07.05.2010 17:29, schrieb stefan.ringel@arcor.de:
>>     
>>> From: Stefan Ringel <stefan.ringel@arcor.de>
>>>
>>> bugfix incorrect image and line position in videobuffer
>>>
>>>
>>> Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
>>> ---
>>>  drivers/staging/tm6000/tm6000-video.c |    4 ++--
>>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/staging/tm6000/tm6000-video.c b/drivers/staging/tm6000/tm6000-video.c
>>> index 9554472..f7248f0 100644
>>> --- a/drivers/staging/tm6000/tm6000-video.c
>>> +++ b/drivers/staging/tm6000/tm6000-video.c
>>> @@ -223,8 +223,8 @@ static int copy_packet(struct urb *urb, u32 header, u8 **ptr, u8 *endp,
>>>                        * It should, instead, check if the user selected
>>>                        * entrelaced or non-entrelaced mode
>>>                        */
>>> -                     pos= ((line<<1)+field)*linewidth +
>>> -                             block*TM6000_URB_MSG_LEN;
>>> +                     pos = ((line << 1) - field - 1) * linewidth +
>>> +                             block * TM6000_URB_MSG_LEN;
>>>
>>>                       /* Don't allow to write out of the buffer */
>>>                       if (pos+TM6000_URB_MSG_LEN > (*buf)->vb.size) {
>>>
>>>       
>>
>> http://www.stefanringel.de/pub/tm6000_image_07_05_2010.jpg
>>
>> --
>> Stefan Ringel <stefan.ringel@arcor.de>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>     
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

diff mbox

Patch

diff --git a/drivers/staging/tm6000/tm6000-video.c b/drivers/staging/tm6000/tm6000-video.c
index 9554472..f7248f0 100644
--- a/drivers/staging/tm6000/tm6000-video.c
+++ b/drivers/staging/tm6000/tm6000-video.c
@@ -223,8 +223,8 @@  static int copy_packet(struct urb *urb, u32 header, u8 **ptr, u8 *endp,
 			 * It should, instead, check if the user selected
 			 * entrelaced or non-entrelaced mode
 			 */
-			pos= ((line<<1)+field)*linewidth +
-				block*TM6000_URB_MSG_LEN;
+			pos = ((line << 1) - field - 1) * linewidth +
+				block * TM6000_URB_MSG_LEN;
 
 			/* Don't allow to write out of the buffer */
 			if (pos+TM6000_URB_MSG_LEN > (*buf)->vb.size) {