[review] gspca - stv06xx: remove needless if check and goto

Message ID	1244545180.28249.8.camel@tux.localhost (mailing list archive)
State	Superseded, archived
Headers	Envelope-to: mchehab@infradead.org Delivery-date: Tue, 09 Jun 2009 10:59:48 +0000 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=atRTRsIry+3YN8zK9TYPbXpHAzxI4TXciE3fr919PKpxLtUAiWneVrNAKhCi/+OszF l2EVymHukwM/Mpg/+BHy2F1PJZXqiHXjCqMdas8nhPUNoChAKyjXso3xwiu7EZE4FXWg 1eMF8Kc30ZWpd1oZXk9f5cChZxePPFfQmVK5E= Subject: [patch review] gspca - stv06xx: remove needless if check and goto From: Alexey Klimov <klimov.linux@gmail.com> To: Jean-Francois Moine <moinejf@free.fr>, Erik =?ISO-8859-1?Q?Andr=E9n?= <erik.andren@gmail.com> Cc: linux-media@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Date: Tue, 09 Jun 2009 14:59:40 +0400 Message-Id: <1244545180.28249.8.camel@tux.localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk

Message ID

1244545180.28249.8.camel@tux.localhost (mailing list archive)

State

Superseded, archived

Headers

Envelope-to: mchehab@infradead.org
Delivery-date: Tue, 09 Jun 2009 10:59:48 +0000
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=subject:from:to:cc:content-type:date:message-id:mime-version
	:x-mailer:content-transfer-encoding;
	b=atRTRsIry+3YN8zK9TYPbXpHAzxI4TXciE3fr919PKpxLtUAiWneVrNAKhCi/+OszF
	l2EVymHukwM/Mpg/+BHy2F1PJZXqiHXjCqMdas8nhPUNoChAKyjXso3xwiu7EZE4FXWg
	1eMF8Kc30ZWpd1oZXk9f5cChZxePPFfQmVK5E=
Subject: [patch review] gspca - stv06xx: remove needless if check and goto
From: Alexey Klimov <klimov.linux@gmail.com>
To: Jean-Francois Moine <moinejf@free.fr>,
	Erik =?ISO-8859-1?Q?Andr=E9n?= <erik.andren@gmail.com>
Cc: linux-media@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Date: Tue, 09 Jun 2009 14:59:40 +0400
Message-Id: <1244545180.28249.8.camel@tux.localhost>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-media-owner@vger.kernel.org
Precedence: bulk

Commit Message

Alexey Klimov June 9, 2009, 10:59 a.m. UTC

  Hello, Jean-Francois and Erik André

What do you think about such small change?
Looks like the code doesn't need if-check and goto here in stv06xx_stopN
function. The code after label "out" does this.

--
Patch removes needless if check and goto. 


Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
--

Comments

Erik Andrén June 9, 2009, 11:37 a.m. UTC | #1

2009/6/9 Alexey Klimov <klimov.linux@gmail.com>:
> Hello, Jean-Francois and Erik André
>
> What do you think about such small change?
> Looks like the code doesn't need if-check and goto here in stv06xx_stopN
> function. The code after label "out" does this.
>
> --
> Patch removes needless if check and goto.
>
>
> Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>

Looks sane.
Thank you for reporting.

Best regards,
Erik

Reviewed-by: Erik Andrén <erik.andren@gmail.com>


> --
> diff -r ed3781a79c73 linux/drivers/media/video/gspca/stv06xx/stv06xx.c
> --- a/linux/drivers/media/video/gspca/stv06xx/stv06xx.c Sat Jun 06 16:31:34 2009 +0400
> +++ b/linux/drivers/media/video/gspca/stv06xx/stv06xx.c Tue Jun 09 14:49:04 2009 +0400
> @@ -293,8 +293,6 @@
>                goto out;
>
>        err = sd->sensor->stop(sd);
> -       if (err < 0)
> -               goto out;
>
>  out:
>        if (err < 0)
>
>
> --
> Best regards, Klimov Alexey
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

diff mbox

Patch

diff -r ed3781a79c73 linux/drivers/media/video/gspca/stv06xx/stv06xx.c
--- a/linux/drivers/media/video/gspca/stv06xx/stv06xx.c	Sat Jun 06 16:31:34 2009 +0400
+++ b/linux/drivers/media/video/gspca/stv06xx/stv06xx.c	Tue Jun 09 14:49:04 2009 +0400
@@ -293,8 +293,6 @@ 
 		goto out;
 
 	err = sd->sensor->stop(sd);
-	if (err < 0)
-		goto out;
 
 out:
 	if (err < 0)