radio-mr800: fix radio->muted and radio->stereo
Commit Message
Hello, Mauro
This is simple fix for mr800 usb radio driver.
It would be great to have it in next upstream pull request if you don't
mind.
---
Move radio->muted and radio->stereo in section where radio mutex is
locked to avoid possible race condition problems or access to memory.
Thanks to David Ellingsworth <david@identd.dyndns.org> for pointing to
this weak place in driver.
Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
--
@@ -197,9 +197,9 @@
return retval;
}
+ radio->muted = 0;
+
mutex_unlock(&radio->lock);
-
- radio->muted = 0;
return retval;
}
@@ -233,9 +233,9 @@
return retval;
}
+ radio->muted = 1;
+
mutex_unlock(&radio->lock);
-
- radio->muted = 1;
return retval;
}
@@ -287,9 +287,9 @@
return retval;
}
+ radio->stereo = 0;
+
mutex_unlock(&radio->lock);
-
- radio->stereo = 0;
return retval;
}