Message ID | 20240624-b4-sc7180-camss-v3-0-89ece6471431@gmail.com (mailing list archive) |
---|---|
Headers |
Received: from am.mirrors.kernel.org ([147.75.80.249]) by linuxtv.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from <linux-media+bounces-14052-patchwork=linuxtv.org@vger.kernel.org>) id 1sLiaW-0006qt-0n for patchwork@linuxtv.org; Mon, 24 Jun 2024 12:14:25 +0000 Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C7B151F23A05 for <patchwork@linuxtv.org>; Mon, 24 Jun 2024 12:14:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 608C113C904; Mon, 24 Jun 2024 12:13:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rwkXoAdg" X-Original-To: linux-media@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C687A13B58C; Mon, 24 Jun 2024 12:13:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719231235; cv=none; b=P3zxfWCmUUCDXb4VvCtB4St7cRo/mS3Zj82HFDdgHHzO1USy6gg4eihjQUqKCdHjSEYIWPJD+bcVwXUeqag3gj+GAvwAf8f/0yB5HVMajl5q40ZErg3Utfh1BuFTjXW8UNO2EU7gVvae99YwNcf7s9k3rbmAG3gcd67T95GMy6k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719231235; c=relaxed/simple; bh=uy73nECnRMqzWXZWj+nUmjnDanqevHH++6Wp38u6IsU=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=T+8gnKHAChUGChKF5RX0PtWJ0ZrbuOij7lbwQr2jygocss7Dr3yKOyN19Ye0VwSBYAS0xVz7AcRdDGKCCImdGlXAthjuAS6C8Z/xNq0JnDt7Gw7ICIA2ZoYHUqVJ3liBP+xdgKTRv3jdPmCJ4VLJyS0sYIJnAPPLww+EbfzWZ0c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rwkXoAdg; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id 5284DC2BBFC; Mon, 24 Jun 2024 12:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719231235; bh=uy73nECnRMqzWXZWj+nUmjnDanqevHH++6Wp38u6IsU=; h=From:Subject:Date:To:Cc:Reply-To:From; b=rwkXoAdgmp3Lk+q8iotjtH/uKcsjS4jetbliTbkCKmdwVUrRHlN2t75dKlPEbazk8 JFitVuhq0XXgQeM5BUUmYk4g5XEYvHNoev3W+q6nCbNdts56WmOkt7+D4z9vrY9ac/ 3BGItGTfTfAferA+OMt3LeYwtAf6xuLMyVQCCXjHWDbc/1oSx5H41OUnSxibR2AoNY F4ItgfvxzvGom+F2QEvgHxK/EDjQwU5E10tf1az7L82om45BATr2g1eMQIjKMRHlnm ovP8CIysP/bYzIvYTfEwna1CAASNGwdWhssYvx8bYk5Ml7RImr5j3SuRA9H4+USVgE t/nVUG6N1dvVg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 457E2C2BD09; Mon, 24 Jun 2024 12:13:55 +0000 (UTC) From: George Chan via B4 Relay <devnull+gchan9527.gmail.com@kernel.org> Subject: [PATCH RFT v3 0/5] Add sc7180 camss subsys support Date: Mon, 24 Jun 2024 20:13:11 +0800 Message-Id: <20240624-b4-sc7180-camss-v3-0-89ece6471431@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: <linux-media.vger.kernel.org> List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIANdieWYC/3WNywrCMBREf0Xu2sjNw9a4cuUHiDtxkd6kbcC2k khQSv/dkFVBXM4M58wM0QXvIhw3MwSXfPTTmIPcboB6M3aOeZszCBQKK8FZo1ikmh+QkRliZGQ tVU2FRjcKMvUMrvXvYrzB5XyFey57H19T+JSXxMv0V5g4Q8aVlrUWupXoTt1g/GNH01BcSax59 cuLzKNtHVnaI9ZyzS/L8gUgGIAC8wAAAA== To: Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>, Bryan O'Donoghue <bryan.odonoghue@linaro.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, cros-qcom-dts-watchers@chromium.org, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org> Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, George Chan <gchan9527@gmail.com> X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1719231232; l=3098; i=gchan9527@gmail.com; s=20240621; h=from:subject:message-id; bh=uy73nECnRMqzWXZWj+nUmjnDanqevHH++6Wp38u6IsU=; b=CM8dnmVud0cLkAU2X0elJCsTBQWq5F43ym08E/YAzq4NDa/eKKUvqirK5z6KNOcWs11O68zr5 hceLKbLVQWhDmpv30hJ/gbpsNUua+tN2dlJwEt6ltzZYba4MNOHphC/ X-Developer-Key: i=gchan9527@gmail.com; a=ed25519; pk=Ac2fkTqgUBlj2sns9hRIWJTYhWHO1BsmHbdBb5UpUUY= X-Endpoint-Received: by B4 Relay for gchan9527@gmail.com/20240621 with auth_id=176 X-Original-From: George Chan <gchan9527@gmail.com> Reply-To: gchan9527@gmail.com X-LSpam-Score: -3.9 (---) X-LSpam-Report: No, score=-3.9 required=5.0 tests=ARC_SIGNED=0.001,ARC_VALID=-0.1,BAYES_00=-1.9,DKIMWL_WL_HIGH=-1,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DMARC_PASS=-0.001,FREEMAIL_REPLYTO_END_DIGIT=0.25,MAILING_LIST_MULTI=-1,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no |
Series |
Add sc7180 camss subsys support
|
|
Message
George Chan via B4 Relay
June 24, 2024, 12:13 p.m. UTC
SM7125 is the SoC found in the Xiaomi Redmi Note 9 Pro(joyeuse) cellphone.
This series adds support to bring up the CSIPHY, CSID, VFE/RDI interfaces.
Since SM7125 is a low-speed variant of SC7180, SC7180 testers please
take a look and have a test as well.
sc7180 provides
- 2 x VFE
- 1 x VFE Lite
- 2 x CSID
- 1 x CSID Lite
- 4 x CSI PHY
The sc7180-camss binding should be comaptible with sdm845 yaml.
I've copied a new yaml from sdm845-camss.yaml, strip all _src clk and
put new maintainer information. If this is not desirable then i can add binding to
existing sdm845 yaml instead.
In addition, a bootable tree of sm7125/joyeuse is availble at:
https://github.com/99degree/linux/tree/camss
Signed-off-by: George Chan <gchan9527@gmail.com>
---
Changes in v3:
- Rebased on 20240522154659.510-1-quic_grosikop@quicinc.com - Bryan
- Align email title to sc8280xp series - krzk
- Line-up dt-binding example ordering to same as qcom,sm8250-camss.yaml - krzk
- Drop non-related patches #5 #6 #7, I will send follow-up patches later
- Add RFT tag to all patches, since no tested-by at all.
- Drop required-opps node from dt
- Link to v2: https://lore.kernel.org/r/20240624-b4-sc7180-camss-v2-0-0dfecdc50073@gmail.com
Changes in v2:
- Revised dt-binding title - krzk
- Revised dt-binding maintainers - krzk
- Drop all dt-binding minItems - krzk
- Drops "|" symbol postfixed to description - krzk
- Accending order of dt-binding required list - krzk
- Added dt-binding item power-domain-name - Bryan
- Reformat dt-binding example - krzk
- Move reg as 2nd property - krzk
- Move reg-names as 3nd property - krzk
- Reduce iommus maxItems to 3 - rob's bot
- Reduce clocks maxItems to 24 - rob's bot
- Combine patch #2 and #3 - krzk and Bryan
- Split eror-print log for clk name from #5 - Konrad
- Reformat dt-node - krzk
- Corrected phy init sequence for v1.2.2 - Bryan
- Added 3 more debug info for missing clk and low clk-rate issue.
- Adding port info to ports sub-node
- Adding required-opps node to dt
- Link to v1: https://lore.kernel.org/r/20240621-b4-sc7180-camss-v1-0-14937929f30e@gmail.com
---
George Chan (5):
dt-bindings: media: camss: Add qcom,sc7180-camss
media: camss: csiphy-3ph: Add Gen2 v1.2.2 two-phase MIPI CSI-2 DPHY init
media: qcom: camss: Add sc7180 support
media: qcom: camss: Add sc7180 resources
arm64: dts: qcom: sc7180: camss: Add CAMSS block definition
.../bindings/media/qcom,sc7180-camss.yaml | 328 +++++++++++++++++++++
arch/arm64/boot/dts/qcom/sc7180.dtsi | 133 +++++++++
.../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 135 +++++++++
drivers/media/platform/qcom/camss/camss-vfe.c | 2 +
drivers/media/platform/qcom/camss/camss.c | 251 ++++++++++++++++
drivers/media/platform/qcom/camss/camss.h | 1 +
6 files changed, 850 insertions(+)
---
base-commit: 28f69d2ea67db489d4a94e7d04c21b14e5aa6535
change-id: 20240621-b4-sc7180-camss-cddc6b60a9b4
Best regards,
Comments
On 24/06/2024 13:13, George Chan via B4 Relay wrote:
> - Add RFT tag to all patches, since no tested-by at all.
Have you not tested this updated series ?
---
bod
On Mon, Jun 24, 2024 at 9:50 PM Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: > > On 24/06/2024 13:13, George Chan via B4 Relay wrote: > > - Add RFT tag to all patches, since no tested-by at all. > > Have you not tested this updated series ? > > --- > bod Do you wanna add my tested-by too? It just feels weird to add my tested-by that way. Tested: Linus tree 5f583a3162ffd9f7999af76b8ab634ce2dac9f90 + 20240522154659.510-1-quic_grosikop@quicinc.com with mine patches Not test: linux-next + 20240522154659.510-1-quic_grosikop@quicinc.com + mine Just for reference, last month i pushed grosikop's patch with mine to below: https://github.com/99degree/linux/tree/camss-working
On 24.06.2024 5:03 PM, george chan wrote: > On Mon, Jun 24, 2024 at 9:50 PM Bryan O'Donoghue > <bryan.odonoghue@linaro.org> wrote: >> >> On 24/06/2024 13:13, George Chan via B4 Relay wrote: >>> - Add RFT tag to all patches, since no tested-by at all. >> >> Have you not tested this updated series ? >> >> --- >> bod > > Do you wanna add my tested-by too? It just feels weird to add my > tested-by that way. "RFT" means "I didn't actually test this" or "please provide more testing", not "there have not been tested-by's from others" Konrad
On 25/06/2024 17:57, Konrad Dybcio wrote: > On 24.06.2024 5:03 PM, george chan wrote: >> On Mon, Jun 24, 2024 at 9:50 PM Bryan O'Donoghue >> <bryan.odonoghue@linaro.org> wrote: >>> >>> On 24/06/2024 13:13, George Chan via B4 Relay wrote: >>>> - Add RFT tag to all patches, since no tested-by at all. >>> >>> Have you not tested this updated series ? >>> >>> --- >>> bod >> >> Do you wanna add my tested-by too? It just feels weird to add my >> tested-by that way. > > "RFT" means "I didn't actually test this" or "please provide more testing", > not "there have not been tested-by's from others" > > Konrad Exactly, RFT says to me "someone else needs to add testing here". In your next drop with the changes and RBs please drop RFT - unless you want someone else to test it for you. I don't think that's required right now since the set seems straight-forward enough and TBH the bit of 7180 hardware I have sits in a box unopened and will likely stay that way for the next few months at least. I think your example video is proof enough the thing works ;) --- bod
On Wed, Jun 26, 2024 at 7:44 AM Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: > > On 25/06/2024 17:57, Konrad Dybcio wrote: > > On 24.06.2024 5:03 PM, george chan wrote: > >> On Mon, Jun 24, 2024 at 9:50 PM Bryan O'Donoghue > >> <bryan.odonoghue@linaro.org> wrote: > >>> > >>> On 24/06/2024 13:13, George Chan via B4 Relay wrote: > >>>> - Add RFT tag to all patches, since no tested-by at all. > >>> > >>> Have you not tested this updated series ? > >>> > >>> --- > >>> bod > >> > >> Do you wanna add my tested-by too? It just feels weird to add my > >> tested-by that way. > > > > "RFT" means "I didn't actually test this" or "please provide more testing", > > not "there have not been tested-by's from others" > > > > Konrad > > Exactly, RFT says to me "someone else needs to add testing here". > gotcha. > In your next drop with the changes and RBs please drop RFT - unless you > want someone else to test it for you. > If the test result on sm7125 is convincing then I have no problem. > I don't think that's required right now since the set seems > straight-forward enough and TBH the bit of 7180 hardware I have sits in > a box unopened and will likely stay that way for the next few months at > least. > > I think your example video is proof enough the thing works ;) Nice to hear. > > --- > bod