mbox series

[0/4] Omnivision OV4689 cropping and binning

Message ID 20240616202433.227895-1-mike.rudenko@gmail.com (mailing list archive)
Headers
Series Omnivision OV4689 cropping and binning |

Message

Mikhail Rudenko June 16, 2024, 8:24 p.m. UTC 
  This small series consists of patches 17-20 from [1], which were
requested to merged separately later. No significant changes have been
made since and the R-b's are kept.

Patch 1 implements configurable analogue crop rectangle via
.set_selection callback. Patches 2 and 3 are refactorings and are not
supposed to introduce any functional change. Patch 4 enables 2x2
binning option.

[1] https://lore.kernel.org/all/20240402164552.19171-1-mike.rudenko@gmail.com/

Mikhail Rudenko (4):
  media: i2c: ov4689: Configurable analogue crop
  media: i2c: ov4689: Eliminate struct ov4689_mode
  media: i2c: ov4689: Refactor ov4689_s_stream
  media: i2c: ov4689: Implement 2x2 binning

 drivers/media/i2c/ov4689.c | 483 +++++++++++++++++++++++++------------
 1 file changed, 328 insertions(+), 155 deletions(-)

--
2.45.2

Comments

Mikhail Rudenko Aug. 14, 2024, 11:01 p.m. UTC | #1 
On 2024-06-16 at 23:24 +03, Mikhail Rudenko <mike.rudenko@gmail.com> wrote:

> This small series consists of patches 17-20 from [1], which were
> requested to merged separately later. No significant changes have been
> made since and the R-b's are kept.
>
> Patch 1 implements configurable analogue crop rectangle via
> .set_selection callback. Patches 2 and 3 are refactorings and are not
> supposed to introduce any functional change. Patch 4 enables 2x2
> binning option.
>
> [1] https://lore.kernel.org/all/20240402164552.19171-1-mike.rudenko@gmail.com/
>
> Mikhail Rudenko (4):
>   media: i2c: ov4689: Configurable analogue crop
>   media: i2c: ov4689: Eliminate struct ov4689_mode
>   media: i2c: ov4689: Refactor ov4689_s_stream
>   media: i2c: ov4689: Implement 2x2 binning
>
>  drivers/media/i2c/ov4689.c | 483 +++++++++++++++++++++++++------------
>  1 file changed, 328 insertions(+), 155 deletions(-)

Gentle ping.

Sakari, in [1] you said the these four patches should be postponed until
internal API refactoring is complete. Is it complete now? Could you
point out the places where new API should be used?

[1] https://lore.kernel.org/all/ZhzEdXz-R2I6nZXf@kekkonen.localdomain/

--
Best regards,
Mikhail Rudenko