mbox series

[v4l-utils,v1,0/3] media-ctl: Add support for subdev TRY state

Message ID 20240610012238.30462-1-laurent.pinchart@ideasonboard.com (mailing list archive)
Headers
Series media-ctl: Add support for subdev TRY state |

Message

Laurent Pinchart June 10, 2024, 1:22 a.m. UTC 
  Hello,

This small patch series extends media-ctl to support subdev TRY states.
Doing so allows retrieving the default state of subdevs, or trying
configurations.

The approach is quite straightforward: patch 1/3 replaces the hardcoded
ACTIVE state in libv4l2subdev with a 'which' argument, patch 2/3 does
the same for the internal functions of media-ctl, and patch 3/3 adds a
-W/--which argument to media-ctl. When the argument is not set, the
ACTIVE state is selected, preserving the existing behaviour.

Laurent Pinchart (3):
  libv4l2subdev: Extend API with 'which' argument where missing
  utils: media-ctl: Prepare for TRY state support
  utils: media-ctl: Support accessing the subdev TRY state

 utils/media-ctl/libv4l2subdev.c | 65 +++++++++++++++++++++------------
 utils/media-ctl/media-ctl.c     | 37 +++++++++++--------
 utils/media-ctl/options.c       | 18 ++++++++-
 utils/media-ctl/options.h       |  1 +
 utils/media-ctl/v4l2subdev.h    | 49 ++++++++++++++++++++++---
 5 files changed, 123 insertions(+), 47 deletions(-)


base-commit: f4cf30a8b50f54210e181ecadbffaee4ce088e5e

Comments

Sakari Ailus June 10, 2024, 7:08 a.m. UTC | #1 
Hi Laurent,

On Mon, Jun 10, 2024 at 04:22:35AM +0300, Laurent Pinchart wrote:
> Hello,
> 
> This small patch series extends media-ctl to support subdev TRY states.
> Doing so allows retrieving the default state of subdevs, or trying
> configurations.
> 
> The approach is quite straightforward: patch 1/3 replaces the hardcoded
> ACTIVE state in libv4l2subdev with a 'which' argument, patch 2/3 does
> the same for the internal functions of media-ctl, and patch 3/3 adds a
> -W/--which argument to media-ctl. When the argument is not set, the
> ACTIVE state is selected, preserving the existing behaviour.

Thanks! For the set:

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>