[00/23] media: atomisp: Further media-controller related fixes + dead code removal

  Hi all,

This patch-set contains a couple of atomisp driver fixes for issues which
I found while working on a libcamera pipeline handler for the atomisp
(and thus controlling the atomisp driver in a more media-controller centric
fashion).

Patches 1-8 are more or less prep work for fixing an ABBA deadlock in
atomisp_link_setup() in patch 9.

Diving into the code for this made my hands itch to remove of bunch of
atomisp custom internal APIs for things like flash support, so the rest
of the series is just removing a whole bunch of dead / unwanted code.

This series is also available here:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

I'll do a forced push there addressing any review-comments + adding
tags before adding a signed-tag for a pull-request to Mauro for this.

Regards,

Hans


Hans de Goede (23):
  media: atomisp: Add atomisp_s_sensor_power() helper
  media: atomisp: Turn on sensor power from atomisp_set_fmt()
  media: atomisp: Add atomisp_select_input() helper
  media: atomisp: Simplify atomisp_s_input() input argument checking
  media: atomisp: Ensure CSI-receiver[x] -> ISP links correctly reflect
    current sensor
  media: atomisp: Propagate set_fmt on sensor results to CSI port
  media: atomisp: Propagate v4l2_mbus_framefmt.field to CSI port sink
    pad
  media: atomisp: Call media_pipeline_alloc_start() in stream start
  media: atomisp: Drop atomisp_pipe_check() from atomisp_link_setup()
  media: atomisp: ov2722: Remove power on sensor from set_fmt() callback
  media: atomisp: Remove test pattern generator (TPG) support
  media: atomisp: Remove input_port_ID_t
  media: atomisp: Drop the atomisp custom lm3554 flash driver
  media: atomisp: Drop custom flash support
  media: atomisp: Drop unused frame_status tracking
  media: atomisp: Drop intel_v4l2_subdev_type
  media: atomisp: Remove gmin_platform VCM code.
  media: atomisp: Remove struct atomisp_platform_data
  media: atomisp: Remove clearing of ISP crop / compose rectangles on
    file release
  media: atomisp: Remove empty s_power() op from ISP subdev
  media: atomisp: Remove empty s_stream() op from CSI subdev
  media: atomisp: Cleanup atomisp_isr_thread() spinlock handling
  media: atomisp: Remove setting of f->fmt.pix.priv from
    atomisp_set_fmt()

 drivers/staging/media/atomisp/Makefile        |   1 -
 drivers/staging/media/atomisp/i2c/Kconfig     |  15 -
 drivers/staging/media/atomisp/i2c/Makefile    |   5 -
 .../media/atomisp/i2c/atomisp-gc2235.c        |   2 +-
 .../media/atomisp/i2c/atomisp-lm3554.c        | 955 ------------------
 .../media/atomisp/i2c/atomisp-mt9m114.c       |   2 +-
 .../media/atomisp/i2c/atomisp-ov2722.c        |  14 +-
 drivers/staging/media/atomisp/i2c/ov2722.h    |   1 -
 .../media/atomisp/include/linux/atomisp.h     |  57 --
 .../include/linux/atomisp_gmin_platform.h     |   6 +-
 .../atomisp/include/linux/atomisp_platform.h  |  40 +-
 .../media/atomisp/include/media/lm3554.h      | 132 ---
 .../staging/media/atomisp/pci/atomisp_cmd.c   | 255 ++---
 .../staging/media/atomisp/pci/atomisp_cmd.h   |  13 +-
 .../media/atomisp/pci/atomisp_compat_css20.c  |  31 +-
 .../staging/media/atomisp/pci/atomisp_csi2.c  |  26 +-
 .../staging/media/atomisp/pci/atomisp_fops.c  |  49 +-
 .../media/atomisp/pci/atomisp_gmin_platform.c |  95 +-
 .../media/atomisp/pci/atomisp_internal.h      |  12 +-
 .../staging/media/atomisp/pci/atomisp_ioctl.c | 135 +--
 .../media/atomisp/pci/atomisp_subdev.c        |  46 +-
 .../media/atomisp/pci/atomisp_subdev.h        |  17 +-
 .../staging/media/atomisp/pci/atomisp_tpg.c   | 164 ---
 .../staging/media/atomisp/pci/atomisp_tpg.h   |  39 -
 .../staging/media/atomisp/pci/atomisp_v4l2.c  |  87 +-
 .../hive_isp_css_common/host/input_system.c   |  38 -
 drivers/staging/media/atomisp/pci/ia_css.h    |   1 -
 .../media/atomisp/pci/ia_css_frame_public.h   |   8 -
 .../media/atomisp/pci/ia_css_stream_public.h  |  17 -
 .../staging/media/atomisp/pci/ia_css_tpg.h    |  79 --
 .../atomisp/pci/isp2400_input_system_global.h |   1 -
 .../atomisp/pci/isp2400_input_system_public.h |  15 -
 .../atomisp/pci/isp2401_input_system_global.h |   1 -
 .../pci/runtime/debug/src/ia_css_debug.c      |  17 -
 .../atomisp/pci/runtime/ifmtr/src/ifmtr.c     |  11 -
 .../pci/runtime/isys/src/virtual_isys.c       |  28 +-
 drivers/staging/media/atomisp/pci/sh_css.c    | 121 +--
 .../media/atomisp/pci/sh_css_internal.h       |   1 -
 .../staging/media/atomisp/pci/sh_css_mipi.c   |   2 +-
 drivers/staging/media/atomisp/pci/sh_css_sp.c |  14 -
 drivers/staging/media/atomisp/pci/sh_css_sp.h |   7 -
 .../staging/media/atomisp/pci/system_global.h |  12 -
 42 files changed, 211 insertions(+), 2361 deletions(-)
 delete mode 100644 drivers/staging/media/atomisp/i2c/atomisp-lm3554.c
 delete mode 100644 drivers/staging/media/atomisp/include/media/lm3554.h
 delete mode 100644 drivers/staging/media/atomisp/pci/atomisp_tpg.c
 delete mode 100644 drivers/staging/media/atomisp/pci/atomisp_tpg.h
 delete mode 100644 drivers/staging/media/atomisp/pci/ia_css_tpg.h
  

On Mon, Apr 15, 2024 at 02:01:57PM +0200, Hans de Goede wrote:
> Hi all,
> 
> This patch-set contains a couple of atomisp driver fixes for issues which
> I found while working on a libcamera pipeline handler for the atomisp
> (and thus controlling the atomisp driver in a more media-controller centric
> fashion).
> 
> Patches 1-8 are more or less prep work for fixing an ABBA deadlock in
> atomisp_link_setup() in patch 9.
> 
> Diving into the code for this made my hands itch to remove of bunch of
> atomisp custom internal APIs for things like flash support, so the rest
> of the series is just removing a whole bunch of dead / unwanted code.
> 
> This series is also available here:
> https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp
> 
> I'll do a forced push there addressing any review-comments + adding
> tags before adding a signed-tag for a pull-request to Mauro for this.

Thank you for doing this nice cleanup!

For non-commented,
Reviewed-by: Andy Shevchenko <andy@kernel.org>
otherwise feel free to add it, if you agree on the suggested improvements.