mbox series

[v2,0/4] media: rkisp1: Misc fixes and debug

Message ID 20231201140433.2126011-1-paul.elder@ideasonboard.com (mailing list archive)
Headers
Series media: rkisp1: Misc fixes and debug |

Message

Paul Elder Dec. 1, 2023, 2:04 p.m. UTC 
  This series adds a small cleanup of the register definitions, as well as
some additions to the debug for the rkisp1 driver.

Paul Elder (4):
  media: rkisp1: regs: Consolidate MI interrupt wrap fields
  media: rkisp1: debug: Add register dump for IS
  media: rkisp1: debug: Count completed frame interrupts
  media: rkisp1: debug: Consolidate counter debugfs files

 .../platform/rockchip/rkisp1/rkisp1-capture.c |  2 +
 .../platform/rockchip/rkisp1/rkisp1-common.h  |  5 ++
 .../platform/rockchip/rkisp1/rkisp1-debug.c   | 71 +++++++++++++------
 .../platform/rockchip/rkisp1/rkisp1-isp.c     |  2 +
 .../platform/rockchip/rkisp1/rkisp1-regs.h    |  9 +--
 5 files changed, 60 insertions(+), 29 deletions(-)

Comments

Tomi Valkeinen Dec. 5, 2023, 8:23 a.m. UTC | #1 
On 01/12/2023 16:04, Paul Elder wrote:
> This series adds a small cleanup of the register definitions, as well as
> some additions to the debug for the rkisp1 driver.
> 
> Paul Elder (4):
>    media: rkisp1: regs: Consolidate MI interrupt wrap fields
>    media: rkisp1: debug: Add register dump for IS
>    media: rkisp1: debug: Count completed frame interrupts
>    media: rkisp1: debug: Consolidate counter debugfs files
> 
>   .../platform/rockchip/rkisp1/rkisp1-capture.c |  2 +
>   .../platform/rockchip/rkisp1/rkisp1-common.h  |  5 ++
>   .../platform/rockchip/rkisp1/rkisp1-debug.c   | 71 +++++++++++++------
>   .../platform/rockchip/rkisp1/rkisp1-isp.c     |  2 +
>   .../platform/rockchip/rkisp1/rkisp1-regs.h    |  9 +--
>   5 files changed, 60 insertions(+), 29 deletions(-)
> 

For the series, with or without the change I proposed for patch 4:

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

  Tomi
Laurent Pinchart Dec. 7, 2023, 2:51 p.m. UTC | #2 
Hi Paul,

Thank you for the patches.

On Fri, Dec 01, 2023 at 11:04:29PM +0900, Paul Elder wrote:
> This series adds a small cleanup of the register definitions, as well as
> some additions to the debug for the rkisp1 driver.
> 
> Paul Elder (4):
>   media: rkisp1: regs: Consolidate MI interrupt wrap fields
>   media: rkisp1: debug: Add register dump for IS
>   media: rkisp1: debug: Count completed frame interrupts
>   media: rkisp1: debug: Consolidate counter debugfs files

I'll take patch 1/4 to 3/4 in my tree already, while the discussion on
4/4 continues. Please let me know if you would rather have me wait.

>  .../platform/rockchip/rkisp1/rkisp1-capture.c |  2 +
>  .../platform/rockchip/rkisp1/rkisp1-common.h  |  5 ++
>  .../platform/rockchip/rkisp1/rkisp1-debug.c   | 71 +++++++++++++------
>  .../platform/rockchip/rkisp1/rkisp1-isp.c     |  2 +
>  .../platform/rockchip/rkisp1/rkisp1-regs.h    |  9 +--
>  5 files changed, 60 insertions(+), 29 deletions(-)